Re: [PATCH] backlight: qcom-wled: Use sink_addr for sync toggle

2021-03-17 Thread Lee Jones
On Sun, 14 Mar 2021, Marijn Suijten wrote: > From: Obeida Shamoun > > WLED3_SINK_REG_SYNC is, as the name implies, a sink register offset. > Therefore, use the sink address as base instead of the ctrl address. > > This fixes the sync toggle on wled4, which can be observed by the fact > that

Re: [PATCH] backlight: qcom-wled: Use sink_addr for sync toggle

2021-03-16 Thread kgunda
On 2021-03-15 17:51, Daniel Thompson wrote: On Sun, Mar 14, 2021 at 11:11:10AM +0100, Marijn Suijten wrote: From: Obeida Shamoun WLED3_SINK_REG_SYNC is, as the name implies, a sink register offset. Therefore, use the sink address as base instead of the ctrl address. This fixes the sync

Re: [PATCH] backlight: qcom-wled: Use sink_addr for sync toggle

2021-03-15 Thread Daniel Thompson
On Sun, Mar 14, 2021 at 11:11:10AM +0100, Marijn Suijten wrote: > From: Obeida Shamoun > > WLED3_SINK_REG_SYNC is, as the name implies, a sink register offset. > Therefore, use the sink address as base instead of the ctrl address. > > This fixes the sync toggle on wled4, which can be observed

[PATCH] backlight: qcom-wled: Use sink_addr for sync toggle

2021-03-14 Thread Marijn Suijten
From: Obeida Shamoun WLED3_SINK_REG_SYNC is, as the name implies, a sink register offset. Therefore, use the sink address as base instead of the ctrl address. This fixes the sync toggle on wled4, which can be observed by the fact that adjusting brightness now works. It has no effect on wled3