Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Linus Torvalds wrote: > Heh. It definitely hasn't gotten lost by "the git software". No, it sure hasn't. In fact it was staring me right in the face and I didn't realize it. > In fact, with > the kinds of hints you already gave, git makes it really _trivial_ to find >

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Linus Torvalds
On Thu, 29 Nov 2007, Alan Stern wrote: > > Yes indeed. I wish I could point you to the exact patch containing the > fix, but the git software seems to have lost track of it (it's combined > in with a large number of other patches with no obvious way to separate > it out). It's also

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Mark Lord wrote: > Alan Stern wrote: > > On Thu, 29 Nov 2007, Mark Lord wrote: > > > >>> So again, the problem is in the higher up scsi layer, and that is where > >>> the problem should already be fixed. > >> .. > >> > >> Ahhh.. so you figure the Oops should also have been

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Greg KH
On Thu, Nov 29, 2007 at 05:07:58PM -0500, Alan Stern wrote: > On Thu, 29 Nov 2007, Mark Lord wrote: > > > > So again, the problem is in the higher up scsi layer, and that is where > > > the problem should already be fixed. > > .. > > > > Ahhh.. so you figure the Oops should also have been fixed

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Mark Lord
Alan Stern wrote: On Thu, 29 Nov 2007, Mark Lord wrote: So again, the problem is in the higher up scsi layer, and that is where the problem should already be fixed. .. Ahhh.. so you figure the Oops should also have been fixed as part of the 2.6.24 SCSI fixes ? That's what I was missing

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Mark Lord wrote: > > So again, the problem is in the higher up scsi layer, and that is where > > the problem should already be fixed. > .. > > Ahhh.. so you figure the Oops should also have been fixed > as part of the 2.6.24 SCSI fixes ? That's what I was missing here. Yes

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Mark Lord wrote: > (resending with condensed version of original syslog) (Sending a 344-KB log file wasn't enough, you had to send another 46-KB condensed version as well? :-) > Alan Stern wrote: > > On Thu, 29 Nov 2007, Mark Lord wrote: > > > >> But the flogging

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Greg KH
On Thu, Nov 29, 2007 at 03:46:42PM -0500, Mark Lord wrote: > Greg KH wrote: >> So again, the problem is in the higher up scsi layer, and that is where >> the problem should already be fixed. > .. > > Ahhh.. so you figure the Oops should also have been fixed > as part of the 2.6.24 SCSI fixes ?

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Mark Lord
Greg KH wrote: On Thu, Nov 29, 2007 at 03:25:04PM -0500, Mark Lord wrote: (resending .. somebody trimmed the CC: list earlier) Greg KH wrote: Mark Lord wrote: .. While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on a call to strlen() in

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Greg KH
On Thu, Nov 29, 2007 at 03:25:04PM -0500, Mark Lord wrote: > (resending .. somebody trimmed the CC: list earlier) > > Greg KH wrote: > Mark Lord wrote: >> .. >> >> While doing insert/remove (quickly) tests on USB, >> I managed to trigger an Oops on 2.6.23.8 on a call >> to

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Mark Lord
(resending .. somebody trimmed the CC: list earlier) Greg KH wrote: Mark Lord wrote: .. While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on a call to strlen() in make_class_name(). ... I'll hold off on adding this patch for now. .. Why? Bugs

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Mark Lord
(resending with condensed version of original syslog) Alan Stern wrote: On Thu, 29 Nov 2007, Mark Lord wrote: But the flogging continues multiple times per second until the system is shutdown, so it is "the next bug to fix". That's not true. The number of commands sent while probing a

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Mark Lord wrote: > But the flogging continues multiple times per second > until the system is shutdown, so it is "the next bug to fix". That's not true. The number of commands sent while probing a device is predetermined and strictly limited. In any case, what you're

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Greg KH
On Thu, Nov 29, 2007 at 03:01:48PM -0500, Mark Lord wrote: > Alan Stern wrote: >> On Thu, 29 Nov 2007, Mark Lord wrote: >>> Mark Lord wrote: .. While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on a call to strlen() in

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Mark Lord
Alan Stern wrote: On Thu, 29 Nov 2007, Mark Lord wrote: Mark Lord wrote: .. While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on a call to strlen() in make_class_name(). Does this oops occur under 2.6.24? The SCSI async scanning code was changed

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Mark Lord wrote: > Mark Lord wrote: > > .. > > > > While doing insert/remove (quickly) tests on USB, > > I managed to trigger an Oops on 2.6.23.8 on a call > > to strlen() in make_class_name(). Does this oops occur under 2.6.24? The SCSI async scanning code was changed

Re: [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Mark Lord
Mark Lord wrote: .. While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on a call to strlen() in make_class_name(). USB maintainers can try this themselves, by plugging in an external USB XX-in-1 flash reader, with a CF card inserted. Then just jiggle the

[PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Mark Lord
Mark Lord wrote: Mark Lord wrote: Mark Lord wrote: ... And here is a "prevented" oops, courtesy of the patch (2.6.23.8). These are easy to reproduce (just jiggle the connection on an attached USB multi-card reader with a CF card inserted): ... [ 347.099562] usb 5-6: USB disconnect, address

Re: [PATCH] base/class.c: prevent ooops due to insert/remove race

2007-11-29 Thread Mark Lord
Mark Lord wrote: Mark Lord wrote: ... And here is a "prevented" oops, courtesy of the patch (2.6.23.8). These are easy to reproduce (just jiggle the connection on an attached USB multi-card reader with a CF card inserted): ... [ 347.099562] usb 5-6: USB disconnect, address 10 [ 347.101077]

Re: [PATCH] base/class.c: prevent ooops due to insert/remove race

2007-11-29 Thread Mark Lord
Mark Lord wrote: (reposting for linux-usb-devel list) Greg KH wrote: On Wed, Nov 28, 2007 at 11:00:36PM -0500, Mark Lord wrote: While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on the call to strlen() in make_class_name(). This patch prevents this

[PATCH] base/class.c: prevent ooops due to insert/remove race

2007-11-29 Thread Mark Lord
(reposting for linux-usb-devel list) Greg KH wrote: On Wed, Nov 28, 2007 at 11:00:36PM -0500, Mark Lord wrote: While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on the call to strlen() in make_class_name(). This patch prevents this oops. There is

Re: [PATCH] base/class.c: prevent ooops due to insert/remove race

2007-11-29 Thread Greg KH
On Thu, Nov 29, 2007 at 10:41:29AM -0500, Mark Lord wrote: > Greg KH wrote: >> On Wed, Nov 28, 2007 at 11:00:36PM -0500, Mark Lord wrote: >>> While doing insert/remove (quickly) tests on USB, I managed to trigger >>> an Oops on 2.6.23.1 on the call to strlen() in make_class_name(). >>> >>> This

[PATCH] base/class.c: prevent ooops due to insert/remove race (v2)

2007-11-29 Thread Mark Lord
Greg KH wrote: On Wed, Nov 28, 2007 at 11:00:36PM -0500, Mark Lord wrote: While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.1 on the call to strlen() in make_class_name(). This patch prevents this oops. There is still the larger problem of the overall

Re: [PATCH] base/class.c: prevent ooops due to insert/remove race

2007-11-29 Thread Mark Lord
Greg KH wrote: On Wed, Nov 28, 2007 at 11:00:36PM -0500, Mark Lord wrote: While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.1 on the call to strlen() in make_class_name(). This patch prevents this oops. There is still the larger problem of the overall

Re: [PATCH] base/class.c: prevent ooops due to insert/remove race

2007-11-29 Thread Mark Lord
Greg KH wrote: On Wed, Nov 28, 2007 at 11:00:36PM -0500, Mark Lord wrote: While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.1 on the call to strlen() in make_class_name(). This patch prevents this oops. There is still the larger problem of the overall

[PATCH] base/class.c: prevent ooops due to insert/remove race (v2)

2007-11-29 Thread Mark Lord
Greg KH wrote: On Wed, Nov 28, 2007 at 11:00:36PM -0500, Mark Lord wrote: While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.1 on the call to strlen() in make_class_name(). This patch prevents this oops. There is still the larger problem of the overall

Re: [PATCH] base/class.c: prevent ooops due to insert/remove race

2007-11-29 Thread Greg KH
On Thu, Nov 29, 2007 at 10:41:29AM -0500, Mark Lord wrote: Greg KH wrote: On Wed, Nov 28, 2007 at 11:00:36PM -0500, Mark Lord wrote: While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.1 on the call to strlen() in make_class_name(). This patch prevents

[PATCH] base/class.c: prevent ooops due to insert/remove race

2007-11-29 Thread Mark Lord
(reposting for linux-usb-devel list) Greg KH wrote: On Wed, Nov 28, 2007 at 11:00:36PM -0500, Mark Lord wrote: While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on the call to strlen() in make_class_name(). This patch prevents this oops. There is

Re: [PATCH] base/class.c: prevent ooops due to insert/remove race

2007-11-29 Thread Mark Lord
Mark Lord wrote: (reposting for linux-usb-devel list) Greg KH wrote: On Wed, Nov 28, 2007 at 11:00:36PM -0500, Mark Lord wrote: While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on the call to strlen() in make_class_name(). This patch prevents this

Re: [PATCH] base/class.c: prevent ooops due to insert/remove race

2007-11-29 Thread Mark Lord
Mark Lord wrote: Mark Lord wrote: ... And here is a prevented oops, courtesy of the patch (2.6.23.8). These are easy to reproduce (just jiggle the connection on an attached USB multi-card reader with a CF card inserted): ... [ 347.099562] usb 5-6: USB disconnect, address 10 [ 347.101077]

[PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Mark Lord
Mark Lord wrote: Mark Lord wrote: Mark Lord wrote: ... And here is a prevented oops, courtesy of the patch (2.6.23.8). These are easy to reproduce (just jiggle the connection on an attached USB multi-card reader with a CF card inserted): ... [ 347.099562] usb 5-6: USB disconnect, address 10

Re: [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Mark Lord
Mark Lord wrote: .. While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on a call to strlen() in make_class_name(). USB maintainers can try this themselves, by plugging in an external USB XX-in-1 flash reader, with a CF card inserted. Then just jiggle the

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Mark Lord wrote: Mark Lord wrote: .. While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on a call to strlen() in make_class_name(). Does this oops occur under 2.6.24? The SCSI async scanning code was changed between 2.6.23

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Greg KH
On Thu, Nov 29, 2007 at 03:01:48PM -0500, Mark Lord wrote: Alan Stern wrote: On Thu, 29 Nov 2007, Mark Lord wrote: Mark Lord wrote: .. While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on a call to strlen() in make_class_name(). Does this oops

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Mark Lord wrote: But the flogging continues multiple times per second until the system is shutdown, so it is the next bug to fix. That's not true. The number of commands sent while probing a device is predetermined and strictly limited. In any case, what you're talking

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Mark Lord
(resending with condensed version of original syslog) Alan Stern wrote: On Thu, 29 Nov 2007, Mark Lord wrote: But the flogging continues multiple times per second until the system is shutdown, so it is the next bug to fix. That's not true. The number of commands sent while probing a device

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Greg KH
On Thu, Nov 29, 2007 at 03:25:04PM -0500, Mark Lord wrote: (resending .. somebody trimmed the CC: list earlier) Greg KH wrote: Mark Lord wrote: .. While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on a call to strlen() in make_class_name(). ...

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Mark Lord
(resending .. somebody trimmed the CC: list earlier) Greg KH wrote: Mark Lord wrote: .. While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on a call to strlen() in make_class_name(). ... I'll hold off on adding this patch for now. .. Why? Bugs

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Mark Lord
Alan Stern wrote: On Thu, 29 Nov 2007, Mark Lord wrote: Mark Lord wrote: .. While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on a call to strlen() in make_class_name(). Does this oops occur under 2.6.24? The SCSI async scanning code was changed

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Mark Lord
Greg KH wrote: On Thu, Nov 29, 2007 at 03:25:04PM -0500, Mark Lord wrote: (resending .. somebody trimmed the CC: list earlier) Greg KH wrote: Mark Lord wrote: .. While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on a call to strlen() in

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Greg KH
On Thu, Nov 29, 2007 at 03:46:42PM -0500, Mark Lord wrote: Greg KH wrote: So again, the problem is in the higher up scsi layer, and that is where the problem should already be fixed. .. Ahhh.. so you figure the Oops should also have been fixed as part of the 2.6.24 SCSI fixes ? That's what

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Mark Lord wrote: (resending with condensed version of original syslog) (Sending a 344-KB log file wasn't enough, you had to send another 46-KB condensed version as well? :-) Alan Stern wrote: On Thu, 29 Nov 2007, Mark Lord wrote: But the flogging continues

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Mark Lord wrote: So again, the problem is in the higher up scsi layer, and that is where the problem should already be fixed. .. Ahhh.. so you figure the Oops should also have been fixed as part of the 2.6.24 SCSI fixes ? That's what I was missing here. Yes indeed.

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Mark Lord
Alan Stern wrote: On Thu, 29 Nov 2007, Mark Lord wrote: So again, the problem is in the higher up scsi layer, and that is where the problem should already be fixed. .. Ahhh.. so you figure the Oops should also have been fixed as part of the 2.6.24 SCSI fixes ? That's what I was missing

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Greg KH
On Thu, Nov 29, 2007 at 05:07:58PM -0500, Alan Stern wrote: On Thu, 29 Nov 2007, Mark Lord wrote: So again, the problem is in the higher up scsi layer, and that is where the problem should already be fixed. .. Ahhh.. so you figure the Oops should also have been fixed as part of

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Mark Lord wrote: Alan Stern wrote: On Thu, 29 Nov 2007, Mark Lord wrote: So again, the problem is in the higher up scsi layer, and that is where the problem should already be fixed. .. Ahhh.. so you figure the Oops should also have been fixed as part of the

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Linus Torvalds
On Thu, 29 Nov 2007, Alan Stern wrote: Yes indeed. I wish I could point you to the exact patch containing the fix, but the git software seems to have lost track of it (it's combined in with a large number of other patches with no obvious way to separate it out). It's also available in

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Linus Torvalds wrote: Heh. It definitely hasn't gotten lost by the git software. No, it sure hasn't. In fact it was staring me right in the face and I didn't realize it. In fact, with the kinds of hints you already gave, git makes it really _trivial_ to find it.

Re: [PATCH] base/class.c: prevent ooops due to insert/remove race

2007-11-28 Thread Greg KH
On Wed, Nov 28, 2007 at 11:00:36PM -0500, Mark Lord wrote: > While doing insert/remove (quickly) tests on USB, I managed to trigger > an Oops on 2.6.23.1 on the call to strlen() in make_class_name(). > > This patch prevents this oops. > > There is still the larger problem of the overall race >

[PATCH] base/class.c: prevent ooops due to insert/remove race

2007-11-28 Thread Mark Lord
While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.1 on the call to strlen() in make_class_name(). This patch prevents this oops. There is still the larger problem of the overall race that caused this in the first place, but much of the rest of the code in

[PATCH] base/class.c: prevent ooops due to insert/remove race

2007-11-28 Thread Mark Lord
While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.1 on the call to strlen() in make_class_name(). This patch prevents this oops. There is still the larger problem of the overall race that caused this in the first place, but much of the rest of the code in

Re: [PATCH] base/class.c: prevent ooops due to insert/remove race

2007-11-28 Thread Greg KH
On Wed, Nov 28, 2007 at 11:00:36PM -0500, Mark Lord wrote: While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.1 on the call to strlen() in make_class_name(). This patch prevents this oops. There is still the larger problem of the overall race that