Re: [PATCH] binder: use lockless list for deferred_work

2018-01-22 Thread Todd Kjos
Vitaly, can you say more about the behavior you observed that led you to make this change? It is not obvious what workload would cause the contention on this mutex to make a difference (at least in an Android environment). On Mon, Jan 22, 2018 at 7:44 AM, Greg Kroah-Hartman

Re: [PATCH] binder: use lockless list for deferred_work

2018-01-22 Thread Todd Kjos
Vitaly, can you say more about the behavior you observed that led you to make this change? It is not obvious what workload would cause the contention on this mutex to make a difference (at least in an Android environment). On Mon, Jan 22, 2018 at 7:44 AM, Greg Kroah-Hartman wrote: > On Mon, Jan

Re: [PATCH] binder: use lockless list for deferred_work

2018-01-22 Thread Greg Kroah-Hartman
On Mon, Jan 08, 2018 at 02:55:18PM +0100, Vitaly Wool wrote: > Binder uses hlist for deferred list, which isn't a good match. > It's slow and requires mutual exclusion mechanism to protect its > operations. Moreover, having schedule_work() called under a mutex > may cause significant delays and

Re: [PATCH] binder: use lockless list for deferred_work

2018-01-22 Thread Greg Kroah-Hartman
On Mon, Jan 08, 2018 at 02:55:18PM +0100, Vitaly Wool wrote: > Binder uses hlist for deferred list, which isn't a good match. > It's slow and requires mutual exclusion mechanism to protect its > operations. Moreover, having schedule_work() called under a mutex > may cause significant delays and

[PATCH] binder: use lockless list for deferred_work

2018-01-08 Thread Vitaly Wool
Binder uses hlist for deferred list, which isn't a good match. It's slow and requires mutual exclusion mechanism to protect its operations. Moreover, having schedule_work() called under a mutex may cause significant delays and creates noticeable adverse effect on Binder performance. Deferred list

[PATCH] binder: use lockless list for deferred_work

2018-01-08 Thread Vitaly Wool
Binder uses hlist for deferred list, which isn't a good match. It's slow and requires mutual exclusion mechanism to protect its operations. Moreover, having schedule_work() called under a mutex may cause significant delays and creates noticeable adverse effect on Binder performance. Deferred list