Re: [PATCH] blk-cgroup: explicitly init the early_init field

2014-04-22 Thread Jens Axboe
On 04/22/2014 08:18 AM, Jianyu Zhan wrote: > On Tue, Apr 22, 2014 at 10:16 PM, Jens Axboe wrote: >> The rest of the members will be zero-filled by default, so your patch should >> not change anything. > > Hi, Jens > > I'm sorry I should have made this more clear. > > Sure, for this global

Re: [PATCH] blk-cgroup: explicitly init the early_init field

2014-04-22 Thread Jianyu Zhan
On Tue, Apr 22, 2014 at 10:16 PM, Jens Axboe wrote: > The rest of the members will be zero-filled by default, so your patch should > not change anything. Hi, Jens I'm sorry I should have made this more clear. Sure, for this global variable struct, if not initailized, its all fields will be

Re: [PATCH] blk-cgroup: explicitly init the early_init field

2014-04-22 Thread Jens Axboe
On 2014-04-21 23:26, Jianyu Zhan wrote: For a cgroup subsystem who should init early, then it should carefully take care of the implementation of css_alloc, because it will be called before mm_init() setup the world. Luckily we don't, and we better explicitly assign the early_init field to 0,

Re: [PATCH] blk-cgroup: explicitly init the early_init field

2014-04-22 Thread Jens Axboe
On 2014-04-21 23:26, Jianyu Zhan wrote: For a cgroup subsystem who should init early, then it should carefully take care of the implementation of css_alloc, because it will be called before mm_init() setup the world. Luckily we don't, and we better explicitly assign the early_init field to 0,

Re: [PATCH] blk-cgroup: explicitly init the early_init field

2014-04-22 Thread Jianyu Zhan
On Tue, Apr 22, 2014 at 10:16 PM, Jens Axboe ax...@kernel.dk wrote: The rest of the members will be zero-filled by default, so your patch should not change anything. Hi, Jens I'm sorry I should have made this more clear. Sure, for this global variable struct, if not initailized, its all

Re: [PATCH] blk-cgroup: explicitly init the early_init field

2014-04-22 Thread Jens Axboe
On 04/22/2014 08:18 AM, Jianyu Zhan wrote: On Tue, Apr 22, 2014 at 10:16 PM, Jens Axboe ax...@kernel.dk wrote: The rest of the members will be zero-filled by default, so your patch should not change anything. Hi, Jens I'm sorry I should have made this more clear. Sure, for this global

[PATCH] blk-cgroup: explicitly init the early_init field

2014-04-21 Thread Jianyu Zhan
For a cgroup subsystem who should init early, then it should carefully take care of the implementation of css_alloc, because it will be called before mm_init() setup the world. Luckily we don't, and we better explicitly assign the early_init field to 0, for document reason. Signed-off-by: Jianyu

[PATCH] blk-cgroup: explicitly init the early_init field

2014-04-21 Thread Jianyu Zhan
For a cgroup subsystem who should init early, then it should carefully take care of the implementation of css_alloc, because it will be called before mm_init() setup the world. Luckily we don't, and we better explicitly assign the early_init field to 0, for document reason. Signed-off-by: Jianyu