Re: [PATCH] blkcg: stop iteration early if root_rl is the only request list

2012-10-22 Thread Jens Axboe
On 2012-10-22 03:15, Jun'ichi Nomura wrote: > __blk_queue_next_rl() finds next request list based on blkg_list > while skipping root_blkg in the list. > OTOH, root_rl is special as it may exist even without root_blkg. > > Though the later part of the function handles such a case correctly, >

Re: [PATCH] blkcg: stop iteration early if root_rl is the only request list

2012-10-22 Thread Vivek Goyal
On Mon, Oct 22, 2012 at 10:15:37AM +0900, Jun'ichi Nomura wrote: > __blk_queue_next_rl() finds next request list based on blkg_list > while skipping root_blkg in the list. > OTOH, root_rl is special as it may exist even without root_blkg. > > Though the later part of the function handles such a

Re: [PATCH] blkcg: stop iteration early if root_rl is the only request list

2012-10-22 Thread Vivek Goyal
On Mon, Oct 22, 2012 at 10:15:37AM +0900, Jun'ichi Nomura wrote: __blk_queue_next_rl() finds next request list based on blkg_list while skipping root_blkg in the list. OTOH, root_rl is special as it may exist even without root_blkg. Though the later part of the function handles such a case

Re: [PATCH] blkcg: stop iteration early if root_rl is the only request list

2012-10-22 Thread Jens Axboe
On 2012-10-22 03:15, Jun'ichi Nomura wrote: __blk_queue_next_rl() finds next request list based on blkg_list while skipping root_blkg in the list. OTOH, root_rl is special as it may exist even without root_blkg. Though the later part of the function handles such a case correctly, exiting

[PATCH] blkcg: stop iteration early if root_rl is the only request list

2012-10-21 Thread Jun'ichi Nomura
__blk_queue_next_rl() finds next request list based on blkg_list while skipping root_blkg in the list. OTOH, root_rl is special as it may exist even without root_blkg. Though the later part of the function handles such a case correctly, exiting early is good for readability of the code.

[PATCH] blkcg: stop iteration early if root_rl is the only request list

2012-10-21 Thread Jun'ichi Nomura
__blk_queue_next_rl() finds next request list based on blkg_list while skipping root_blkg in the list. OTOH, root_rl is special as it may exist even without root_blkg. Though the later part of the function handles such a case correctly, exiting early is good for readability of the code.