Re: [PATCH] block: Employ u64_stats_init()

2013-11-13 Thread Ingo Molnar
* Jens Axboe wrote: > On 11/13/2013 10:35 AM, Ingo Molnar wrote: > > > > * Jens Axboe wrote: > > > >> On 11/12/2013 08:42 PM, John Stultz wrote: > >>> From: Peter Zijlstra > >>> > >>> Now that seqcounts are lockdep enabled objects, we need to properly > >>> initialize them. > >>> > >>> Witho

Re: [PATCH] block: Employ u64_stats_init()

2013-11-13 Thread Jens Axboe
On 11/13/2013 10:35 AM, Ingo Molnar wrote: > > * Jens Axboe wrote: > >> On 11/12/2013 08:42 PM, John Stultz wrote: >>> From: Peter Zijlstra >>> >>> Now that seqcounts are lockdep enabled objects, we need to properly >>> initialize them. >>> >>> Without this patch, Fengguang was seeing: >>> [

Re: [PATCH] block: Employ u64_stats_init()

2013-11-13 Thread Ingo Molnar
* Jens Axboe wrote: > On 11/12/2013 08:42 PM, John Stultz wrote: > > From: Peter Zijlstra > > > > Now that seqcounts are lockdep enabled objects, we need to properly > > initialize them. > > > > Without this patch, Fengguang was seeing: > > [4.127282] INFO: trying to register non-static k

Re: [PATCH] block: Employ u64_stats_init()

2013-11-13 Thread Jens Axboe
On 11/12/2013 08:42 PM, John Stultz wrote: > From: Peter Zijlstra > > Now that seqcounts are lockdep enabled objects, we need to properly > initialize them. > > Without this patch, Fengguang was seeing: > [4.127282] INFO: trying to register non-static key. > [4.128027] the code is fine b

Re: [PATCH] block: Employ u64_stats_init()

2013-11-13 Thread Vivek Goyal
On Tue, Nov 12, 2013 at 07:42:14PM -0800, John Stultz wrote: > From: Peter Zijlstra > > Now that seqcounts are lockdep enabled objects, we need to properly > initialize them. > > Without this patch, Fengguang was seeing: > [4.127282] INFO: trying to register non-static key. > [4.128027]

Re: [PATCH] block: Employ u64_stats_init()

2013-11-13 Thread Fengguang Wu
On Tue, Nov 12, 2013 at 07:42:14PM -0800, John Stultz wrote: > From: Peter Zijlstra > > Now that seqcounts are lockdep enabled objects, we need to properly > initialize them. It works! Tested-by: Fengguang Wu /kernel/i386-randconfig-j7-11082318/cb460d7163af828b404eeb6e06cb236895e7edd6 +-

[PATCH] block: Employ u64_stats_init()

2013-11-12 Thread John Stultz
From: Peter Zijlstra Now that seqcounts are lockdep enabled objects, we need to properly initialize them. Without this patch, Fengguang was seeing: [4.127282] INFO: trying to register non-static key. [4.128027] the code is fine but needs lockdep annotation. [4.128027] turning off the