Re: [PATCH] block: Fix possible sleep in invalid context

2013-07-01 Thread Sujit Reddy Thumma
On 7/2/2013 8:34 AM, Aaron Lu wrote: Fix this by releasing spin_lock_irq() before calling >pm_runtime_autosuspend() in blk_post_runtime_resume(). Hi Sujit, Thanks for testing out block layer runtime PM! As for the problem here, it is already fixed by: commit c60855cdb976c632b3bf8922eeab8a0e78

Re: [PATCH] block: Fix possible sleep in invalid context

2013-07-01 Thread Aaron Lu
On 07/01/2013 11:28 PM, Sujit Reddy Thumma wrote: > When block runtime PM is enabled following warning is seen > while resuming the device. > > BUG: sleeping function called from invalid context at > .../drivers/base/power/runtime.c:923 > in_atomic(): 1, irqs_disabled(): 128, pid: 12, name: kworke

Re: [PATCH] block: Fix possible sleep in invalid context

2013-07-01 Thread Andrew Morton
On Mon, 01 Jul 2013 15:24:11 -0700 James Bottomley wrote: > > --- a/block/blk-core.c~block-fix-possible-sleep-in-invalid-context-fix > > +++ a/block/blk-core.c > > @@ -3159,15 +3159,14 @@ EXPORT_SYMBOL(blk_pre_runtime_resume); > > */ > > void blk_post_runtime_resume(struct request_queue *q, i

Re: [PATCH] block: Fix possible sleep in invalid context

2013-07-01 Thread James Bottomley
On Mon, 2013-07-01 at 15:17 -0700, Andrew Morton wrote: > On Mon, 1 Jul 2013 20:58:35 +0530 Sujit Reddy Thumma > wrote: > > > When block runtime PM is enabled following warning is seen > > while resuming the device. > > > > BUG: sleeping function called from invalid context at > > .../drivers/

Re: [PATCH] block: Fix possible sleep in invalid context

2013-07-01 Thread Andrew Morton
On Mon, 1 Jul 2013 20:58:35 +0530 Sujit Reddy Thumma wrote: > When block runtime PM is enabled following warning is seen > while resuming the device. > > BUG: sleeping function called from invalid context at > .../drivers/base/power/runtime.c:923 > in_atomic(): 1, irqs_disabled(): 128, pid: 12

[PATCH] block: Fix possible sleep in invalid context

2013-07-01 Thread Sujit Reddy Thumma
When block runtime PM is enabled following warning is seen while resuming the device. BUG: sleeping function called from invalid context at .../drivers/base/power/runtime.c:923 in_atomic(): 1, irqs_disabled(): 128, pid: 12, name: kworker/0:1 [] (unwind_backtrace+0x0/0x120) from [] (__pm_runtime_su