Re: [PATCH] block: Remove judgement for rq_mergeable(rq) in func elv_rqhash_find.

2013-01-06 Thread Jens Axboe
On 2013-01-07 06:08, majianpeng wrote: > Because only mergeable rq can add rqhash.So it does not make sense to > judge rq_mergeable(rq) in func elv_rqhash_find. It does make sense. A request is always mergeable when it enters the hash, but it may not remain mergeable. This can happen if we merge

[PATCH] block: Remove judgement for rq_mergeable(rq) in func elv_rqhash_find.

2013-01-06 Thread majianpeng
Because only mergeable rq can add rqhash.So it does not make sense to judge rq_mergeable(rq) in func elv_rqhash_find. Signed-off-by: Jianpeng Ma --- block/elevator.c |5 - 1 file changed, 5 deletions(-) diff --git a/block/elevator.c b/block/elevator.c index 9edba1b..d5901a4 100644 ---

[PATCH] block: Remove judgement for rq_mergeable(rq) in func elv_rqhash_find.

2013-01-06 Thread majianpeng
Because only mergeable rq can add rqhash.So it does not make sense to judge rq_mergeable(rq) in func elv_rqhash_find. Signed-off-by: Jianpeng Ma --- block/elevator.c |5 - 1 file changed, 5 deletions(-) diff --git a/block/elevator.c b/block/elevator.c index 9edba1b..d5901a4 100644 ---

[PATCH] block: Remove judgement for rq_mergeable(rq) in func elv_rqhash_find.

2013-01-06 Thread majianpeng
Because only mergeable rq can add rqhash.So it does not make sense to judge rq_mergeable(rq) in func elv_rqhash_find. Signed-off-by: Jianpeng Ma majianp...@gmail.com --- block/elevator.c |5 - 1 file changed, 5 deletions(-) diff --git a/block/elevator.c b/block/elevator.c index

[PATCH] block: Remove judgement for rq_mergeable(rq) in func elv_rqhash_find.

2013-01-06 Thread majianpeng
Because only mergeable rq can add rqhash.So it does not make sense to judge rq_mergeable(rq) in func elv_rqhash_find. Signed-off-by: Jianpeng Ma majianp...@gmail.com --- block/elevator.c |5 - 1 file changed, 5 deletions(-) diff --git a/block/elevator.c b/block/elevator.c index

Re: [PATCH] block: Remove judgement for rq_mergeable(rq) in func elv_rqhash_find.

2013-01-06 Thread Jens Axboe
On 2013-01-07 06:08, majianpeng wrote: Because only mergeable rq can add rqhash.So it does not make sense to judge rq_mergeable(rq) in func elv_rqhash_find. It does make sense. A request is always mergeable when it enters the hash, but it may not remain mergeable. This can happen if we merge it