Re: [PATCH] block: turn Oops into WARNING if bdi_register_dev fails.

2015-04-27 Thread Christoph Hellwig
On Mon, Apr 27, 2015 at 03:19:31PM +1000, NeilBrown wrote: > > add_disk() does not return an error status, but it can > still fail if there are problems elsewhere. > > In particular a recent problem caused bdi_register_dev() > to sometimes fail because the name was already in use. I guess

Re: [PATCH] block: turn Oops into WARNING if bdi_register_dev fails.

2015-04-27 Thread Christoph Hellwig
On Mon, Apr 27, 2015 at 03:19:31PM +1000, NeilBrown wrote: add_disk() does not return an error status, but it can still fail if there are problems elsewhere. In particular a recent problem caused bdi_register_dev() to sometimes fail because the name was already in use. I guess that's the

[PATCH] block: turn Oops into WARNING if bdi_register_dev fails.

2015-04-26 Thread NeilBrown
add_disk() does not return an error status, but it can still fail if there are problems elsewhere. In particular a recent problem caused bdi_register_dev() to sometimes fail because the name was already in use. In that case bdi->dev is NULL, so retval =

[PATCH] block: turn Oops into WARNING if bdi_register_dev fails.

2015-04-26 Thread NeilBrown
add_disk() does not return an error status, but it can still fail if there are problems elsewhere. In particular a recent problem caused bdi_register_dev() to sometimes fail because the name was already in use. In that case bdi-dev is NULL, so retval =