On Wednesday 21 January 2015 12:01:31 Pavel Machek wrote:
> > > Strange, where do you see DOS style line breaks?
> > > Checkpatch here does not warn about that, and they really
> > > should not be there.
> >
> > If that would be the only pieces, then I would have fixed it
> > already. That is not
Hi!
> > Speaking about formatting, could you properly format your emails, that
> > is inserting newline after ~78 columns, to make them easier to reply
> > to?
>
> or you get an email client that can handle that part.
My email client is configured ok. Your is not. You are speaking on
public
On Wednesday 21 January 2015 12:01:31 Pavel Machek wrote:
Strange, where do you see DOS style line breaks?
Checkpatch here does not warn about that, and they really
should not be there.
If that would be the only pieces, then I would have fixed it
already. That is not the big deal.
Hi!
Speaking about formatting, could you properly format your emails, that
is inserting newline after ~78 columns, to make them easier to reply
to?
or you get an email client that can handle that part.
My email client is configured ok. Your is not. You are speaking on
public mailing
On Tue 2015-01-20 10:28:50, Johan Hedberg wrote:
> Hi Pavel,
>
> On Tue, Dec 23, 2014, Pavel Machek wrote:
> > + while (1) {
> > + int cmd, len;
> > +
> > + fw_pos += cmd_len;
> > +
> > + if (fw_pos >= fw_entry->size)
> > + break;
> > +
> > +
Hi Pavel,
>>> Add HCI driver for H4 with Nokia extensions. This device is used on
>>> Nokia N900 cell phone.
>>>
>>> Older version of this driver lived in staging, before being reverted
>>> in a4102f90e87cfaa3fdbed6fdf469b23f0eeb4bfd .
>>>
>>> Signed-off-by: Pavel Machek
>>> Thanks-to:
Hi!
> > Add HCI driver for H4 with Nokia extensions. This device is used on
> > Nokia N900 cell phone.
> >
> > Older version of this driver lived in staging, before being reverted
> > in a4102f90e87cfaa3fdbed6fdf469b23f0eeb4bfd .
> >
> > Signed-off-by: Pavel Machek
> > Thanks-to: Sebastian
Hi Pavel,
On Tue, Dec 23, 2014, Pavel Machek wrote:
> + while (1) {
> + int cmd, len;
> +
> + fw_pos += cmd_len;
> +
> + if (fw_pos >= fw_entry->size)
> + break;
> +
> + if (fw_pos + 2 > fw_entry->size) {
> +
Hi Pavel,
On Tue, Dec 23, 2014, Pavel Machek wrote:
+ while (1) {
+ int cmd, len;
+
+ fw_pos += cmd_len;
+
+ if (fw_pos = fw_entry-size)
+ break;
+
+ if (fw_pos + 2 fw_entry-size) {
+
Hi Pavel,
Add HCI driver for H4 with Nokia extensions. This device is used on
Nokia N900 cell phone.
Older version of this driver lived in staging, before being reverted
in a4102f90e87cfaa3fdbed6fdf469b23f0eeb4bfd .
Signed-off-by: Pavel Machek pa...@ucw.cz
Thanks-to: Sebastian Reichel
Hi!
Add HCI driver for H4 with Nokia extensions. This device is used on
Nokia N900 cell phone.
Older version of this driver lived in staging, before being reverted
in a4102f90e87cfaa3fdbed6fdf469b23f0eeb4bfd .
Signed-off-by: Pavel Machek pa...@ucw.cz
Thanks-to: Sebastian Reichel
On Tue 2015-01-20 10:28:50, Johan Hedberg wrote:
Hi Pavel,
On Tue, Dec 23, 2014, Pavel Machek wrote:
+ while (1) {
+ int cmd, len;
+
+ fw_pos += cmd_len;
+
+ if (fw_pos = fw_entry-size)
+ break;
+
+ if (fw_pos + 2
Hi Pavel,
> Add HCI driver for H4 with Nokia extensions. This device is used on
> Nokia N900 cell phone.
>
> Older version of this driver lived in staging, before being reverted
> in a4102f90e87cfaa3fdbed6fdf469b23f0eeb4bfd .
>
> Signed-off-by: Pavel Machek
> Thanks-to: Sebastian Reichel
>
Hi Pavel,
Add HCI driver for H4 with Nokia extensions. This device is used on
Nokia N900 cell phone.
Older version of this driver lived in staging, before being reverted
in a4102f90e87cfaa3fdbed6fdf469b23f0eeb4bfd .
Signed-off-by: Pavel Machek pa...@ucw.cz
Thanks-to: Sebastian Reichel
Hi!
> Add HCI driver for H4 with Nokia extensions. This device is used on
> Nokia N900 cell phone.
>
> Older version of this driver lived in staging, before being reverted
> in a4102f90e87cfaa3fdbed6fdf469b23f0eeb4bfd .
Any news here? I'd like the driver to hit 3.20...
Hi!
Add HCI driver for H4 with Nokia extensions. This device is used on
Nokia N900 cell phone.
Older version of this driver lived in staging, before being reverted
in a4102f90e87cfaa3fdbed6fdf469b23f0eeb4bfd .
Any news here? I'd like the driver to hit 3.20...
Add HCI driver for H4 with Nokia extensions. This device is used on
Nokia N900 cell phone.
Older version of this driver lived in staging, before being reverted
in a4102f90e87cfaa3fdbed6fdf469b23f0eeb4bfd .
Signed-off-by: Pavel Machek
Thanks-to: Sebastian Reichel
Thanks-to: Joe Perches
---
Hi!
> > Add hci_h4p bluetooth driver. This device is used for example on Nokia N900
> > cell phone.
>
> the driver is called nokia_h4p. And you could be a little bit more verbose
> here explaining where the driver came from.
> > Signed-off-by: Pavel Machek
> > Thanks-to: Sebastian Reichel
Hi!
> > + /* We should always send word aligned data to h4+ devices */
> > + if (skb->len % 2) {
> > + err = skb_pad(skb, 1);
> > + if (!err)
> > + *skb_put(skb, 1) = 0x00;
> > + }
> > + if (err)
> > + return err;
>
> This is crazy code.
>
Hi!
+ /* We should always send word aligned data to h4+ devices */
+ if (skb-len % 2) {
+ err = skb_pad(skb, 1);
+ if (!err)
+ *skb_put(skb, 1) = 0x00;
+ }
+ if (err)
+ return err;
This is crazy code.
if (skb-len
Hi!
Add hci_h4p bluetooth driver. This device is used for example on Nokia N900
cell phone.
the driver is called nokia_h4p. And you could be a little bit more verbose
here explaining where the driver came from.
Signed-off-by: Pavel Machek pa...@ucw.cz
Thanks-to: Sebastian Reichel
Add HCI driver for H4 with Nokia extensions. This device is used on
Nokia N900 cell phone.
Older version of this driver lived in staging, before being reverted
in a4102f90e87cfaa3fdbed6fdf469b23f0eeb4bfd .
Signed-off-by: Pavel Machek pa...@ucw.cz
Thanks-to: Sebastian Reichel s...@debian.org
Hi Pavel,
> Add hci_h4p bluetooth driver. This device is used for example on Nokia N900
> cell phone.
the driver is called nokia_h4p. And you could be a little bit more verbose here
explaining where the driver came from.
>
> Signed-off-by: Pavel Machek
> Thanks-to: Sebastian Reichel
>
Pavel,
On Sat, 2014-12-20 at 21:23 +0100, Pavel Machek wrote:
> --- a/drivers/bluetooth/Kconfig
> +++ b/drivers/bluetooth/Kconfig
> @@ -243,4 +243,13 @@ config BT_WILINK
> Say Y here to compile support for Texas Instrument's WiLink7 driver
> into the kernel or say M to compile it
Add hci_h4p bluetooth driver. This device is used for example on Nokia N900
cell phone.
Signed-off-by: Pavel Machek
Thanks-to: Sebastian Reichel
Thanks-to: Joe Perches
---
Please apply,
Pavel
diff --git a/drivers/bluetooth/Kconfig
Add hci_h4p bluetooth driver. This device is used for example on Nokia N900
cell phone.
Signed-off-by: Pavel Machek pa...@ucw.cz
Thanks-to: Sebastian Reichel s...@debian.org
Thanks-to: Joe Perches j...@perches.com
---
Please apply,
Pavel,
On Sat, 2014-12-20 at 21:23 +0100, Pavel Machek wrote:
--- a/drivers/bluetooth/Kconfig
+++ b/drivers/bluetooth/Kconfig
@@ -243,4 +243,13 @@ config BT_WILINK
Say Y here to compile support for Texas Instrument's WiLink7 driver
into the kernel or say M to compile it as
Hi Pavel,
Add hci_h4p bluetooth driver. This device is used for example on Nokia N900
cell phone.
the driver is called nokia_h4p. And you could be a little bit more verbose here
explaining where the driver came from.
Signed-off-by: Pavel Machek pa...@ucw.cz
Thanks-to: Sebastian Reichel
On Thursday 24 October 2013 20:41:53 Joe Perches wrote:
> On Fri, 2013-10-18 at 12:30 +0200, Pali Rohár wrote:
> > I rebased patch on top of
> > https://git.kernel.org/cgit/linux/kernel/git/bluetooth/blue
> > tooth-next.git branch master
>
> Hi Pali, just some trivial notes:
>
> []
>
> +static
On Thursday 24 October 2013 20:41:53 Joe Perches wrote:
On Fri, 2013-10-18 at 12:30 +0200, Pali Rohár wrote:
I rebased patch on top of
https://git.kernel.org/cgit/linux/kernel/git/bluetooth/blue
tooth-next.git branch master
Hi Pali, just some trivial notes:
[]
+static ssize_t
On Fri, 2013-10-18 at 12:30 +0200, Pali Rohár wrote:
> I rebased patch on top of
> https://git.kernel.org/cgit/linux/kernel/git/bluetooth/bluetooth-next.git
> branch master
Hi Pali, just some trivial notes:
[]
+static ssize_t hci_h4p_show_bdaddr(struct device *dev,
> +
On Friday 18 October 2013 12:30:44 Pali Rohár wrote:
> On Friday 18 October 2013 00:11:44 Marcel Holtmann wrote:
> > Hi Pali,
> >
> >
> >
> > >
> > >
> > > Can somebody look & comment this patch? What is needed to
> > > be part of upstream kernel?
> >
> >
> >
> > you need to rebase against
On Friday 18 October 2013 12:30:44 Pali Rohár wrote:
On Friday 18 October 2013 00:11:44 Marcel Holtmann wrote:
Hi Pali,
Can somebody look comment this patch? What is needed to
be part of upstream kernel?
you need to rebase against bluetooth-next at least.
On Fri, 2013-10-18 at 12:30 +0200, Pali Rohár wrote:
I rebased patch on top of
https://git.kernel.org/cgit/linux/kernel/git/bluetooth/bluetooth-next.git
branch master
Hi Pali, just some trivial notes:
[]
+static ssize_t hci_h4p_show_bdaddr(struct device *dev,
+
Hi Pali,
>> This driver adding support for Nokia N900 bluetooth hardware
>>
>> Signed-off-by: Ville Tervo
>> Signed-off-by: Pali Rohár
>> ---
>> drivers/bluetooth/Kconfig | 10 +
>> drivers/bluetooth/Makefile|2 +
>> drivers/bluetooth/hci_h4p/Makefile|7 +
>>
On Friday 20 September 2013 21:01:50 Pali Rohár wrote:
> From: Ville Tervo
>
> This driver adding support for Nokia N900 bluetooth hardware
>
> Signed-off-by: Ville Tervo
> Signed-off-by: Pali Rohár
> ---
> drivers/bluetooth/Kconfig | 10 +
> drivers/bluetooth/Makefile
On Friday 20 September 2013 21:01:50 Pali Rohár wrote:
From: Ville Tervo ville.te...@nokia.com
This driver adding support for Nokia N900 bluetooth hardware
Signed-off-by: Ville Tervo ville.te...@nokia.com
Signed-off-by: Pali Rohár pali.ro...@gmail.com
---
drivers/bluetooth/Kconfig
Hi Pali,
This driver adding support for Nokia N900 bluetooth hardware
Signed-off-by: Ville Tervo ville.te...@nokia.com
Signed-off-by: Pali Rohár pali.ro...@gmail.com
---
drivers/bluetooth/Kconfig | 10 +
drivers/bluetooth/Makefile|2 +
38 matches
Mail list logo
