Re: [PATCH] bootconfig: Fix off-by-one in xbc_node_compose_key_after()

2020-08-15 Thread Masami Hiramatsu
On Thu, 13 Aug 2020 23:04:06 -0400 Steven Rostedt wrote: > On Thu, 13 Aug 2020 19:38:18 -0700 > Andrew Morton wrote: > > > On Thu, 13 Aug 2020 18:30:50 -0400 Steven Rostedt > > wrote: > > > > > From: Steven Rostedt (VMware) > > > > > > While reviewing some patches for bootconfig, I

Re: [PATCH] bootconfig: Fix off-by-one in xbc_node_compose_key_after()

2020-08-13 Thread Steven Rostedt
On Thu, 13 Aug 2020 19:38:18 -0700 Andrew Morton wrote: > On Thu, 13 Aug 2020 18:30:50 -0400 Steven Rostedt wrote: > > > From: Steven Rostedt (VMware) > > > > While reviewing some patches for bootconfig, I noticed the following > > code in xbc_node_compose_key_after(): > > > > ret =

Re: [PATCH] bootconfig: Fix off-by-one in xbc_node_compose_key_after()

2020-08-13 Thread Andrew Morton
On Thu, 13 Aug 2020 18:30:50 -0400 Steven Rostedt wrote: > From: Steven Rostedt (VMware) > > While reviewing some patches for bootconfig, I noticed the following > code in xbc_node_compose_key_after(): > > ret = snprintf(buf, size, "%s%s", xbc_node_get_data(node), >

[PATCH] bootconfig: Fix off-by-one in xbc_node_compose_key_after()

2020-08-13 Thread Steven Rostedt
From: Steven Rostedt (VMware) While reviewing some patches for bootconfig, I noticed the following code in xbc_node_compose_key_after(): ret = snprintf(buf, size, "%s%s", xbc_node_get_data(node), depth ? "." : ""); if (ret < 0) return ret;