Re: [PATCH] bpf, arm32: Correct check_imm24

2018-05-10 Thread Wang YanQing
On Thu, May 10, 2018 at 08:56:57AM +0100, Russell King - ARM Linux wrote: > On Thu, May 10, 2018 at 11:20:13AM +0800, Wang YanQing wrote: > > imm24 is signed, so the right range is: > > [-(2<<(24 - 1)), (2<<(24 - 1)) - 1] > > 2 << (24 - 1) is the same as 1 << 24. > > > -#define check_imm(bits, im

Re: [PATCH] bpf, arm32: Correct check_imm24

2018-05-10 Thread Russell King - ARM Linux
On Thu, May 10, 2018 at 11:20:13AM +0800, Wang YanQing wrote: > imm24 is signed, so the right range is: > [-(2<<(24 - 1)), (2<<(24 - 1)) - 1] 2 << (24 - 1) is the same as 1 << 24. > -#define check_imm(bits, imm) do {\ > - if imm) > 0) && ((imm) >> (bits))) ||

[PATCH] bpf, arm32: Correct check_imm24

2018-05-09 Thread Wang YanQing
imm24 is signed, so the right range is: [-(2<<(24 - 1)), (2<<(24 - 1)) - 1] Note:this patch also fix a typo. Signed-off-by: Wang YanQing --- arch/arm/net/bpf_jit_32.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_j