Re: [PATCH] bridge: multicast: add sanity check for query source addresses

2014-03-05 Thread David Miller
From: Linus Lüssing Date: Tue, 4 Mar 2014 03:57:35 +0100 > MLD queries are supposed to have an IPv6 link-local source address > according to RFC2710, section 4 and RFC3810, section 5.1.14. This patch > adds a sanity check to ignore such broken MLD queries. > > Without this check, such malformed

Re: [PATCH] bridge: multicast: add sanity check for query source addresses

2014-03-04 Thread Hannes Frederic Sowa
On Tue, Mar 04, 2014 at 11:43:55AM +0100, Linus Lüssing wrote: > On Tue, Mar 04, 2014 at 10:06:14AM +0100, Hannes Frederic Sowa wrote: > > > diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c > > > index ef66365..fb0e36f 100644 > > > --- a/net/bridge/br_multicast.c > > > +++ b/net/b

Re: [PATCH] bridge: multicast: add sanity check for query source addresses

2014-03-04 Thread Linus Lüssing
On Tue, Mar 04, 2014 at 10:06:14AM +0100, Hannes Frederic Sowa wrote: > > diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c > > index ef66365..fb0e36f 100644 > > --- a/net/bridge/br_multicast.c > > +++ b/net/bridge/br_multicast.c > > @@ -1235,6 +1235,12 @@ static int br_ip6_multica

Re: [PATCH] bridge: multicast: add sanity check for query source addresses

2014-03-04 Thread Hannes Frederic Sowa
On Tue, Mar 04, 2014 at 03:57:35AM +0100, Linus Lüssing wrote: > MLD queries are supposed to have an IPv6 link-local source address > according to RFC2710, section 4 and RFC3810, section 5.1.14. This patch > adds a sanity check to ignore such broken MLD queries. > > Without this check, such malfor

[PATCH] bridge: multicast: add sanity check for query source addresses

2014-03-03 Thread Linus Lüssing
MLD queries are supposed to have an IPv6 link-local source address according to RFC2710, section 4 and RFC3810, section 5.1.14. This patch adds a sanity check to ignore such broken MLD queries. Without this check, such malformed MLD queries can result in a denial of service: The queries are ignore