Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

> But you are getting familiarized, you sent a patch, got feedback, defend > your patches.  That's a great start, but it does not mean that the > patches end up merged. The decision is up to the maintainer(s) of the > subsystem. > > Nobody will bite your head off if you do some trivial formal

Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

> But you are getting familiarized, you sent a patch, got feedback, defend > your patches.  That's a great start, but it does not mean that the > patches end up merged. The decision is up to the maintainer(s) of the > subsystem. > > Nobody will bite your head off if you do some trivial formal

Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

On Mon, Feb 22, 2016 at 06:10:56AM -0600, Simon Quigley wrote: > > in short, whitespace-only changes do not help too much. > > But they are encouraged for people who would like to get started with kernel > programming, Linus > himself says so. In the future I plan on giving more, but I wanted to

Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

On Mon, Feb 22, 2016 at 06:10:56AM -0600, Simon Quigley wrote: > > in short, whitespace-only changes do not help too much. > > But they are encouraged for people who would like to get started with kernel > programming, Linus > himself says so. In the future I plan on giving more, but I wanted to

Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

> in short, whitespace-only changes do not help too much. But they are encouraged for people who would like to get started with kernel programming, Linus himself says so. In the future I plan on giving more, but I wanted to get familiarized with the process. So I still think this should be

Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

> in short, whitespace-only changes do not help too much. But they are encouraged for people who would like to get started with kernel programming, Linus himself says so. In the future I plan on giving more, but I wanted to get familiarized with the process. So I still think this should be

Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

On Sat, Feb 20, 2016 at 12:17:38PM -0600, Simon Quigley wrote: > checkpatch.pl reported a warning of over 80 characters on line 1833 Please read the answers from Filipe or me http://article.gmane.org/gmane.comp.file-systems.btrfs/53421 http://article.gmane.org/gmane.comp.file-systems.btrfs/53422

Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

On Sat, Feb 20, 2016 at 12:17:38PM -0600, Simon Quigley wrote: > checkpatch.pl reported a warning of over 80 characters on line 1833 Please read the answers from Filipe or me http://article.gmane.org/gmane.comp.file-systems.btrfs/53421 http://article.gmane.org/gmane.comp.file-systems.btrfs/53422

Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

I apologize, I had my text editor set to a 4 space tab instead of 8 so I couldn't see this clearly. That's fixed now, and it won't happen again. Is this what you wanted? It seems to line up exactly like you proposed. On 02/20/2016 08:06 PM, Simon Quigley wrote: checkpatch.pl reported a

Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

I apologize, I had my text editor set to a 4 space tab instead of 8 so I couldn't see this clearly. That's fixed now, and it won't happen again. Is this what you wanted? It seems to line up exactly like you proposed. On 02/20/2016 08:06 PM, Simon Quigley wrote: checkpatch.pl reported a

[PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

checkpatch.pl reported a warning of over 80 characters on line 1833 Adjusted to put and on a different line Signed-off-by: Simon Quigley --- fs/btrfs/backref.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c

[PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

checkpatch.pl reported a warning of over 80 characters on line 1833 Adjusted to put and on a different line Signed-off-by: Simon Quigley --- fs/btrfs/backref.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c index

Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80

On Sat, 2016-02-20 at 18:57 -0600, Simon Quigley wrote: > Better? No, not really. The alignment should be to the open parenthesis as I wrote in the first reply. > On 02/20/2016 06:56 PM, Simon Quigley wrote: > > checkpatch.pl reported a warning of over 80 characters on line 1833 > > > >

Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80

On Sat, 2016-02-20 at 18:57 -0600, Simon Quigley wrote: > Better? No, not really. The alignment should be to the open parenthesis as I wrote in the first reply. > On 02/20/2016 06:56 PM, Simon Quigley wrote: > > checkpatch.pl reported a warning of over 80 characters on line 1833 > > > >

Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80

Better? On 02/20/2016 06:56 PM, Simon Quigley wrote: checkpatch.pl reported a warning of over 80 characters on line 1833 Adjusted to put and on a different line Signed-off-by: Simon Quigley --- fs/btrfs/backref.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH] btrfs: backref: Fixed checkpatch warning of over 80

checkpatch.pl reported a warning of over 80 characters on line 1833 Adjusted to put and on a different line Signed-off-by: Simon Quigley --- fs/btrfs/backref.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c

Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80

Better? On 02/20/2016 06:56 PM, Simon Quigley wrote: checkpatch.pl reported a warning of over 80 characters on line 1833 Adjusted to put and on a different line Signed-off-by: Simon Quigley --- fs/btrfs/backref.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] btrfs: backref: Fixed checkpatch warning of over 80

checkpatch.pl reported a warning of over 80 characters on line 1833 Adjusted to put and on a different line Signed-off-by: Simon Quigley --- fs/btrfs/backref.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c index

Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

On Sat, 2016-02-20 at 12:17 -0600, Simon Quigley wrote: > checkpatch.pl reported a warning of over 80 characters on line 1833 [] > diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c [] > @@ -1830,7 +1830,11 @@ static int iterate_inode_extrefs(u64 inum, struct > btrfs_root *fs_root, >  

Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

On Sat, 2016-02-20 at 12:17 -0600, Simon Quigley wrote: > checkpatch.pl reported a warning of over 80 characters on line 1833 [] > diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c [] > @@ -1830,7 +1830,11 @@ static int iterate_inode_extrefs(u64 inum, struct > btrfs_root *fs_root, >  

[PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

checkpatch.pl reported a warning of over 80 characters on line 1833 Fixed by splitting up into multiple lines, no build errors afterwards Signed-off-by: Simon Quigley --- fs/btrfs/backref.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

checkpatch.pl reported a warning of over 80 characters on line 1833 Fixed by splitting up into multiple lines, no build errors afterwards Signed-off-by: Simon Quigley --- fs/btrfs/backref.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/backref.c

[PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

checkpatch.pl reported a warning of over 80 characters on line 1833 Fixed by splitting up into multiple lines, no build errors afterwards --- fs/btrfs/backref.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c index f6dac40..d09

[PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

checkpatch.pl reported a warning of over 80 characters on line 1833 Fixed by splitting up into multiple lines, no build errors afterwards --- fs/btrfs/backref.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c index f6dac40..d09