Re: [PATCH] can: kvaser_usb: Don't free packets when tight on URBs

2015-01-03 Thread Ahmed S. Darwish
On Thu, Jan 01, 2015 at 01:59:13PM -0800, Stephen Hemminger wrote: > On Tue, 23 Dec 2014 17:46:54 +0200 > "Ahmed S. Darwish" wrote: > > > int ret = NETDEV_TX_OK; > > + bool kfree_skb_on_error = true; > > > > if (can_dropped_invalid_skb(netdev, skb)) > > return

Re: [PATCH] can: kvaser_usb: Don't free packets when tight on URBs

2015-01-03 Thread Ahmed S. Darwish
On Thu, Jan 01, 2015 at 01:59:13PM -0800, Stephen Hemminger wrote: On Tue, 23 Dec 2014 17:46:54 +0200 Ahmed S. Darwish darwish...@gmail.com wrote: int ret = NETDEV_TX_OK; + bool kfree_skb_on_error = true; if (can_dropped_invalid_skb(netdev, skb)) return

Re: [PATCH] can: kvaser_usb: Don't free packets when tight on URBs

2015-01-01 Thread Stephen Hemminger
On Tue, 23 Dec 2014 17:46:54 +0200 "Ahmed S. Darwish" wrote: > int ret = NETDEV_TX_OK; > + bool kfree_skb_on_error = true; > > if (can_dropped_invalid_skb(netdev, skb)) > return NETDEV_TX_OK; > @@ -1336,6 +1337,7 @@ static netdev_tx_t kvaser_usb_start_xmit(struct

Re: [PATCH] can: kvaser_usb: Don't free packets when tight on URBs

2015-01-01 Thread Stephen Hemminger
On Tue, 23 Dec 2014 17:46:54 +0200 Ahmed S. Darwish darwish...@gmail.com wrote: int ret = NETDEV_TX_OK; + bool kfree_skb_on_error = true; if (can_dropped_invalid_skb(netdev, skb)) return NETDEV_TX_OK; @@ -1336,6 +1337,7 @@ static netdev_tx_t

Re: [PATCH] can: kvaser_usb: Don't free packets when tight on URBs

2014-12-24 Thread Ahmed S. Darwish
Hi Olivier, On Wed, Dec 24, 2014 at 01:31:20PM +0100, Olivier Sobrie wrote: > Hello Ahmed, > > On Tue, Dec 23, 2014 at 05:46:54PM +0200, Ahmed S. Darwish wrote: > > From: Ahmed S. Darwish > > > > Flooding the Kvaser CAN to USB dongle with multiple reads and > > writes in high frequency caused

Re: [PATCH] can: kvaser_usb: Don't free packets when tight on URBs

2014-12-24 Thread Olivier Sobrie
Hello Ahmed, On Tue, Dec 23, 2014 at 05:46:54PM +0200, Ahmed S. Darwish wrote: > From: Ahmed S. Darwish > > Flooding the Kvaser CAN to USB dongle with multiple reads and > writes in high frequency caused seemingly-random panics in the > kernel. > > On further inspection, it seems the driver

Re: [PATCH] can: kvaser_usb: Don't free packets when tight on URBs

2014-12-24 Thread Olivier Sobrie
Hello Ahmed, On Tue, Dec 23, 2014 at 05:46:54PM +0200, Ahmed S. Darwish wrote: From: Ahmed S. Darwish ahmed.darw...@valeo.com Flooding the Kvaser CAN to USB dongle with multiple reads and writes in high frequency caused seemingly-random panics in the kernel. On further inspection, it seems

Re: [PATCH] can: kvaser_usb: Don't free packets when tight on URBs

2014-12-24 Thread Ahmed S. Darwish
Hi Olivier, On Wed, Dec 24, 2014 at 01:31:20PM +0100, Olivier Sobrie wrote: Hello Ahmed, On Tue, Dec 23, 2014 at 05:46:54PM +0200, Ahmed S. Darwish wrote: From: Ahmed S. Darwish ahmed.darw...@valeo.com Flooding the Kvaser CAN to USB dongle with multiple reads and writes in high

[PATCH] can: kvaser_usb: Don't free packets when tight on URBs

2014-12-23 Thread Ahmed S. Darwish
From: Ahmed S. Darwish Flooding the Kvaser CAN to USB dongle with multiple reads and writes in high frequency caused seemingly-random panics in the kernel. On further inspection, it seems the driver erroneously freed the to-be-transmitted packet upon getting tight on URBs and returning

[PATCH] can: kvaser_usb: Don't free packets when tight on URBs

2014-12-23 Thread Ahmed S. Darwish
From: Ahmed S. Darwish ahmed.darw...@valeo.com Flooding the Kvaser CAN to USB dongle with multiple reads and writes in high frequency caused seemingly-random panics in the kernel. On further inspection, it seems the driver erroneously freed the to-be-transmitted packet upon getting tight on URBs