Re: [PATCH] can: vxcan: Fix memleak in vxcan_newlink

2020-10-22 Thread Marc Kleine-Budde
On 10/22/20 7:34 PM, Oliver Hartkopp wrote: > @Marc: Can you please make sure that it doesn't get into upstream? Tnx! Ok, I've removed can: vxcan: Fix memleak in vxcan_newlink [Dinghao Liu] from my linux-can/testing. Marc -- Pengutronix e.K. | Marc Kleine-Budde

Re: [PATCH] can: vxcan: Fix memleak in vxcan_newlink

2020-10-22 Thread Oliver Hartkopp
On 22.10.20 18:14, Jakub Kicinski wrote: On Wed, 21 Oct 2020 13:20:16 +0200 Oliver Hartkopp wrote: On 21.10.20 07:21, Dinghao Liu wrote: When rtnl_configure_link() fails, peer needs to be freed just like when register_netdevice() fails. Signed-off-by: Dinghao Liu Acked-by: Oliver

Re: [PATCH] can: vxcan: Fix memleak in vxcan_newlink

2020-10-22 Thread Jakub Kicinski
On Wed, 21 Oct 2020 13:20:16 +0200 Oliver Hartkopp wrote: > On 21.10.20 07:21, Dinghao Liu wrote: > > When rtnl_configure_link() fails, peer needs to be > > freed just like when register_netdevice() fails. > > > > Signed-off-by: Dinghao Liu > > Acked-by: Oliver Hartkopp > > Btw. as the

Re: Re: [PATCH] can: vxcan: Fix memleak in vxcan_newlink

2020-10-21 Thread dinghao . liu
> > On 21.10.20 07:21, Dinghao Liu wrote: > > When rtnl_configure_link() fails, peer needs to be > > freed just like when register_netdevice() fails. > > > > Signed-off-by: Dinghao Liu > > Acked-by: Oliver Hartkopp > > Btw. as the vxcan.c driver bases on veth.c the same issue can be found >

Re: [PATCH] can: vxcan: Fix memleak in vxcan_newlink

2020-10-21 Thread Oliver Hartkopp
On 21.10.20 07:21, Dinghao Liu wrote: When rtnl_configure_link() fails, peer needs to be freed just like when register_netdevice() fails. Signed-off-by: Dinghao Liu Acked-by: Oliver Hartkopp Btw. as the vxcan.c driver bases on veth.c the same issue can be found there! At this point:

[PATCH] can: vxcan: Fix memleak in vxcan_newlink

2020-10-20 Thread Dinghao Liu
When rtnl_configure_link() fails, peer needs to be freed just like when register_netdevice() fails. Signed-off-by: Dinghao Liu --- drivers/net/can/vxcan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/can/vxcan.c b/drivers/net/can/vxcan.c index d6ba9426be4d..aefc5a61d239