Re: [PATCH] cgroup: fix cgroup_path() vs rename() race

2013-02-16 Thread Li Zefan
(sorry for the late reply, just came back from holiday) On 2013/2/9 2:46, Sasha Levin wrote: > On 01/25/2013 02:09 AM, Li Zefan wrote: >> rename() will change dentry->d_name. The result of this race can >> be worse than seeing partially rewritten name, but we might access >> a stale pointer

Re: [PATCH] cgroup: fix cgroup_path() vs rename() race

2013-02-16 Thread Li Zefan
(sorry for the late reply, just came back from holiday) On 2013/2/9 2:46, Sasha Levin wrote: On 01/25/2013 02:09 AM, Li Zefan wrote: rename() will change dentry-d_name. The result of this race can be worse than seeing partially rewritten name, but we might access a stale pointer because

Re: [PATCH] cgroup: fix cgroup_path() vs rename() race

2013-02-08 Thread Sasha Levin
On 01/25/2013 02:09 AM, Li Zefan wrote: > rename() will change dentry->d_name. The result of this race can > be worse than seeing partially rewritten name, but we might access > a stale pointer because rename() will re-allocate memory to hold > a longer name. > > Use dentry_path_raw(), and this

Re: [PATCH] cgroup: fix cgroup_path() vs rename() race

2013-02-08 Thread Sasha Levin
On 01/25/2013 02:09 AM, Li Zefan wrote: rename() will change dentry-d_name. The result of this race can be worse than seeing partially rewritten name, but we might access a stale pointer because rename() will re-allocate memory to hold a longer name. Use dentry_path_raw(), and this vfs API

Re: [PATCH] cgroup: fix cgroup_path() vs rename() race

2013-01-25 Thread Li Zefan
On 2013/1/26 0:42, Tejun Heo wrote: > On Fri, Jan 25, 2013 at 03:09:59PM +0800, Li Zefan wrote: >> rename() will change dentry->d_name. The result of this race can >> be worse than seeing partially rewritten name, but we might access >> a stale pointer because rename() will re-allocate memory to

Re: [PATCH] cgroup: fix cgroup_path() vs rename() race

2013-01-25 Thread Tejun Heo
On Fri, Jan 25, 2013 at 03:09:59PM +0800, Li Zefan wrote: > rename() will change dentry->d_name. The result of this race can > be worse than seeing partially rewritten name, but we might access > a stale pointer because rename() will re-allocate memory to hold > a longer name. > > Use

Re: [PATCH] cgroup: fix cgroup_path() vs rename() race

2013-01-25 Thread Tejun Heo
On Fri, Jan 25, 2013 at 03:09:59PM +0800, Li Zefan wrote: rename() will change dentry-d_name. The result of this race can be worse than seeing partially rewritten name, but we might access a stale pointer because rename() will re-allocate memory to hold a longer name. Use dentry_path_raw(),

Re: [PATCH] cgroup: fix cgroup_path() vs rename() race

2013-01-25 Thread Li Zefan
On 2013/1/26 0:42, Tejun Heo wrote: On Fri, Jan 25, 2013 at 03:09:59PM +0800, Li Zefan wrote: rename() will change dentry-d_name. The result of this race can be worse than seeing partially rewritten name, but we might access a stale pointer because rename() will re-allocate memory to hold a

[PATCH] cgroup: fix cgroup_path() vs rename() race

2013-01-24 Thread Li Zefan
rename() will change dentry->d_name. The result of this race can be worse than seeing partially rewritten name, but we might access a stale pointer because rename() will re-allocate memory to hold a longer name. Use dentry_path_raw(), and this vfs API will take care of lockings. Signed-off-by:

[PATCH] cgroup: fix cgroup_path() vs rename() race

2013-01-24 Thread Li Zefan
rename() will change dentry-d_name. The result of this race can be worse than seeing partially rewritten name, but we might access a stale pointer because rename() will re-allocate memory to hold a longer name. Use dentry_path_raw(), and this vfs API will take care of lockings. Signed-off-by: Li