Re: [PATCH] char: xillybus: Add driver for XillyUSB (Xillybus variant for USB)

2021-01-08 Thread Eli Billauer
Hello, Greg. On 07/01/21 13:39, Greg KH wrote: My point is, do NOT have different file names. Userspace should not care about the backing transport layer of a device. Regarding sound cards and such -- we agree perfectly. For a driver like XillyUSB, it's not necessarily clear what is

Re: [PATCH] char: xillybus: Add driver for XillyUSB (Xillybus variant for USB)

2021-01-07 Thread Greg KH
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I

Re: [PATCH] char: xillybus: Add driver for XillyUSB (Xillybus variant for USB)

2021-01-07 Thread Eli Billauer
Hello, Greg. I'm afraid we're not on the same page. As mentioned in the original patch description, XillyUSB and the existing Xillybus variant presents a nearly identical API. User space programs see no difference when using one or the other, except for different device file names. In that

Re: [PATCH] char: xillybus: Add driver for XillyUSB (Xillybus variant for USB)

2021-01-06 Thread Greg KH
On Wed, Jan 06, 2021 at 04:03:08PM +0200, Eli Billauer wrote: > Hello Greg, > > Merging XillyUSB's driver into xillybus_core.c was of course the initial > idea. Practically, it turned out that this doesn't reduce the number of code > lines nor makes the code easier to understand: The XillyUSB

Re: [PATCH] char: xillybus: Add driver for XillyUSB (Xillybus variant for USB)

2021-01-06 Thread Eli Billauer
Hello Greg, Merging XillyUSB's driver into xillybus_core.c was of course the initial idea. Practically, it turned out that this doesn't reduce the number of code lines nor makes the code easier to understand: The XillyUSB driver is a completely different deal internally, in almost every

Re: [PATCH] char: xillybus: Add driver for XillyUSB (Xillybus variant for USB)

2021-01-05 Thread Greg KH
On Sun, Dec 13, 2020 at 07:05:03PM +0200, eli.billa...@gmail.com wrote: > From: Eli Billauer > > The XillyUSB driver is the USB variant for the Xillybus FPGA IP core. > Even though it presents a nearly identical API on the FPGA and host, > it's almost a complete rewrite of the driver: The

Re: [PATCH] char: xillybus: Add driver for XillyUSB (Xillybus variant for USB)

2020-12-13 Thread Eli Billauer
Hello Randy, The new driver doesn't depend on XILLYBUS, so the patch puts it correctly outside the "if XILLYBUS" clause. It indeed looks like a mistake, but it isn't. :) Thanks for paying attention to this. Regards, Eli On 13/12/20 19:22, Randy Dunlap wrote: On 12/13/20 9:05 AM,

Re: [PATCH] char: xillybus: Add driver for XillyUSB (Xillybus variant for USB)

2020-12-13 Thread Randy Dunlap
On 12/13/20 9:05 AM, eli.billa...@gmail.com wrote: > diff --git a/drivers/char/xillybus/Kconfig b/drivers/char/xillybus/Kconfig > index 130dbdce858f..18fa99ec1029 100644 > --- a/drivers/char/xillybus/Kconfig > +++ b/drivers/char/xillybus/Kconfig > @@ -32,3 +32,14 @@ config XILLYBUS_OF >

[PATCH] char: xillybus: Add driver for XillyUSB (Xillybus variant for USB)

2020-12-13 Thread eli . billauer
From: Eli Billauer The XillyUSB driver is the USB variant for the Xillybus FPGA IP core. Even though it presents a nearly identical API on the FPGA and host, it's almost a complete rewrite of the driver: The framework for exchanging data on a USB bus is fundamentally different from doing the