Re: [PATCH] checkpatch: Add test for positional misuse of section specifiers like __initdata

2013-08-31 Thread Andi Kleen
> I'll get around to adding tests for your > cases soonish. You could also just apply my patch? AFAIK it works fine. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] checkpatch: Add test for positional misuse of section specifiers like __initdata

2013-08-31 Thread Joe Perches
On Sat, 2013-08-31 at 16:31 +0200, Andi Kleen wrote: > > A similar patch was suggested by Andi Kleen > > https://lkml.org/lkml/2013/8/5/648 > > My patch checked for const <-> initdata / non const initconst mistakes. > > I don't think your patch does that? Hi Andi. No it doesn't. This patch

Re: [PATCH] checkpatch: Add test for positional misuse of section specifiers like __initdata

2013-08-31 Thread Andi Kleen
> A similar patch was suggested by Andi Kleen > https://lkml.org/lkml/2013/8/5/648 My patch checked for const <-> initdata / non const initconst mistakes. I don't think your patch does that? -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [PATCH] checkpatch: Add test for positional misuse of section specifiers like __initdata

2013-08-31 Thread Andi Kleen
A similar patch was suggested by Andi Kleen https://lkml.org/lkml/2013/8/5/648 My patch checked for const - initdata / non const initconst mistakes. I don't think your patch does that? -Andi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [PATCH] checkpatch: Add test for positional misuse of section specifiers like __initdata

2013-08-31 Thread Joe Perches
On Sat, 2013-08-31 at 16:31 +0200, Andi Kleen wrote: A similar patch was suggested by Andi Kleen https://lkml.org/lkml/2013/8/5/648 My patch checked for const - initdata / non const initconst mistakes. I don't think your patch does that? Hi Andi. No it doesn't. This patch is just

Re: [PATCH] checkpatch: Add test for positional misuse of section specifiers like __initdata

2013-08-31 Thread Andi Kleen
I'll get around to adding tests for your cases soonish. You could also just apply my patch? AFAIK it works fine. -Andi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH] checkpatch: Add test for positional misuse of section specifiers like __initdata

2013-08-28 Thread Joe Perches
As discussed recently on the arm [1] and lm-sensors [2] lists, it is possible to use section markers on variables in a way which gcc doesn't understand (or at least not the way the developer intended): static struct __initdata samsung_pll_clock exynos4_plls[nr_plls] = { does NOT put exynos4_plls

[PATCH] checkpatch: Add test for positional misuse of section specifiers like __initdata

2013-08-28 Thread Joe Perches
As discussed recently on the arm [1] and lm-sensors [2] lists, it is possible to use section markers on variables in a way which gcc doesn't understand (or at least not the way the developer intended): static struct __initdata samsung_pll_clock exynos4_plls[nr_plls] = { does NOT put exynos4_plls