Re: [PATCH] checkpatch: add new warning when lookup_symbol_name() is used

2020-12-17 Thread Helge Deller
On 12/17/20 7:15 PM, Joe Perches wrote: > On Thu, 2020-12-17 at 18:42 +0100, Helge Deller wrote: >> On 12/17/20 6:27 PM, Joe Perches wrote: >>> On Thu, 2020-12-17 at 18:11 +0100, Helge Deller wrote: In most cases people use lookup_symbol_name() to resolve a kernel symbol and then print

Re: [PATCH] checkpatch: add new warning when lookup_symbol_name() is used

2020-12-17 Thread Joe Perches
On Thu, 2020-12-17 at 18:42 +0100, Helge Deller wrote: > On 12/17/20 6:27 PM, Joe Perches wrote: > > On Thu, 2020-12-17 at 18:11 +0100, Helge Deller wrote: > > > In most cases people use lookup_symbol_name() to resolve a kernel symbol > > > and then print it via printk(). > > > > > > In such

Re: [PATCH] checkpatch: add new warning when lookup_symbol_name() is used

2020-12-17 Thread Helge Deller
On 12/17/20 6:27 PM, Joe Perches wrote: > On Thu, 2020-12-17 at 18:11 +0100, Helge Deller wrote: >> In most cases people use lookup_symbol_name() to resolve a kernel symbol >> and then print it via printk(). >> >> In such cases using the %ps, %pS, %pSR or %pB printk formats are easier >> to use

Re: [PATCH] checkpatch: add new warning when lookup_symbol_name() is used

2020-12-17 Thread Joe Perches
On Thu, 2020-12-17 at 18:11 +0100, Helge Deller wrote: > In most cases people use lookup_symbol_name() to resolve a kernel symbol > and then print it via printk(). > > In such cases using the %ps, %pS, %pSR or %pB printk formats are easier > to use and thus should be preferred. [] > diff --git

[PATCH] checkpatch: add new warning when lookup_symbol_name() is used

2020-12-17 Thread Helge Deller
In most cases people use lookup_symbol_name() to resolve a kernel symbol and then print it via printk(). In such cases using the %ps, %pS, %pSR or %pB printk formats are easier to use and thus should be preferred. Signed-off-by: Helge Deller diff --git a/scripts/checkpatch.pl