Re: [PATCH] checkpatch: avoid default n

2019-07-03 Thread Miles Chen
On Wed, 2019-07-03 at 08:37 -0700, Joe Perches wrote: > On Wed, 2019-07-03 at 17:03 +0800, Yingjoe Chen wrote: > > On Wed, 2019-07-03 at 01:42 -0700, Joe Perches wrote: > > > On Wed, 2019-07-03 at 16:30 +0800, Miles Chen wrote: > > > > This change reports a warning when "default n" is used. > > >

Re: [PATCH] checkpatch: avoid default n

2019-07-03 Thread Joe Perches
On Wed, 2019-07-03 at 17:03 +0800, Yingjoe Chen wrote: > On Wed, 2019-07-03 at 01:42 -0700, Joe Perches wrote: > > On Wed, 2019-07-03 at 16:30 +0800, Miles Chen wrote: > > > This change reports a warning when "default n" is used. > > > > > > I have seen several "remove default n" patches, so I

Re: [PATCH] checkpatch: avoid default n

2019-07-03 Thread Miles Chen
On Wed, 2019-07-03 at 01:42 -0700, Joe Perches wrote: > On Wed, 2019-07-03 at 16:30 +0800, Miles Chen wrote: > > This change reports a warning when "default n" is used. > > > > I have seen several "remove default n" patches, so I think > > it might be helpful to add this test in checkpatch. > >

Re: [PATCH] checkpatch: avoid default n

2019-07-03 Thread Yingjoe Chen
On Wed, 2019-07-03 at 01:42 -0700, Joe Perches wrote: > On Wed, 2019-07-03 at 16:30 +0800, Miles Chen wrote: > > This change reports a warning when "default n" is used. > > > > I have seen several "remove default n" patches, so I think > > it might be helpful to add this test in checkpatch. > >

Re: [PATCH] checkpatch: avoid default n

2019-07-03 Thread Yingjoe Chen
On Wed, 2019-07-03 at 01:42 -0700, Joe Perches wrote: > On Wed, 2019-07-03 at 16:30 +0800, Miles Chen wrote: > > This change reports a warning when "default n" is used. > > > > I have seen several "remove default n" patches, so I think > > it might be helpful to add this test in checkpatch. > >

Re: [PATCH] checkpatch: avoid default n

2019-07-03 Thread Joe Perches
On Wed, 2019-07-03 at 16:30 +0800, Miles Chen wrote: > This change reports a warning when "default n" is used. > > I have seen several "remove default n" patches, so I think > it might be helpful to add this test in checkpatch. > > tested: > WARNING: 'default n' is the default value, no need to

[PATCH] checkpatch: avoid default n

2019-07-03 Thread Miles Chen
This change reports a warning when "default n" is used. I have seen several "remove default n" patches, so I think it might be helpful to add this test in checkpatch. tested: WARNING: 'default n' is the default value, no need to write it explicitly. + default n Signed-off-by: Miles Chen