Re: [PATCH] checkpatch: match more world writable permissions

2015-03-17 Thread Joe Perches
On Tue, 2015-03-17 at 16:17 -0700, Andrew Morton wrote: > --- > a/scripts/checkpatch.pl~checkpatch-match-more-world-writable-permissions-fix [] > -$our $mode_perms_world_writable = qr{ > +our $mode_perms_world_writable = qr{ You're a perl monk too? Cool! Thanks. -- To unsubscribe from this

Re: [PATCH] checkpatch: match more world writable permissions

2015-03-17 Thread Andrew Morton
On Fri, 13 Mar 2015 16:43:43 -0700 Joe Perches wrote: > Currently checkpatch will fuss if one uses world writable > settings in debugfs files and DEVICE_ATTR uses by testing > S_IWUGO but not testing S_IWOTH, S_IRWXUGO or S_IALLUGO. > > Extend the check to catch all cases exporting world

Re: [PATCH] checkpatch: match more world writable permissions

2015-03-17 Thread Andrew Morton
On Fri, 13 Mar 2015 16:43:43 -0700 Joe Perches j...@perches.com wrote: Currently checkpatch will fuss if one uses world writable settings in debugfs files and DEVICE_ATTR uses by testing S_IWUGO but not testing S_IWOTH, S_IRWXUGO or S_IALLUGO. Extend the check to catch all cases exporting

Re: [PATCH] checkpatch: match more world writable permissions

2015-03-17 Thread Joe Perches
On Tue, 2015-03-17 at 16:17 -0700, Andrew Morton wrote: --- a/scripts/checkpatch.pl~checkpatch-match-more-world-writable-permissions-fix [] -$our $mode_perms_world_writable = qr{ +our $mode_perms_world_writable = qr{ You're a perl monk too? Cool! Thanks. -- To unsubscribe from this list:

Re: [PATCH] checkpatch: match more world writable permissions

2015-03-14 Thread Joe Perches
On Sat, 2015-03-14 at 07:32 -0700, Guenter Roeck wrote: > On Fri, Mar 13, 2015 at 04:43:43PM -0700, Joe Perches wrote: > > Currently checkpatch will fuss if one uses world writable > > settings in debugfs files and DEVICE_ATTR uses by testing > > S_IWUGO but not testing S_IWOTH, S_IRWXUGO or

Re: [PATCH] checkpatch: match more world writable permissions

2015-03-14 Thread Guenter Roeck
On Fri, Mar 13, 2015 at 04:43:43PM -0700, Joe Perches wrote: > Currently checkpatch will fuss if one uses world writable > settings in debugfs files and DEVICE_ATTR uses by testing > S_IWUGO but not testing S_IWOTH, S_IRWXUGO or S_IALLUGO. > > Extend the check to catch all cases exporting world

Re: [PATCH] checkpatch: match more world writable permissions

2015-03-14 Thread Nicholas Mc Guire
On Fri, 13 Mar 2015, Joe Perches wrote: > Currently checkpatch will fuss if one uses world writable > settings in debugfs files and DEVICE_ATTR uses by testing > S_IWUGO but not testing S_IWOTH, S_IRWXUGO or S_IALLUGO. > > Extend the check to catch all cases exporting world writable >

Re: [PATCH] checkpatch: match more world writable permissions

2015-03-14 Thread Nicholas Mc Guire
On Fri, 13 Mar 2015, Joe Perches wrote: Currently checkpatch will fuss if one uses world writable settings in debugfs files and DEVICE_ATTR uses by testing S_IWUGO but not testing S_IWOTH, S_IRWXUGO or S_IALLUGO. Extend the check to catch all cases exporting world writable permissions

Re: [PATCH] checkpatch: match more world writable permissions

2015-03-14 Thread Guenter Roeck
On Fri, Mar 13, 2015 at 04:43:43PM -0700, Joe Perches wrote: Currently checkpatch will fuss if one uses world writable settings in debugfs files and DEVICE_ATTR uses by testing S_IWUGO but not testing S_IWOTH, S_IRWXUGO or S_IALLUGO. Extend the check to catch all cases exporting world

Re: [PATCH] checkpatch: match more world writable permissions

2015-03-14 Thread Joe Perches
On Sat, 2015-03-14 at 07:32 -0700, Guenter Roeck wrote: On Fri, Mar 13, 2015 at 04:43:43PM -0700, Joe Perches wrote: Currently checkpatch will fuss if one uses world writable settings in debugfs files and DEVICE_ATTR uses by testing S_IWUGO but not testing S_IWOTH, S_IRWXUGO or S_IALLUGO.

[PATCH] checkpatch: match more world writable permissions

2015-03-13 Thread Joe Perches
Currently checkpatch will fuss if one uses world writable settings in debugfs files and DEVICE_ATTR uses by testing S_IWUGO but not testing S_IWOTH, S_IRWXUGO or S_IALLUGO. Extend the check to catch all cases exporting world writable permissions including octal values. Original-patch-by:

[PATCH] checkpatch: match more world writable permissions

2015-03-13 Thread Joe Perches
Currently checkpatch will fuss if one uses world writable settings in debugfs files and DEVICE_ATTR uses by testing S_IWUGO but not testing S_IWOTH, S_IRWXUGO or S_IALLUGO. Extend the check to catch all cases exporting world writable permissions including octal values. Original-patch-by: