Re: [PATCH] checkpatch: warn for use of %px

2017-12-05 Thread Tobin C. Harding
On Tue, Dec 05, 2017 at 07:27:18AM -0800, Joe Perches wrote: > On Tue, 2017-12-05 at 20:44 +1100, Tobin C. Harding wrote: > > On Mon, Dec 04, 2017 at 11:24:24PM -0800, Joe Perches wrote: > > > On Tue, 2017-12-05 at 08:17 +1100, Tobin C. Harding wrote: > > > > Usage of the new %px specifier potentia

Re: [PATCH] checkpatch: warn for use of %px

2017-12-05 Thread Joe Perches
On Tue, 2017-12-05 at 20:44 +1100, Tobin C. Harding wrote: > On Mon, Dec 04, 2017 at 11:24:24PM -0800, Joe Perches wrote: > > On Tue, 2017-12-05 at 08:17 +1100, Tobin C. Harding wrote: > > > Usage of the new %px specifier potentially leaks sensitive > > > inforamtion. Printing kernel addresses expo

Re: [PATCH] checkpatch: warn for use of %px

2017-12-05 Thread Tobin C. Harding
On Mon, Dec 04, 2017 at 11:24:24PM -0800, Joe Perches wrote: > On Tue, 2017-12-05 at 08:17 +1100, Tobin C. Harding wrote: > > Usage of the new %px specifier potentially leaks sensitive > > inforamtion. Printing kernel addresses exposes the kernel layout in > > information I don't understand this

Re: [PATCH] checkpatch: warn for use of %px

2017-12-04 Thread Joe Perches
On Tue, 2017-12-05 at 08:17 +1100, Tobin C. Harding wrote: > Usage of the new %px specifier potentially leaks sensitive > inforamtion. Printing kernel addresses exposes the kernel layout in information > memory, this is potentially exploitable. We have tools in the kernel to > help us do the righ

[PATCH] checkpatch: warn for use of %px

2017-12-04 Thread Tobin C. Harding
Usage of the new %px specifier potentially leaks sensitive inforamtion. Printing kernel addresses exposes the kernel layout in memory, this is potentially exploitable. We have tools in the kernel to help us do the right thing. We can have checkpatch warn developers of potential dangers of using %px