Re: [PATCH] cifs: Convert to use the fallthrough macro

2020-08-10 Thread linmiaohe
Steve French wrote: > >merged into cifs-2.6.git for-next > Many thanks. > (but note that most places in fs directory other than cifs and btrfs have not > been updated), and I noticed another 8 places in fs/cifs that you didn't > change in your patch (ie change from the older way of

Re: [PATCH] cifs: Convert to use the fallthrough macro

2020-08-10 Thread Steve French
merged into cifs-2.6.git for-next (but note that most places in fs directory other than cifs and btrfs have not been updated), and I noticed another 8 places in fs/cifs that you didn't change in your patch (ie change from the older way of indicating fallthrough /* Fallthrough */ as a comment to

Re: [PATCH] cifs: Convert to use the fallthrough macro

2020-08-09 Thread Joe Perches
On Sun, 2020-08-09 at 11:46 -0500, Steve French wrote: > Is this conversion from "/* Fallthrough */" to the preferred (?) > "fallthrough;" documented anywhere? Documentation/process/deprecated.rst As there have been a long list of flaws `due to missing "break" statements

Re: [PATCH] cifs: Convert to use the fallthrough macro

2020-08-09 Thread Steve French
Is this conversion from "/* Fallthrough */" to the preferred (?) "fallthrough;" documented anywhere? All I see is a few fs changesets like: commit c730ae0c6bb3125ccb776fb2ab6abbdff500c02c Author: Marcos Paulo de Souza Date: Tue Jun 16 15:54:29 2020 -0300 btrfs: convert comments to

[PATCH] cifs: Convert to use the fallthrough macro

2020-08-08 Thread linmiaohe
From: Miaohe Lin Convert the uses of fallthrough comments to fallthrough macro. Signed-off-by: Hongxiang Lou Signed-off-by: Miaohe Lin --- fs/cifs/smb2pdu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c index