Global variables should be defined in C files, not in headers.
1) Comment out unused vars
GlobalDnotifyRsp_Q
GlobalUidList
2) Declare vars in cifsfs.c that need it and change to extern in
cifsglob.h
3) Change to extern in cifsglob.h for vars that were already being
declared in cifsfs.c
4)
Global variables should be defined in C files, not in headers.
1) Comment out unused vars
GlobalDnotifyRsp_Q
GlobalUidList
2) Declare vars in cifsfs.c that need it and change to extern in
cifsglob.h
3) Change to extern in cifsglob.h for vars that were already being
declared in cifsfs.c
4)
Global vaiables should be defined in C files, not in headers.
1) Comment out unused vars
GlobalDnotifyRsp_Q
GlobalUidList
2) Declare vars in cifsfs.c that need it and change to extern in
cifsglob.h
3) Change to extern in cifsglob.h for vars that were already being
declared in cifsfs.c
4)
Global vaiables should be defined in C files, not in headers.
1) Comment out unused vars
GlobalDnotifyRsp_Q
GlobalUidList
2) Declare vars in cifsfs.c that need it and change to extern in
cifsglob.h
3) Change to extern in cifsglob.h for vars that were already being
declared in cifsfs.c
4)
Just use extern, saves a lot of sparse warnings.
fs/cifs/cifsglob.h:603:33: warning: symbol 'GlobalUidList' was not declared.
Should it be static?
fs/cifs/cifsglob.h:606:32: warning: symbol 'GlobalSMBSessionList' was not
declared. Should it be static?
fs/cifs/cifsglob.h:607:32: warning: symbol
Just use extern, saves a lot of sparse warnings.
fs/cifs/cifsglob.h:603:33: warning: symbol 'GlobalUidList' was not declared.
Should it be static?
fs/cifs/cifsglob.h:606:32: warning: symbol 'GlobalSMBSessionList' was not
declared. Should it be static?
fs/cifs/cifsglob.h:607:32: warning: symbol
6 matches
Mail list logo