Re: [PATCH] cleanup ti-soc-thermal

2015-01-03 Thread Pavel Machek
On Sat 2015-01-03 12:57:04, Nishanth Menon wrote: > On 01/03/2015 12:51 PM, Pavel Machek wrote: > >On Sat 2015-01-03 11:48:04, Nishanth Menon wrote: > >>On 12:19-20150103, Pavel Machek wrote: > >>>Simplify code by removing goto's where they point to simple return. > >>> > >>>Avoid confusing |= on

Re: [PATCH] cleanup ti-soc-thermal

2015-01-03 Thread Nishanth Menon
On 01/03/2015 12:51 PM, Pavel Machek wrote: On Sat 2015-01-03 11:48:04, Nishanth Menon wrote: On 12:19-20150103, Pavel Machek wrote: Simplify code by removing goto's where they point to simple return. Avoid confusing |= on error values. Please split these up into chunks of related changes.

Re: [PATCH] cleanup ti-soc-thermal

2015-01-03 Thread Pavel Machek
On Sat 2015-01-03 11:48:04, Nishanth Menon wrote: > On 12:19-20150103, Pavel Machek wrote: > > Simplify code by removing goto's where they point to simple return. > > > > Avoid confusing |= on error values. > > Please split these up into chunks of related changes. there is white > space and

Re: [PATCH] cleanup ti-soc-thermal

2015-01-03 Thread Pavel Machek
On Sat 2015-01-03 11:48:04, Nishanth Menon wrote: > On 12:19-20150103, Pavel Machek wrote: > > Simplify code by removing goto's where they point to simple return. > > > > Avoid confusing |= on error values. > > Please split these up into chunks of related changes. there is white > space and

Re: [PATCH] cleanup ti-soc-thermal

2015-01-03 Thread Nishanth Menon
On 12:19-20150103, Pavel Machek wrote: > Simplify code by removing goto's where they point to simple return. > > Avoid confusing |= on error values. Please split these up into chunks of related changes. there is white space and quiet a few other changes all mixed in. Also please cc linux-omap

[PATCH] cleanup ti-soc-thermal

2015-01-03 Thread Pavel Machek
Simplify code by removing goto's where they point to simple return. Avoid confusing |= on error values. Correct whitespace. Signed-off-by: Pavel Machek diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c index 634b6ce..3b4e72f 100644 ---

Re: [PATCH] cleanup ti-soc-thermal

2015-01-03 Thread Nishanth Menon
On 12:19-20150103, Pavel Machek wrote: Simplify code by removing goto's where they point to simple return. Avoid confusing |= on error values. Please split these up into chunks of related changes. there is white space and quiet a few other changes all mixed in. Also please cc linux-omap

[PATCH] cleanup ti-soc-thermal

2015-01-03 Thread Pavel Machek
Simplify code by removing goto's where they point to simple return. Avoid confusing |= on error values. Correct whitespace. Signed-off-by: Pavel Machek pa...@ucw.cz diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c index 634b6ce..3b4e72f

Re: [PATCH] cleanup ti-soc-thermal

2015-01-03 Thread Pavel Machek
On Sat 2015-01-03 11:48:04, Nishanth Menon wrote: On 12:19-20150103, Pavel Machek wrote: Simplify code by removing goto's where they point to simple return. Avoid confusing |= on error values. Please split these up into chunks of related changes. there is white space and quiet a few

Re: [PATCH] cleanup ti-soc-thermal

2015-01-03 Thread Pavel Machek
On Sat 2015-01-03 12:57:04, Nishanth Menon wrote: On 01/03/2015 12:51 PM, Pavel Machek wrote: On Sat 2015-01-03 11:48:04, Nishanth Menon wrote: On 12:19-20150103, Pavel Machek wrote: Simplify code by removing goto's where they point to simple return. Avoid confusing |= on error values.

Re: [PATCH] cleanup ti-soc-thermal

2015-01-03 Thread Nishanth Menon
On 01/03/2015 12:51 PM, Pavel Machek wrote: On Sat 2015-01-03 11:48:04, Nishanth Menon wrote: On 12:19-20150103, Pavel Machek wrote: Simplify code by removing goto's where they point to simple return. Avoid confusing |= on error values. Please split these up into chunks of related changes.

Re: [PATCH] cleanup ti-soc-thermal

2015-01-03 Thread Pavel Machek
On Sat 2015-01-03 11:48:04, Nishanth Menon wrote: On 12:19-20150103, Pavel Machek wrote: Simplify code by removing goto's where they point to simple return. Avoid confusing |= on error values. Please split these up into chunks of related changes. there is white space and quiet a few