Re: [PATCH] clk: fix clk_mux_val_to_index() error value

2018-12-04 Thread Stephen Boyd
Quoting Jerome Brunet (2018-12-04 11:55:10) > On Tue, 2018-12-04 at 10:43 -0800, Stephen Boyd wrote: > > Quoting Jerome Brunet (2018-12-04 08:34:03) > > > clk_mux_val_to_index() is meant to be used by .get_parent(), which > > > returns a u8, so when the value provided does not map to any valid

Re: [PATCH] clk: fix clk_mux_val_to_index() error value

2018-12-04 Thread Stephen Boyd
Quoting Jerome Brunet (2018-12-04 11:55:10) > On Tue, 2018-12-04 at 10:43 -0800, Stephen Boyd wrote: > > Quoting Jerome Brunet (2018-12-04 08:34:03) > > > clk_mux_val_to_index() is meant to be used by .get_parent(), which > > > returns a u8, so when the value provided does not map to any valid

Re: [PATCH] clk: fix clk_mux_val_to_index() error value

2018-12-04 Thread Jerome Brunet
On Tue, 2018-12-04 at 10:43 -0800, Stephen Boyd wrote: > Quoting Jerome Brunet (2018-12-04 08:34:03) > > clk_mux_val_to_index() is meant to be used by .get_parent(), which > > returns a u8, so when the value provided does not map to any valid index, > > it is not a good idea to return a negative

Re: [PATCH] clk: fix clk_mux_val_to_index() error value

2018-12-04 Thread Jerome Brunet
On Tue, 2018-12-04 at 10:43 -0800, Stephen Boyd wrote: > Quoting Jerome Brunet (2018-12-04 08:34:03) > > clk_mux_val_to_index() is meant to be used by .get_parent(), which > > returns a u8, so when the value provided does not map to any valid index, > > it is not a good idea to return a negative

Re: [PATCH] clk: fix clk_mux_val_to_index() error value

2018-12-04 Thread Stephen Boyd
Quoting Jerome Brunet (2018-12-04 08:34:03) > clk_mux_val_to_index() is meant to be used by .get_parent(), which > returns a u8, so when the value provided does not map to any valid index, > it is not a good idea to return a negative error value. > > Instead, return num_parents which we know is

Re: [PATCH] clk: fix clk_mux_val_to_index() error value

2018-12-04 Thread Stephen Boyd
Quoting Jerome Brunet (2018-12-04 08:34:03) > clk_mux_val_to_index() is meant to be used by .get_parent(), which > returns a u8, so when the value provided does not map to any valid index, > it is not a good idea to return a negative error value. > > Instead, return num_parents which we know is

[PATCH] clk: fix clk_mux_val_to_index() error value

2018-12-04 Thread Jerome Brunet
clk_mux_val_to_index() is meant to be used by .get_parent(), which returns a u8, so when the value provided does not map to any valid index, it is not a good idea to return a negative error value. Instead, return num_parents which we know is an invalid index and let CCF deal with it. Fixes:

[PATCH] clk: fix clk_mux_val_to_index() error value

2018-12-04 Thread Jerome Brunet
clk_mux_val_to_index() is meant to be used by .get_parent(), which returns a u8, so when the value provided does not map to any valid index, it is not a good idea to return a negative error value. Instead, return num_parents which we know is an invalid index and let CCF deal with it. Fixes: