Re: [PATCH] clk: rockchip: fix frac settings of GPLL clock for rk3328

2018-12-24 Thread Heiko Stuebner
Am Samstag, 22. Dezember 2018, 17:42:49 CET schrieb Katsuhiro Suzuki: > This patch fixes settings of GPLL frequency in fractional mode for > rk3328. In this mode, FOUTVCO is calcurated by following formula: > FOUTVCO = FREF * FBDIV / REFDIV + ((FREF * FRAC / REFDIV) >> 24) > > The problem is in

Re: [PATCH] clk: rockchip: fix frac settings of GPLL clock for rk3328

2018-12-23 Thread Heiko Stuebner
chips.com > > From: Heiko Stuebner > Date: 2018-12-24 15:34 > To: Katsuhiro Suzuki; Finley Xiao; Elaine Zhang > CC: linux-rockchip; linux-arm-kernel; linux-kernel > Subject: Re: [PATCH] clk: rockchip: fix frac settings of GPLL clock for rk3328 > Hi, > > Am Sa

Re: [PATCH] clk: rockchip: fix frac settings of GPLL clock for rk3328

2018-12-23 Thread Heiko Stuebner
Hi, Am Samstag, 22. Dezember 2018, 17:42:49 CET schrieb Katsuhiro Suzuki: > This patch fixes settings of GPLL frequency in fractional mode for > rk3328. In this mode, FOUTVCO is calcurated by following formula: > FOUTVCO = FREF * FBDIV / REFDIV + ((FREF * FRAC / REFDIV) >> 24) > > The problem

[PATCH] clk: rockchip: fix frac settings of GPLL clock for rk3328

2018-12-22 Thread Katsuhiro Suzuki
This patch fixes settings of GPLL frequency in fractional mode for rk3328. In this mode, FOUTVCO is calcurated by following formula: FOUTVCO = FREF * FBDIV / REFDIV + ((FREF * FRAC / REFDIV) >> 24) The problem is in FREF * FRAC >> 24 term. This result always lacks one from target value is