Re: [PATCH] clocksource: don't run watchdog forever

2021-03-25 Thread Thomas Gleixner
On Thu, Mar 25 2021 at 16:34, Feng Tang wrote: > On Wed, Mar 03, 2021 at 04:50:31PM +0100, Thomas Gleixner wrote: > > I've checked one open-sourced BIOS code project: EDK2 > (https://github.com/tianocore/edk2), > where I did some grep and can't find places writting to tsc_adjust msr, > which can

Re: [PATCH] clocksource: don't run watchdog forever

2021-03-25 Thread Feng Tang
Hi Thomas, On Wed, Mar 03, 2021 at 04:50:31PM +0100, Thomas Gleixner wrote: > On Tue, Mar 02 2021 at 20:06, Feng Tang wrote: > > On Tue, Mar 02, 2021 at 10:16:37AM +0100, Peter Zijlstra wrote: > >> On Tue, Mar 02, 2021 at 10:54:24AM +0800, Feng Tang wrote: > >> > clocksource watchdog runs every

Re: [PATCH] clocksource: don't run watchdog forever

2021-03-04 Thread Feng Tang
On Thu, Mar 04, 2021 at 03:15:13PM +0100, Thomas Gleixner wrote: > Feng, > > On Thu, Mar 04 2021 at 15:43, Feng Tang wrote: > > On Wed, Mar 03, 2021 at 04:50:31PM +0100, Thomas Gleixner wrote: > >> Anything pre TSC_ADJUST wants the watchdog on. With TSC ADJUST available > >> we can probably avoid

Re: [PATCH] clocksource: don't run watchdog forever

2021-03-04 Thread Thomas Gleixner
Feng, On Thu, Mar 04 2021 at 15:43, Feng Tang wrote: > On Wed, Mar 03, 2021 at 04:50:31PM +0100, Thomas Gleixner wrote: >> Anything pre TSC_ADJUST wants the watchdog on. With TSC ADJUST available >> we can probably avoid it. >> >> There is a caveat though. If the machine never goes idle then TSC

Re: [PATCH] clocksource: don't run watchdog forever

2021-03-03 Thread Feng Tang
Hi Thomas, On Wed, Mar 03, 2021 at 04:50:31PM +0100, Thomas Gleixner wrote: > On Tue, Mar 02 2021 at 20:06, Feng Tang wrote: > > On Tue, Mar 02, 2021 at 10:16:37AM +0100, Peter Zijlstra wrote: > >> On Tue, Mar 02, 2021 at 10:54:24AM +0800, Feng Tang wrote: > >> > clocksource watchdog runs every

Re: [PATCH] clocksource: don't run watchdog forever

2021-03-03 Thread Thomas Gleixner
On Tue, Mar 02 2021 at 20:06, Feng Tang wrote: > On Tue, Mar 02, 2021 at 10:16:37AM +0100, Peter Zijlstra wrote: >> On Tue, Mar 02, 2021 at 10:54:24AM +0800, Feng Tang wrote: >> > clocksource watchdog runs every 500ms, which creates some OS noise. >> > As the clocksource wreckage (especially for

Re: [PATCH] clocksource: don't run watchdog forever

2021-03-02 Thread Feng Tang
Hi Peter, On Tue, Mar 02, 2021 at 10:16:37AM +0100, Peter Zijlstra wrote: > On Tue, Mar 02, 2021 at 10:54:24AM +0800, Feng Tang wrote: > > clocksource watchdog runs every 500ms, which creates some OS noise. > > As the clocksource wreckage (especially for those that has per-cpu > > reading hook)

Re: [PATCH] clocksource: don't run watchdog forever

2021-03-02 Thread Peter Zijlstra
On Tue, Mar 02, 2021 at 10:54:24AM +0800, Feng Tang wrote: > clocksource watchdog runs every 500ms, which creates some OS noise. > As the clocksource wreckage (especially for those that has per-cpu > reading hook) usually happens shortly after CPU is brought up or > after system resumes from sleep

[PATCH] clocksource: don't run watchdog forever

2021-03-01 Thread Feng Tang
clocksource watchdog runs every 500ms, which creates some OS noise. As the clocksource wreckage (especially for those that has per-cpu reading hook) usually happens shortly after CPU is brought up or after system resumes from sleep state, so add a time limit for clocksource watchdog to only run