Re: [PATCH] coccinelle: reduce false positives

2018-02-01 18:48 GMT+09:00 Julia Lawall : > Some files use both a non-devm allocation and a devm_allocation. Don't > complain about a free when the same function contains a non-devm > allocation. > > Signed-off-by: Julia Lawall > > --- >

Re: [PATCH] coccinelle: reduce false positives

2018-02-01 18:48 GMT+09:00 Julia Lawall : > Some files use both a non-devm allocation and a devm_allocation. Don't > complain about a free when the same function contains a non-devm > allocation. > > Signed-off-by: Julia Lawall > > --- > scripts/coccinelle/free/devm_free.cocci | 55 >

Re: [PATCH] coccinelle: reduce false positives

On Thu, Feb 01, 2018 at 12:06:35PM +0100, Julia Lawall wrote: > Here are the results that are eliminated by my change: > > drivers/clk/axs10x/pll_clock.c:323:1-6 kfree(pll_clk); > drivers/clk/clk-gpio.c:131:2-7 kfree(clk_gpio); > drivers/clk/clk-hsdk-pll.c:410:1-6 kfree(pll_clk); >

Re: [PATCH] coccinelle: reduce false positives

On Thu, Feb 01, 2018 at 12:06:35PM +0100, Julia Lawall wrote: > Here are the results that are eliminated by my change: > > drivers/clk/axs10x/pll_clock.c:323:1-6 kfree(pll_clk); > drivers/clk/clk-gpio.c:131:2-7 kfree(clk_gpio); > drivers/clk/clk-hsdk-pll.c:410:1-6 kfree(pll_clk); >

Re: [PATCH] coccinelle: reduce false positives

Here are the results that are eliminated by my change: drivers/clk/axs10x/pll_clock.c:323:1-6 kfree(pll_clk); drivers/clk/clk-gpio.c:131:2-7 kfree(clk_gpio); drivers/clk/clk-hsdk-pll.c:410:1-6 kfree(pll_clk); drivers/clk/hisilicon/clk.c:97:1-6 kfree(clk_data); drivers/mfd/syscon.c:130:1-8

Re: [PATCH] coccinelle: reduce false positives

Here are the results that are eliminated by my change: drivers/clk/axs10x/pll_clock.c:323:1-6 kfree(pll_clk); drivers/clk/clk-gpio.c:131:2-7 kfree(clk_gpio); drivers/clk/clk-hsdk-pll.c:410:1-6 kfree(pll_clk); drivers/clk/hisilicon/clk.c:97:1-6 kfree(clk_data); drivers/mfd/syscon.c:130:1-8

Re: [PATCH] coccinelle: reduce false positives

On Thu, Feb 01, 2018 at 10:48:52AM +0100, Julia Lawall wrote: > Some files use both a non-devm allocation and a devm_allocation. Don't > complain about a free when the same function contains a non-devm > allocation. > > Signed-off-by: Julia Lawall > That's surprising...

Re: [PATCH] coccinelle: reduce false positives

On Thu, Feb 01, 2018 at 10:48:52AM +0100, Julia Lawall wrote: > Some files use both a non-devm allocation and a devm_allocation. Don't > complain about a free when the same function contains a non-devm > allocation. > > Signed-off-by: Julia Lawall > That's surprising... Do you have an

[PATCH] coccinelle: reduce false positives

Some files use both a non-devm allocation and a devm_allocation. Don't complain about a free when the same function contains a non-devm allocation. Signed-off-by: Julia Lawall --- scripts/coccinelle/free/devm_free.cocci | 55 +++- 1 file

[PATCH] coccinelle: reduce false positives

Some files use both a non-devm allocation and a devm_allocation. Don't complain about a free when the same function contains a non-devm allocation. Signed-off-by: Julia Lawall --- scripts/coccinelle/free/devm_free.cocci | 55 +++- 1 file changed, 54