Re: [PATCH] compiler-gcc: get back Clang build

2018-08-22 Thread Dominique Martinet
Nick Desaulniers wrote on Wed, Aug 22, 2018: > I'm currently testing a fix in > https://github.com/ClangBuiltLinux/linux/commit/1f89ae7622c26b8131f42f3a362d6ef41b88a595, > can you please share with me your steps to test/verify that the patch > fixes the issue for eBPF? I'll go talk to a co-worker

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-22 Thread Dominique Martinet
Nick Desaulniers wrote on Wed, Aug 22, 2018: > I'm currently testing a fix in > https://github.com/ClangBuiltLinux/linux/commit/1f89ae7622c26b8131f42f3a362d6ef41b88a595, > can you please share with me your steps to test/verify that the patch > fixes the issue for eBPF? I'll go talk to a co-worker

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-22 Thread Joe Perches
On Wed, 2018-08-22 at 16:05 -0700, Nick Desaulniers wrote: Hey Nick. > On Wed, Aug 22, 2018 at 1:50 PM Joe Perches wrote: > > A mild suggestion about the patch would be to break it up into > > 2 patches to improve how people read and review them. > > > > 1 include/linux/compiler-* > > 2

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-22 Thread Joe Perches
On Wed, 2018-08-22 at 16:05 -0700, Nick Desaulniers wrote: Hey Nick. > On Wed, Aug 22, 2018 at 1:50 PM Joe Perches wrote: > > A mild suggestion about the patch would be to break it up into > > 2 patches to improve how people read and review them. > > > > 1 include/linux/compiler-* > > 2

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-22 Thread Nick Desaulniers
On Wed, Aug 22, 2018 at 1:50 PM Joe Perches wrote: > > On Wed, 2018-08-22 at 11:31 -0700, Nick Desaulniers wrote: > > On Tue, Aug 21, 2018 at 9:32 PM Dominique Martinet > > wrote: > > > > > > Joe Perches wrote on Tue, Aug 21, 2018: > > > > On Wed, 2018-08-22 at 06:16 +0200, Dominique Martinet

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-22 Thread Nick Desaulniers
On Wed, Aug 22, 2018 at 1:50 PM Joe Perches wrote: > > On Wed, 2018-08-22 at 11:31 -0700, Nick Desaulniers wrote: > > On Tue, Aug 21, 2018 at 9:32 PM Dominique Martinet > > wrote: > > > > > > Joe Perches wrote on Tue, Aug 21, 2018: > > > > On Wed, 2018-08-22 at 06:16 +0200, Dominique Martinet

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-22 Thread Joe Perches
On Wed, 2018-08-22 at 11:31 -0700, Nick Desaulniers wrote: > On Tue, Aug 21, 2018 at 9:32 PM Dominique Martinet > wrote: > > > > Joe Perches wrote on Tue, Aug 21, 2018: > > > On Wed, 2018-08-22 at 06:16 +0200, Dominique Martinet wrote: > > > > I think that could work, but at the point making a

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-22 Thread Joe Perches
On Wed, 2018-08-22 at 11:31 -0700, Nick Desaulniers wrote: > On Tue, Aug 21, 2018 at 9:32 PM Dominique Martinet > wrote: > > > > Joe Perches wrote on Tue, Aug 21, 2018: > > > On Wed, 2018-08-22 at 06:16 +0200, Dominique Martinet wrote: > > > > I think that could work, but at the point making a

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-22 Thread Nick Desaulniers
On Wed, Aug 22, 2018 at 11:31 AM Nick Desaulniers wrote: > Hi Dominique, > I'm currently testing a fix in > https://github.com/ClangBuiltLinux/linux/commit/1f89ae7622c26b8131f42f3a362d6ef41b88a595, Sorry, maybe https://github.com/ClangBuiltLinux/linux/commits/compiler_detection is a better link,

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-22 Thread Nick Desaulniers
On Wed, Aug 22, 2018 at 11:31 AM Nick Desaulniers wrote: > Hi Dominique, > I'm currently testing a fix in > https://github.com/ClangBuiltLinux/linux/commit/1f89ae7622c26b8131f42f3a362d6ef41b88a595, Sorry, maybe https://github.com/ClangBuiltLinux/linux/commits/compiler_detection is a better link,

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-22 Thread Nick Desaulniers
On Tue, Aug 21, 2018 at 9:32 PM Dominique Martinet wrote: > > Joe Perches wrote on Tue, Aug 21, 2018: > > On Wed, 2018-08-22 at 06:16 +0200, Dominique Martinet wrote: > > > I think that could work, but at the point making a separate > > > compiler-common.h and not including compiler-gcc.h for

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-22 Thread Nick Desaulniers
On Tue, Aug 21, 2018 at 9:32 PM Dominique Martinet wrote: > > Joe Perches wrote on Tue, Aug 21, 2018: > > On Wed, 2018-08-22 at 06:16 +0200, Dominique Martinet wrote: > > > I think that could work, but at the point making a separate > > > compiler-common.h and not including compiler-gcc.h for

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Dominique Martinet
Joe Perches wrote on Tue, Aug 21, 2018: > On Wed, 2018-08-22 at 06:16 +0200, Dominique Martinet wrote: > > I think that could work, but at the point making a separate > > compiler-common.h and not including compiler-gcc.h for clang sounds > > better to me... More importantly here, either solution

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Dominique Martinet
Joe Perches wrote on Tue, Aug 21, 2018: > On Wed, 2018-08-22 at 06:16 +0200, Dominique Martinet wrote: > > I think that could work, but at the point making a separate > > compiler-common.h and not including compiler-gcc.h for clang sounds > > better to me... More importantly here, either solution

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Joe Perches
On Wed, 2018-08-22 at 06:16 +0200, Dominique Martinet wrote: > I think that could work, but at the point making a separate > compiler-common.h and not including compiler-gcc.h for clang sounds > better to me... More importantly here, either solution sound complex > enough to require more than a

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Joe Perches
On Wed, 2018-08-22 at 06:16 +0200, Dominique Martinet wrote: > I think that could work, but at the point making a separate > compiler-common.h and not including compiler-gcc.h for clang sounds > better to me... More importantly here, either solution sound complex > enough to require more than a

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Dominique Martinet
Nick Desaulniers wrote on Tue, Aug 21, 2018: > On Tue, Aug 21, 2018 at 9:45 AM Joe Perches wrote: > > > Tested with gcc-7 and clang-8. > > > > clang-8? Isn't the latest officlal clang 6.0.1 ? > [...] > > So if something other than 6.0.x is required, > > then some additional check should probably

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Dominique Martinet
Nick Desaulniers wrote on Tue, Aug 21, 2018: > On Tue, Aug 21, 2018 at 9:45 AM Joe Perches wrote: > > > Tested with gcc-7 and clang-8. > > > > clang-8? Isn't the latest officlal clang 6.0.1 ? > [...] > > So if something other than 6.0.x is required, > > then some additional check should probably

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Joe Perches
On Tue, 2018-08-21 at 09:57 -0700, Nick Desaulniers wrote: > On Tue, Aug 21, 2018 at 9:33 AM Joe Perches wrote: > > > > On Tue, 2018-08-21 at 15:48 +0900, Masahiro Yamada wrote: > > > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > > > missed the fact that is included by

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Joe Perches
On Tue, 2018-08-21 at 09:57 -0700, Nick Desaulniers wrote: > On Tue, Aug 21, 2018 at 9:33 AM Joe Perches wrote: > > > > On Tue, 2018-08-21 at 15:48 +0900, Masahiro Yamada wrote: > > > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > > > missed the fact that is included by

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Joe Perches
On Wed, 2018-08-22 at 02:13 +0900, Masahiro Yamada wrote: > Hi Joe, > > > 2018-08-21 19:39 GMT+09:00 Joe Perches : > > On Tue, 2018-08-21 at 15:48 +0900, Masahiro Yamada wrote: > > > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > > > missed the fact that is included by

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Joe Perches
On Wed, 2018-08-22 at 02:13 +0900, Masahiro Yamada wrote: > Hi Joe, > > > 2018-08-21 19:39 GMT+09:00 Joe Perches : > > On Tue, 2018-08-21 at 15:48 +0900, Masahiro Yamada wrote: > > > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > > > missed the fact that is included by

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Masahiro Yamada
Hi Joe, 2018-08-21 19:39 GMT+09:00 Joe Perches : > On Tue, 2018-08-21 at 15:48 +0900, Masahiro Yamada wrote: >> Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") >> missed the fact that is included by Clang >> as well as by GCC. >> >> Clang actually defines __GNUC__,

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Masahiro Yamada
Hi Joe, 2018-08-21 19:39 GMT+09:00 Joe Perches : > On Tue, 2018-08-21 at 15:48 +0900, Masahiro Yamada wrote: >> Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") >> missed the fact that is included by Clang >> as well as by GCC. >> >> Clang actually defines __GNUC__,

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Masahiro Yamada
2018-08-22 1:33 GMT+09:00 Joe Perches : > On Tue, 2018-08-21 at 15:48 +0900, Masahiro Yamada wrote: >> Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") >> missed the fact that is included by Clang >> as well as by GCC. >> >> Clang actually defines __GNUC__, __GNUC_MINOR__,

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Masahiro Yamada
2018-08-22 1:33 GMT+09:00 Joe Perches : > On Tue, 2018-08-21 at 15:48 +0900, Masahiro Yamada wrote: >> Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") >> missed the fact that is included by Clang >> as well as by GCC. >> >> Clang actually defines __GNUC__, __GNUC_MINOR__,

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Nick Desaulniers
On Tue, Aug 21, 2018 at 9:45 AM Joe Perches wrote: > > On Tue, 2018-08-21 at 09:32 -0700, Nick Desaulniers wrote: > > On Tue, Aug 21, 2018 at 5:38 AM Dominique Martinet > > wrote: > > > > > > Nick Desaulniers Aug. 21, 2018, 8:09 a.m. UTC: > > > > Thanks for noticing, and sending this patch. I'm

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Nick Desaulniers
On Tue, Aug 21, 2018 at 9:45 AM Joe Perches wrote: > > On Tue, 2018-08-21 at 09:32 -0700, Nick Desaulniers wrote: > > On Tue, Aug 21, 2018 at 5:38 AM Dominique Martinet > > wrote: > > > > > > Nick Desaulniers Aug. 21, 2018, 8:09 a.m. UTC: > > > > Thanks for noticing, and sending this patch. I'm

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Nick Desaulniers
On Tue, Aug 21, 2018 at 9:33 AM Joe Perches wrote: > > On Tue, 2018-08-21 at 15:48 +0900, Masahiro Yamada wrote: > > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > > missed the fact that is included by Clang > > as well as by GCC. > > > > Clang actually defines __GNUC__,

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Nick Desaulniers
On Tue, Aug 21, 2018 at 9:33 AM Joe Perches wrote: > > On Tue, 2018-08-21 at 15:48 +0900, Masahiro Yamada wrote: > > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > > missed the fact that is included by Clang > > as well as by GCC. > > > > Clang actually defines __GNUC__,

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Joe Perches
On Tue, 2018-08-21 at 09:32 -0700, Nick Desaulniers wrote: > On Tue, Aug 21, 2018 at 5:38 AM Dominique Martinet > wrote: > > > > Nick Desaulniers Aug. 21, 2018, 8:09 a.m. UTC: > > > Thanks for noticing, and sending this patch. I'm happy to see others > > > testing with Clang. I noticed this

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Joe Perches
On Tue, 2018-08-21 at 09:32 -0700, Nick Desaulniers wrote: > On Tue, Aug 21, 2018 at 5:38 AM Dominique Martinet > wrote: > > > > Nick Desaulniers Aug. 21, 2018, 8:09 a.m. UTC: > > > Thanks for noticing, and sending this patch. I'm happy to see others > > > testing with Clang. I noticed this

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Nick Desaulniers
On Tue, Aug 21, 2018 at 3:39 AM Joe Perches wrote: > > On Tue, 2018-08-21 at 15:48 +0900, Masahiro Yamada wrote: > > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > > missed the fact that is included by Clang > > as well as by GCC. > > > > Clang actually defines __GNUC__,

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Nick Desaulniers
On Tue, Aug 21, 2018 at 3:39 AM Joe Perches wrote: > > On Tue, 2018-08-21 at 15:48 +0900, Masahiro Yamada wrote: > > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > > missed the fact that is included by Clang > > as well as by GCC. > > > > Clang actually defines __GNUC__,

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Joe Perches
On Tue, 2018-08-21 at 15:48 +0900, Masahiro Yamada wrote: > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > missed the fact that is included by Clang > as well as by GCC. > > Clang actually defines __GNUC__, __GNUC_MINOR__, __GNUC_PATCHLEVEL__ > and it looks like GCC

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Joe Perches
On Tue, 2018-08-21 at 15:48 +0900, Masahiro Yamada wrote: > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > missed the fact that is included by Clang > as well as by GCC. > > Clang actually defines __GNUC__, __GNUC_MINOR__, __GNUC_PATCHLEVEL__ > and it looks like GCC

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Nick Desaulniers
On Tue, Aug 21, 2018 at 5:38 AM Dominique Martinet wrote: > > Nick Desaulniers Aug. 21, 2018, 8:09 a.m. UTC: > > Thanks for noticing, and sending this patch. I'm happy to see others > > testing with Clang. I noticed this too near the end of the day > >

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Nick Desaulniers
On Tue, Aug 21, 2018 at 5:38 AM Dominique Martinet wrote: > > Nick Desaulniers Aug. 21, 2018, 8:09 a.m. UTC: > > Thanks for noticing, and sending this patch. I'm happy to see others > > testing with Clang. I noticed this too near the end of the day > >

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Dominique Martinet
Nick Desaulniers Aug. 21, 2018, 8:09 a.m. UTC: > Thanks for noticing, and sending this patch. I'm happy to see others > testing with Clang. I noticed this too near the end of the day > https://github.com/ClangBuiltLinux/linux/issues/27. FWIW libbcc so many BPF users also use clang, so this has

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Dominique Martinet
Nick Desaulniers Aug. 21, 2018, 8:09 a.m. UTC: > Thanks for noticing, and sending this patch. I'm happy to see others > testing with Clang. I noticed this too near the end of the day > https://github.com/ClangBuiltLinux/linux/issues/27. FWIW libbcc so many BPF users also use clang, so this has

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Joe Perches
On Tue, 2018-08-21 at 15:48 +0900, Masahiro Yamada wrote: > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > missed the fact that is included by Clang > as well as by GCC. > > Clang actually defines __GNUC__, __GNUC_MINOR__, __GNUC_PATCHLEVEL__ > and it looks like GCC

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Joe Perches
On Tue, 2018-08-21 at 15:48 +0900, Masahiro Yamada wrote: > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > missed the fact that is included by Clang > as well as by GCC. > > Clang actually defines __GNUC__, __GNUC_MINOR__, __GNUC_PATCHLEVEL__ > and it looks like GCC

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Nick Desaulniers
Thanks for noticing, and sending this patch. I'm happy to see others testing with Clang. I noticed this too near the end of the day https://github.com/ClangBuiltLinux/linux/issues/27. On Mon, Aug 20, 2018 at 11:48 PM Masahiro Yamada wrote: > > Commit cafa0010cd51 ("Raise the minimum required

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Nick Desaulniers
Thanks for noticing, and sending this patch. I'm happy to see others testing with Clang. I noticed this too near the end of the day https://github.com/ClangBuiltLinux/linux/issues/27. On Mon, Aug 20, 2018 at 11:48 PM Masahiro Yamada wrote: > > Commit cafa0010cd51 ("Raise the minimum required

[PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Masahiro Yamada
Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") missed the fact that is included by Clang as well as by GCC. Clang actually defines __GNUC__, __GNUC_MINOR__, __GNUC_PATCHLEVEL__ and it looks like GCC 4.2.1. $ scripts/gcc-version.sh -p clang 040201 If you try to build

[PATCH] compiler-gcc: get back Clang build

2018-08-21 Thread Masahiro Yamada
Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") missed the fact that is included by Clang as well as by GCC. Clang actually defines __GNUC__, __GNUC_MINOR__, __GNUC_PATCHLEVEL__ and it looks like GCC 4.2.1. $ scripts/gcc-version.sh -p clang 040201 If you try to build