Re: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2021-01-20 Thread Sai Prakash Ranjan
On 2021-01-21 00:18, Mathieu Poirier wrote: On Tue, Jan 19, 2021 at 08:36:22AM +, Al Grant wrote: Hi Sai, > From: saiprakash.ranjan=codeaurora@mg.codeaurora.org > Hi Mathieu, > > On 2021-01-19 01:53, Mathieu Poirier wrote: > > On Fri, Jan 15, 2021 at 11:16:24AM +0530, Sai Prakash Ranjan

Re: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2021-01-20 Thread Mathieu Poirier
On Tue, Jan 19, 2021 at 08:36:22AM +, Al Grant wrote: > Hi Sai, > > > From: saiprakash.ranjan=codeaurora@mg.codeaurora.org > > Hi Mathieu, > > > > On 2021-01-19 01:53, Mathieu Poirier wrote: > > > On Fri, Jan 15, 2021 at 11:16:24AM +0530, Sai Prakash Ranjan wrote: > > >> Hello Mathieu, Su

Re: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2021-01-19 Thread Sai Prakash Ranjan
Hi Al, On 2021-01-19 17:26, Al Grant wrote: From: Suzuki K Poulose On 1/19/21 9:51 AM, Sai Prakash Ranjan wrote: > Hi Al, > > On 2021-01-19 14:06, Al Grant wrote: >> Hi Sai, >> >>> From: saiprakash.ranjan=codeaurora@mg.codeaurora.org >>> Hi Mathieu, >>> >>> On 2021-01-19 01:53, Mathieu Poir

Re: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2021-01-19 Thread Sai Prakash Ranjan
Hi Suzuki, On 2021-01-19 16:03, Suzuki K Poulose wrote: On 1/19/21 9:51 AM, Sai Prakash Ranjan wrote: Hi Al, On 2021-01-19 14:06, Al Grant wrote: Hi Sai, From: saiprakash.ranjan=codeaurora@mg.codeaurora.org Hi Mathieu, On 2021-01-19 01:53, Mathieu Poirier wrote: > On Fri, Jan 15, 2021

RE: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2021-01-19 Thread Al Grant
> From: Suzuki K Poulose > On 1/19/21 9:51 AM, Sai Prakash Ranjan wrote: > > Hi Al, > > > > On 2021-01-19 14:06, Al Grant wrote: > >> Hi Sai, > >> > >>> From: saiprakash.ranjan=codeaurora@mg.codeaurora.org > >>> Hi Mathieu, > >>> > >>> On 2021-01-19 01:53, Mathieu Poirier wrote: > >>> > On Fri

Re: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2021-01-19 Thread Suzuki K Poulose
On 1/19/21 9:51 AM, Sai Prakash Ranjan wrote: Hi Al, On 2021-01-19 14:06, Al Grant wrote: Hi Sai, From: saiprakash.ranjan=codeaurora@mg.codeaurora.org Hi Mathieu, On 2021-01-19 01:53, Mathieu Poirier wrote: > On Fri, Jan 15, 2021 at 11:16:24AM +0530, Sai Prakash Ranjan wrote: >> Hello Ma

Re: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2021-01-19 Thread Sai Prakash Ranjan
Hi Al, On 2021-01-19 14:06, Al Grant wrote: Hi Sai, From: saiprakash.ranjan=codeaurora@mg.codeaurora.org Hi Mathieu, On 2021-01-19 01:53, Mathieu Poirier wrote: > On Fri, Jan 15, 2021 at 11:16:24AM +0530, Sai Prakash Ranjan wrote: >> Hello Mathieu, Suzuki >> >> On 2020-10-15 21:32, Mathie

Re: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2021-01-19 Thread Sai Prakash Ranjan
Hi Mathieu, On 2021-01-19 01:53, Mathieu Poirier wrote: On Fri, Jan 15, 2021 at 11:16:24AM +0530, Sai Prakash Ranjan wrote: Hello Mathieu, Suzuki On 2020-10-15 21:32, Mathieu Poirier wrote: > On Thu, Oct 15, 2020 at 06:15:22PM +0530, Sai Prakash Ranjan wrote: > > On production systems with ETM

RE: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2021-01-19 Thread Al Grant
Hi Sai, > From: saiprakash.ranjan=codeaurora@mg.codeaurora.org > Hi Mathieu, > > On 2021-01-19 01:53, Mathieu Poirier wrote: > > On Fri, Jan 15, 2021 at 11:16:24AM +0530, Sai Prakash Ranjan wrote: > >> Hello Mathieu, Suzuki > >> > >> On 2020-10-15 21:32, Mathieu Poirier wrote: > >> > On Thu,

Re: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2021-01-18 Thread Sai Prakash Ranjan
On 2021-01-18 20:17, Mattias Nissler wrote: On Fri, Jan 15, 2021 at 6:46 AM Sai Prakash Ranjan wrote: Hello Mathieu, Suzuki On 2020-10-15 21:32, Mathieu Poirier wrote: > On Thu, Oct 15, 2020 at 06:15:22PM +0530, Sai Prakash Ranjan wrote: >> On production systems with ETMs enabled, it is prefe

Re: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2021-01-18 Thread Mathieu Poirier
On Fri, Jan 15, 2021 at 11:16:24AM +0530, Sai Prakash Ranjan wrote: > Hello Mathieu, Suzuki > > On 2020-10-15 21:32, Mathieu Poirier wrote: > > On Thu, Oct 15, 2020 at 06:15:22PM +0530, Sai Prakash Ranjan wrote: > > > On production systems with ETMs enabled, it is preferred to > > > exclude kernel

Re: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2021-01-18 Thread Mattias Nissler
On Fri, Jan 15, 2021 at 6:46 AM Sai Prakash Ranjan wrote: > > Hello Mathieu, Suzuki > > On 2020-10-15 21:32, Mathieu Poirier wrote: > > On Thu, Oct 15, 2020 at 06:15:22PM +0530, Sai Prakash Ranjan wrote: > >> On production systems with ETMs enabled, it is preferred to > >> exclude kernel mode(NS E

Re: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2021-01-14 Thread Sai Prakash Ranjan
Hello Mathieu, Suzuki On 2020-10-15 21:32, Mathieu Poirier wrote: On Thu, Oct 15, 2020 at 06:15:22PM +0530, Sai Prakash Ranjan wrote: On production systems with ETMs enabled, it is preferred to exclude kernel mode(NS EL1) tracing for security concerns and support only userspace(NS EL0) tracing.

Re: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2020-10-16 Thread Suzuki Poulose
On 10/16/20 2:14 PM, Leo Yan wrote: On Fri, Oct 16, 2020 at 12:38:47PM +0100, Suzuki Kuruppassery Poulose wrote: [...] What happens to the sysfs mode of tracing? For that we would still need a config right to exclude kernel mode tracing completely. IIUC, sysfs mode and perf mode both can app

Re: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2020-10-16 Thread Leo Yan
On Fri, Oct 16, 2020 at 12:38:47PM +0100, Suzuki Kuruppassery Poulose wrote: [...] > > > What happens to the sysfs mode of tracing? For that we would still > > > need a config right to exclude kernel mode tracing completely. > > > > IIUC, sysfs mode and perf mode both can apply the same approach

Re: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2020-10-16 Thread Suzuki Poulose
On 10/16/20 10:24 AM, Leo Yan wrote: Hi Sai, On Fri, Oct 16, 2020 at 02:10:47PM +0530, Sai Prakash Ranjan wrote: Hi Leo, On 2020-10-16 12:54, Leo Yan wrote: On Thu, Oct 15, 2020 at 11:40:05PM -0700, Denis Nikitin wrote: Hi Mathieu, I think one of the use cases could be VMs. Is there isolati

Re: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2020-10-16 Thread Suzuki Poulose
On 10/16/20 7:40 AM, Denis Nikitin wrote: Hi Mathieu, I think one of the use cases could be VMs. Is there isolation between EL1 guest kernels which we can control from perf in a system wide mode? The proposed solution doesn't solve this for VMs anyway. It only excludes EL1 *OR* EL2, depending

Re: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2020-10-16 Thread Sai Prakash Ranjan
Hi Leo, On 2020-10-16 14:54, Leo Yan wrote: Hi Sai, On Fri, Oct 16, 2020 at 02:10:47PM +0530, Sai Prakash Ranjan wrote: Hi Leo, On 2020-10-16 12:54, Leo Yan wrote: > On Thu, Oct 15, 2020 at 11:40:05PM -0700, Denis Nikitin wrote: > > Hi Mathieu, > > > > I think one of the use cases could be VM

Re: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2020-10-16 Thread Leo Yan
Hi Sai, On Fri, Oct 16, 2020 at 02:10:47PM +0530, Sai Prakash Ranjan wrote: > Hi Leo, > > On 2020-10-16 12:54, Leo Yan wrote: > > On Thu, Oct 15, 2020 at 11:40:05PM -0700, Denis Nikitin wrote: > > > Hi Mathieu, > > > > > > I think one of the use cases could be VMs. > > > Is there isolation betwe

Re: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2020-10-16 Thread Sai Prakash Ranjan
Hi Leo, On 2020-10-16 12:54, Leo Yan wrote: On Thu, Oct 15, 2020 at 11:40:05PM -0700, Denis Nikitin wrote: Hi Mathieu, I think one of the use cases could be VMs. Is there isolation between EL1 guest kernels which we can control from perf in a system wide mode? Sorry for suddenly jumping in

Re: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2020-10-16 Thread Sai Prakash Ranjan
Hi Suzuki, On 2020-10-15 19:57, Suzuki K Poulose wrote: Hi Sai, On 10/15/2020 01:45 PM, Sai Prakash Ranjan wrote: On production systems with ETMs enabled, it is preferred to exclude kernel mode(NS EL1) tracing for security concerns and support only userspace(NS EL0) tracing. So provide an opti

Re: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2020-10-16 Thread Leo Yan
On Thu, Oct 15, 2020 at 11:40:05PM -0700, Denis Nikitin wrote: > Hi Mathieu, > > I think one of the use cases could be VMs. > Is there isolation between EL1 guest kernels which we can control from perf > in a system wide mode? Sorry for suddenly jumping in. For KVM, I think we need to implement

Re: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2020-10-15 Thread Mathieu Poirier
On Thu, Oct 15, 2020 at 06:15:22PM +0530, Sai Prakash Ranjan wrote: > On production systems with ETMs enabled, it is preferred to > exclude kernel mode(NS EL1) tracing for security concerns and > support only userspace(NS EL0) tracing. So provide an option > via kconfig to exclude kernel mode traci

Re: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2020-10-15 Thread Suzuki K Poulose
Hi Sai, On 10/15/2020 01:45 PM, Sai Prakash Ranjan wrote: On production systems with ETMs enabled, it is preferred to exclude kernel mode(NS EL1) tracing for security concerns and support only userspace(NS EL0) tracing. So provide an option via kconfig to exclude kernel mode tracing if it is req

[PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2020-10-15 Thread Sai Prakash Ranjan
On production systems with ETMs enabled, it is preferred to exclude kernel mode(NS EL1) tracing for security concerns and support only userspace(NS EL0) tracing. So provide an option via kconfig to exclude kernel mode tracing if it is required. This config is disabled by default and would not affec