Re: [PATCH] cpsw: Fix interrupt storm among other things

2013-01-30 Thread Mugunthan V N
Hi Antoniou On 1/30/2013 7:25 PM, Pantelis Antoniou wrote: Hi Mugunthan, On Jan 30, 2013, at 3:53 PM, Mugunthan V N wrote: On 1/30/2013 7:21 PM, Pantelis Antoniou wrote: Hi Vaibhav, On Jan 30, 2013, at 3:47 PM, Bedia, Vaibhav wrote: Hi Antoniou, On Wed, Jan 30, 2013 at 19:07:19, Pantelis

Re: [PATCH] cpsw: Fix interrupt storm among other things

2013-01-30 Thread Mugunthan V N
On 1/30/2013 7:25 PM, Pantelis Antoniou wrote: Hi Mugunthan, On Jan 30, 2013, at 3:53 PM, Mugunthan V N wrote: On 1/30/2013 7:21 PM, Pantelis Antoniou wrote: Hi Vaibhav, On Jan 30, 2013, at 3:47 PM, Bedia, Vaibhav wrote: Hi Antoniou, On Wed, Jan 30, 2013 at 19:07:19, Pantelis Antoniou wro

Re: [PATCH] cpsw: Fix interrupt storm among other things

2013-01-30 Thread Pantelis Antoniou
Hi Mugunthan, On Jan 30, 2013, at 3:53 PM, Mugunthan V N wrote: > On 1/30/2013 7:21 PM, Pantelis Antoniou wrote: >> Hi Vaibhav, >> >> On Jan 30, 2013, at 3:47 PM, Bedia, Vaibhav wrote: >> >>> Hi Antoniou, >>> >>> On Wed, Jan 30, 2013 at 19:07:19, Pantelis Antoniou wrote: Hi Vaibhav,

Re: [PATCH] cpsw: Fix interrupt storm among other things

2013-01-30 Thread Mugunthan V N
On 1/30/2013 7:21 PM, Pantelis Antoniou wrote: Hi Vaibhav, On Jan 30, 2013, at 3:47 PM, Bedia, Vaibhav wrote: Hi Antoniou, On Wed, Jan 30, 2013 at 19:07:19, Pantelis Antoniou wrote: Hi Vaibhav, On Jan 30, 2013, at 3:29 PM, Bedia, Vaibhav wrote: On Wed, Jan 30, 2013 at 18:14:30, Pantelis A

Re: [PATCH] cpsw: Fix interrupt storm among other things

2013-01-30 Thread Pantelis Antoniou
Hi Vaibhav, On Jan 30, 2013, at 3:47 PM, Bedia, Vaibhav wrote: > Hi Antoniou, > > On Wed, Jan 30, 2013 at 19:07:19, Pantelis Antoniou wrote: >> Hi Vaibhav, >> >> On Jan 30, 2013, at 3:29 PM, Bedia, Vaibhav wrote: >> >>> On Wed, Jan 30, 2013 at 18:14:30, Pantelis Antoniou wrote: Hi Vaibhav

RE: [PATCH] cpsw: Fix interrupt storm among other things

2013-01-30 Thread Bedia, Vaibhav
Hi Antoniou, On Wed, Jan 30, 2013 at 19:07:19, Pantelis Antoniou wrote: > Hi Vaibhav, > > On Jan 30, 2013, at 3:29 PM, Bedia, Vaibhav wrote: > > > On Wed, Jan 30, 2013 at 18:14:30, Pantelis Antoniou wrote: > >> Hi Vaibhav, > >> > >> On Jan 30, 2013, at 2:38 PM, Bedia, Vaibhav wrote: > >> > >>>

Re: [PATCH] cpsw: Fix interrupt storm among other things

2013-01-30 Thread Pantelis Antoniou
Hi Vaibhav, On Jan 30, 2013, at 3:29 PM, Bedia, Vaibhav wrote: > On Wed, Jan 30, 2013 at 18:14:30, Pantelis Antoniou wrote: >> Hi Vaibhav, >> >> On Jan 30, 2013, at 2:38 PM, Bedia, Vaibhav wrote: >> >>> On Wed, Jan 30, 2013 at 16:38:50, Pantelis Antoniou wrote: >>> [...] TBH I haven'

RE: [PATCH] cpsw: Fix interrupt storm among other things

2013-01-30 Thread Bedia, Vaibhav
On Wed, Jan 30, 2013 at 18:14:30, Pantelis Antoniou wrote: > Hi Vaibhav, > > On Jan 30, 2013, at 2:38 PM, Bedia, Vaibhav wrote: > > > On Wed, Jan 30, 2013 at 16:38:50, Pantelis Antoniou wrote: > > [...] > >> > >> TBH I haven't found a simple way to print out the silicon revision number. > >> Any

Re: [PATCH] cpsw: Fix interrupt storm among other things

2013-01-30 Thread Pantelis Antoniou
Hi Vaibhav, On Jan 30, 2013, at 2:38 PM, Bedia, Vaibhav wrote: > On Wed, Jan 30, 2013 at 16:38:50, Pantelis Antoniou wrote: > [...] >> >> TBH I haven't found a simple way to print out the silicon revision number. >> Anyone on the list know a quick and dirty method? >> > > You can dump the DEV

RE: [PATCH] cpsw: Fix interrupt storm among other things

2013-01-30 Thread Bedia, Vaibhav
On Wed, Jan 30, 2013 at 16:38:50, Pantelis Antoniou wrote: [...] > > TBH I haven't found a simple way to print out the silicon revision number. > Anyone on the list know a quick and dirty method? > You can dump the DEVICE_ID register @ 0x44e10600. Bits 31:28 should be 0 for PG1.0 and 1 for PG2.

Re: [PATCH] cpsw: Fix interrupt storm among other things

2013-01-30 Thread Pantelis Antoniou
Hi Mugunthan, On Jan 30, 2013, at 12:55 PM, Mugunthan V N wrote: > On 1/30/2013 3:06 PM, Pantelis Antoniou wrote: >> Hi, >> >> On Jan 30, 2013, at 11:03 AM, Mugunthan V N wrote: >> >>> On 1/30/2013 2:06 PM, Pantelis Antoniou wrote: Hi Mugunthan, On Jan 29, 2013, at 1:45 PM, Mugu

Re: [PATCH] cpsw: Fix interrupt storm among other things

2013-01-30 Thread Mugunthan V N
On 1/30/2013 3:06 PM, Pantelis Antoniou wrote: Hi, On Jan 30, 2013, at 11:03 AM, Mugunthan V N wrote: On 1/30/2013 2:06 PM, Pantelis Antoniou wrote: Hi Mugunthan, On Jan 29, 2013, at 1:45 PM, Mugunthan V N wrote: On 1/28/2013 6:41 PM, Pantelis Antoniou wrote: Fix interrupt storm on bone A

Re: [PATCH] cpsw: Fix interrupt storm among other things

2013-01-30 Thread Pantelis Antoniou
Hi, On Jan 30, 2013, at 11:03 AM, Mugunthan V N wrote: > On 1/30/2013 2:06 PM, Pantelis Antoniou wrote: >> Hi Mugunthan, >> >> On Jan 29, 2013, at 1:45 PM, Mugunthan V N wrote: >> >>> On 1/28/2013 6:41 PM, Pantelis Antoniou wrote: Fix interrupt storm on bone A4 cause by non-by-the-book int

Re: [PATCH] cpsw: Fix interrupt storm among other things

2013-01-30 Thread Mugunthan V N
On 1/30/2013 2:06 PM, Pantelis Antoniou wrote: Hi Mugunthan, On Jan 29, 2013, at 1:45 PM, Mugunthan V N wrote: On 1/28/2013 6:41 PM, Pantelis Antoniou wrote: Fix interrupt storm on bone A4 cause by non-by-the-book interrupt handling. While at it, added a non-NAPI mode (which is easier to debu

Re: [PATCH] cpsw: Fix interrupt storm among other things

2013-01-30 Thread Pantelis Antoniou
Hi Mugunthan, On Jan 29, 2013, at 1:45 PM, Mugunthan V N wrote: > On 1/28/2013 6:41 PM, Pantelis Antoniou wrote: >> Fix interrupt storm on bone A4 cause by non-by-the-book interrupt handling. >> While at it, added a non-NAPI mode (which is easier to debug), plus >> some general fixes. >> >> Sign

Re: [PATCH] cpsw: Fix interrupt storm among other things

2013-01-30 Thread Pantelis Antoniou
Hi Peter, On Jan 28, 2013, at 11:14 PM, Peter Korsgaard wrote: >> "Pantelis" == Pantelis Antoniou writes: > > 'among other things' is not a very descriptive commit message. > > Pantelis> Fix interrupt storm on bone A4 cause by non-by-the-book > Pantelis> interrupt handling. While at it, a

Re: [PATCH] cpsw: Fix interrupt storm among other things

2013-01-29 Thread Mugunthan V N
On 1/28/2013 6:41 PM, Pantelis Antoniou wrote: Fix interrupt storm on bone A4 cause by non-by-the-book interrupt handling. While at it, added a non-NAPI mode (which is easier to debug), plus some general fixes. Signed-off-by: Pantelis Antoniou --- Documentation/devicetree/bindings/net/cpsw.tx

Re: [PATCH] cpsw: Fix interrupt storm among other things

2013-01-28 Thread Peter Korsgaard
> "Pantelis" == Pantelis Antoniou writes: 'among other things' is not a very descriptive commit message. Pantelis> Fix interrupt storm on bone A4 cause by non-by-the-book Pantelis> interrupt handling. While at it, added a non-NAPI mode Pantelis> (which is easier to debug), plus some gene

Re: [PATCH] cpsw: Fix interrupt storm among other things

2013-01-28 Thread Richard Cochran
On Mon, Jan 28, 2013 at 08:40:25PM +0200, Pantelis Antoniou wrote: > > Speaking of which, I'm probably the original developer of the fec driver. BTW, as I mentioned, someone is converting fec to napi. Care to take a look to make sure it is done right? Thanks, Richard -- To unsubscribe from this

Re: [PATCH] cpsw: Fix interrupt storm among other things

2013-01-28 Thread Richard Cochran
On Mon, Jan 28, 2013 at 08:40:25PM +0200, Pantelis Antoniou wrote: > Hi Richard, > > Yes, I guess this was more of a drive-by patch dump - but people need this > to get PG2.0 silicon to work on am33xx. And what is PG2.0? > And no, I don't think having a non-NAPI code path is backwards, especiall

Re: [PATCH] cpsw: Fix interrupt storm among other things

2013-01-28 Thread Pantelis Antoniou
Hi Richard, Yes, I guess this was more of a drive-by patch dump - but people need this to get PG2.0 silicon to work on am33xx. On Jan 28, 2013, at 8:24 PM, Richard Cochran wrote: > On Mon, Jan 28, 2013 at 03:11:08PM +0200, Pantelis Antoniou wrote: >> Fix interrupt storm on bone A4 cause by non-

Re: [PATCH] cpsw: Fix interrupt storm among other things

2013-01-28 Thread Richard Cochran
On Mon, Jan 28, 2013 at 03:11:08PM +0200, Pantelis Antoniou wrote: > Fix interrupt storm on bone A4 cause by non-by-the-book interrupt handling. > While at it, added a non-NAPI mode (which is easier to debug), plus > some general fixes. This patch does not apply to net-next. When you do post to n

Re: [PATCH] cpsw: Fix interrupt storm among other things

2013-01-28 Thread Richard Cochran
On Mon, Jan 28, 2013 at 03:11:08PM +0200, Pantelis Antoniou wrote: > Fix interrupt storm on bone A4 cause by non-by-the-book interrupt handling. > While at it, added a non-NAPI mode (which is easier to debug), plus > some general fixes. I have a few issues with this patch: 1. This is a networking

[PATCH] cpsw: Fix interrupt storm among other things

2013-01-28 Thread Pantelis Antoniou
Fix interrupt storm on bone A4 cause by non-by-the-book interrupt handling. While at it, added a non-NAPI mode (which is easier to debug), plus some general fixes. Signed-off-by: Pantelis Antoniou --- Documentation/devicetree/bindings/net/cpsw.txt | 1 + drivers/net/ethernet/ti/cpsw.c