Re: [PATCH] cpufreq: nforce2: Remove meaningless return

2018-12-04 Thread Frank Lee
On Tue, Dec 4, 2018 at 4:46 PM Rafael J. Wysocki wrote: > > On Tue, Dec 4, 2018 at 2:15 AM Frank Lee wrote: > > > > On Mon, Dec 3, 2018 at 5:14 PM Rafael J. Wysocki wrote: > > > > > > On Fri, Nov 30, 2018 at 3:26 PM Yangtao Li wrote: > > > > > > > > In a function whose return type is void, retu

Re: [PATCH] cpufreq: nforce2: Remove meaningless return

2018-12-04 Thread Rafael J. Wysocki
On Tue, Dec 4, 2018 at 2:15 AM Frank Lee wrote: > > On Mon, Dec 3, 2018 at 5:14 PM Rafael J. Wysocki wrote: > > > > On Fri, Nov 30, 2018 at 3:26 PM Yangtao Li wrote: > > > > > > In a function whose return type is void, returning on the last line is > > > not required.So remove it.Also move the m

Re: [PATCH] cpufreq: nforce2: Remove meaningless return

2018-12-03 Thread Frank Lee
On Mon, Dec 3, 2018 at 5:14 PM Rafael J. Wysocki wrote: > > On Fri, Nov 30, 2018 at 3:26 PM Yangtao Li wrote: > > > > In a function whose return type is void, returning on the last line is > > not required.So remove it.Also move the module declaration to the end. > > The last piece is not reflect

Re: [PATCH] cpufreq: nforce2: Remove meaningless return

2018-12-03 Thread Rafael J. Wysocki
On Fri, Nov 30, 2018 at 3:26 PM Yangtao Li wrote: > > In a function whose return type is void, returning on the last line is > not required.So remove it.Also move the module declaration to the end. The last piece is not reflected by the subject. Also, why do you move the MODULE_ stuff around at

[PATCH] cpufreq: nforce2: Remove meaningless return

2018-11-30 Thread Yangtao Li
In a function whose return type is void, returning on the last line is not required.So remove it.Also move the module declaration to the end. Signed-off-by: Yangtao Li --- drivers/cpufreq/cpufreq-nforce2.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/cp