Re: [PATCH] crypto: testmgr: Allow different compression results

2018-04-20 Thread Herbert Xu
On Thu, Apr 19, 2018 at 01:58:40PM +0200, Jan Glauber wrote: > > Nice idea. Would a crypto_alloc_cipher("deflate", ...) pick the generic > implementation or how can we select it? For our ciphers we generally use the -generic suffix in the driver name. The compression algorithms seem to be all

Re: [PATCH] crypto: testmgr: Allow different compression results

2018-04-20 Thread Herbert Xu
On Thu, Apr 19, 2018 at 01:58:40PM +0200, Jan Glauber wrote: > > Nice idea. Would a crypto_alloc_cipher("deflate", ...) pick the generic > implementation or how can we select it? For our ciphers we generally use the -generic suffix in the driver name. The compression algorithms seem to be all

Re: [PATCH] crypto: testmgr: Allow different compression results

2018-04-20 Thread Herbert Xu
On Wed, Apr 11, 2018 at 08:28:32PM +0200, Jan Glauber wrote: > From: Mahipal Challa > > The following error is triggered by the ThunderX ZIP driver > if the testmanager is enabled: > > [ 199.069437] ThunderX-ZIP :03:00.0: Found ZIP device 0 177d:a01a on > Node 0 > [

Re: [PATCH] crypto: testmgr: Allow different compression results

2018-04-20 Thread Herbert Xu
On Wed, Apr 11, 2018 at 08:28:32PM +0200, Jan Glauber wrote: > From: Mahipal Challa > > The following error is triggered by the ThunderX ZIP driver > if the testmanager is enabled: > > [ 199.069437] ThunderX-ZIP :03:00.0: Found ZIP device 0 177d:a01a on > Node 0 > [ 199.073573] alg:

Re: [PATCH] crypto: testmgr: Allow different compression results

2018-04-19 Thread Jan Glauber
On Thu, Apr 19, 2018 at 11:42:11AM +0800, Herbert Xu wrote: > On Wed, Apr 11, 2018 at 08:28:32PM +0200, Jan Glauber wrote: > > > > @@ -1362,7 +1373,17 @@ static int test_comp(struct crypto_comp *tfm, > > goto out; > > } > > > > - if (dlen !=

Re: [PATCH] crypto: testmgr: Allow different compression results

2018-04-19 Thread Jan Glauber
On Thu, Apr 19, 2018 at 11:42:11AM +0800, Herbert Xu wrote: > On Wed, Apr 11, 2018 at 08:28:32PM +0200, Jan Glauber wrote: > > > > @@ -1362,7 +1373,17 @@ static int test_comp(struct crypto_comp *tfm, > > goto out; > > } > > > > - if (dlen !=

Re: [PATCH] crypto: testmgr: Allow different compression results

2018-04-18 Thread Herbert Xu
On Wed, Apr 11, 2018 at 08:28:32PM +0200, Jan Glauber wrote: > > @@ -1362,7 +1373,17 @@ static int test_comp(struct crypto_comp *tfm, > goto out; > } > > - if (dlen != ctemplate[i].outlen) { > + ilen = dlen; > + dlen =

Re: [PATCH] crypto: testmgr: Allow different compression results

2018-04-18 Thread Herbert Xu
On Wed, Apr 11, 2018 at 08:28:32PM +0200, Jan Glauber wrote: > > @@ -1362,7 +1373,17 @@ static int test_comp(struct crypto_comp *tfm, > goto out; > } > > - if (dlen != ctemplate[i].outlen) { > + ilen = dlen; > + dlen =

[PATCH] crypto: testmgr: Allow different compression results

2018-04-11 Thread Jan Glauber
From: Mahipal Challa The following error is triggered by the ThunderX ZIP driver if the testmanager is enabled: [ 199.069437] ThunderX-ZIP :03:00.0: Found ZIP device 0 177d:a01a on Node 0 [ 199.073573] alg: comp: Compression test 1 failed for deflate-generic: output

[PATCH] crypto: testmgr: Allow different compression results

2018-04-11 Thread Jan Glauber
From: Mahipal Challa The following error is triggered by the ThunderX ZIP driver if the testmanager is enabled: [ 199.069437] ThunderX-ZIP :03:00.0: Found ZIP device 0 177d:a01a on Node 0 [ 199.073573] alg: comp: Compression test 1 failed for deflate-generic: output len = 37 The reason