Re: [PATCH] csky: kprobe: fix unreachable code in simulate_blz32

Hi menglong, On Mon, Jan 11, 2021 at 10:25 PM wrote: > > From: Menglong Dong > > The type of 'val' is 'unsigned long' in simulate_blz32, so 'val < 0' > can't be true. > > When 'csky_insn_reg_get_val' fails, 'false' will be returned. We > can directly use its return value here. > > Fixes:

[PATCH] csky: kprobe: fix unreachable code in simulate_blz32

From: Menglong Dong The type of 'val' is 'unsigned long' in simulate_blz32, so 'val < 0' can't be true. When 'csky_insn_reg_get_val' fails, 'false' will be returned. We can directly use its return value here. Fixes: 33e53ae1ce41 ("csky: Add kprobes supported") Signed-off-by: Menglong Dong ---