Re: [PATCH] cxl/mem: Fix an error code in cxl_mem_mbox_get()

2021-02-16 Thread Dan Williams
On Tue, Feb 16, 2021 at 11:17 AM Dan Carpenter wrote: > > Smatch complains that sometimes when we return success we are holding > the mutex and sometimes we have released the mutex. It turns out that > the bug is a missing error code if the mbox is not ready. It should > return -EBUSY instead of

[PATCH] cxl/mem: Fix an error code in cxl_mem_mbox_get()

2021-02-16 Thread Dan Carpenter
Smatch complains that sometimes when we return success we are holding the mutex and sometimes we have released the mutex. It turns out that the bug is a missing error code if the mbox is not ready. It should return -EBUSY instead of success. Fixes: cc1967ac93ab ("cxl/mem: Find device capabilitie