Re: [PATCH] dma: tegra: enable/disable dma clock

2012-07-20 Thread Laxman Dewangan
On Friday 20 July 2012 12:10 PM, Vinod Koul wrote: On Fri, 2012-07-20 at 11:34 +0530, Laxman Dewangan wrote: On Friday 20 July 2012 11:32 AM, Vinod Koul wrote: for a start you can move these to .alloc_chan_resources and .free_chan_resources while doing a refcount. Further optimization can be

Re: [PATCH] dma: tegra: enable/disable dma clock

2012-07-20 Thread Vinod Koul
On Fri, 2012-07-20 at 11:34 +0530, Laxman Dewangan wrote: > On Friday 20 July 2012 11:32 AM, Vinod Koul wrote: > > On Wed, 2012-07-18 at 14:26 +0530, Laxman Dewangan wrote: > >> Enable the DMA clock when registering DMA driver and > >> disable clock when removing the DMA driver. > >> > >> The

Re: [PATCH] dma: tegra: enable/disable dma clock

2012-07-20 Thread Laxman Dewangan
On Friday 20 July 2012 11:32 AM, Vinod Koul wrote: On Wed, 2012-07-18 at 14:26 +0530, Laxman Dewangan wrote: Enable the DMA clock when registering DMA driver and disable clock when removing the DMA driver. The failure was observed on Tegra20 based system by Stephen Warren. However, it is

Re: [PATCH] dma: tegra: enable/disable dma clock

2012-07-20 Thread Vinod Koul
On Wed, 2012-07-18 at 14:26 +0530, Laxman Dewangan wrote: > Enable the DMA clock when registering DMA driver and > disable clock when removing the DMA driver. > > The failure was observed on Tegra20 based system by > Stephen Warren. However, it is working fine on tegra30 > based system and

Re: [PATCH] dma: tegra: enable/disable dma clock

2012-07-20 Thread Vinod Koul
On Wed, 2012-07-18 at 14:26 +0530, Laxman Dewangan wrote: Enable the DMA clock when registering DMA driver and disable clock when removing the DMA driver. The failure was observed on Tegra20 based system by Stephen Warren. However, it is working fine on tegra30 based system and probably

Re: [PATCH] dma: tegra: enable/disable dma clock

2012-07-20 Thread Laxman Dewangan
On Friday 20 July 2012 11:32 AM, Vinod Koul wrote: On Wed, 2012-07-18 at 14:26 +0530, Laxman Dewangan wrote: Enable the DMA clock when registering DMA driver and disable clock when removing the DMA driver. The failure was observed on Tegra20 based system by Stephen Warren. However, it is

Re: [PATCH] dma: tegra: enable/disable dma clock

2012-07-20 Thread Vinod Koul
On Fri, 2012-07-20 at 11:34 +0530, Laxman Dewangan wrote: On Friday 20 July 2012 11:32 AM, Vinod Koul wrote: On Wed, 2012-07-18 at 14:26 +0530, Laxman Dewangan wrote: Enable the DMA clock when registering DMA driver and disable clock when removing the DMA driver. The failure was

Re: [PATCH] dma: tegra: enable/disable dma clock

2012-07-20 Thread Laxman Dewangan
On Friday 20 July 2012 12:10 PM, Vinod Koul wrote: On Fri, 2012-07-20 at 11:34 +0530, Laxman Dewangan wrote: On Friday 20 July 2012 11:32 AM, Vinod Koul wrote: for a start you can move these to .alloc_chan_resources and .free_chan_resources while doing a refcount. Further optimization can be

[PATCH] dma: tegra: enable/disable dma clock

2012-07-18 Thread Laxman Dewangan
Enable the DMA clock when registering DMA driver and disable clock when removing the DMA driver. The failure was observed on Tegra20 based system by Stephen Warren. However, it is working fine on tegra30 based system and probably becasue uboot enable the clock on Tegra30. Signed-off-by: Laxman

[PATCH] dma: tegra: enable/disable dma clock

2012-07-18 Thread Laxman Dewangan
Enable the DMA clock when registering DMA driver and disable clock when removing the DMA driver. The failure was observed on Tegra20 based system by Stephen Warren. However, it is working fine on tegra30 based system and probably becasue uboot enable the clock on Tegra30. Signed-off-by: Laxman