Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-11 Thread Laura Abbott
On 12/08/2017 10:33 PM, Tobin C. Harding wrote: [Adding Laura] On Fri, Dec 08, 2017 at 06:18:45PM -0800, Joe Perches wrote: On Sat, 2017-12-09 at 12:27 +1100, Tobin C. Harding wrote: On Fri, Dec 08, 2017 at 01:22:37PM -0800, Joe Perches wrote: Outside of the documentation, what could be

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-11 Thread Laura Abbott
On 12/08/2017 10:33 PM, Tobin C. Harding wrote: [Adding Laura] On Fri, Dec 08, 2017 at 06:18:45PM -0800, Joe Perches wrote: On Sat, 2017-12-09 at 12:27 +1100, Tobin C. Harding wrote: On Fri, Dec 08, 2017 at 01:22:37PM -0800, Joe Perches wrote: Outside of the documentation, what could be

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-10 Thread Kees Cook
On Sat, Dec 9, 2017 at 3:48 AM, Dan Carpenter wrote: > On Fri, Dec 08, 2017 at 06:18:45PM -0800, Joe Perches wrote: >> On Sat, 2017-12-09 at 12:27 +1100, Tobin C. Harding wrote: >> > On Fri, Dec 08, 2017 at 01:22:37PM -0800, Joe Perches wrote: >> >> > > Outside of the

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-10 Thread Kees Cook
On Sat, Dec 9, 2017 at 3:48 AM, Dan Carpenter wrote: > On Fri, Dec 08, 2017 at 06:18:45PM -0800, Joe Perches wrote: >> On Sat, 2017-12-09 at 12:27 +1100, Tobin C. Harding wrote: >> > On Fri, Dec 08, 2017 at 01:22:37PM -0800, Joe Perches wrote: >> >> > > Outside of the documentation, what could be

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-09 Thread Dan Carpenter
On Fri, Dec 08, 2017 at 06:18:45PM -0800, Joe Perches wrote: > On Sat, 2017-12-09 at 12:27 +1100, Tobin C. Harding wrote: > > On Fri, Dec 08, 2017 at 01:22:37PM -0800, Joe Perches wrote: > > > > Outside of the documentation, what could be useful is for > > > someone to add a tool to verify %p

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-09 Thread Dan Carpenter
On Fri, Dec 08, 2017 at 06:18:45PM -0800, Joe Perches wrote: > On Sat, 2017-12-09 at 12:27 +1100, Tobin C. Harding wrote: > > On Fri, Dec 08, 2017 at 01:22:37PM -0800, Joe Perches wrote: > > > > Outside of the documentation, what could be useful is for > > > someone to add a tool to verify %p

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-08 Thread Tobin C. Harding
[Adding Laura] On Fri, Dec 08, 2017 at 06:18:45PM -0800, Joe Perches wrote: > On Sat, 2017-12-09 at 12:27 +1100, Tobin C. Harding wrote: > > On Fri, Dec 08, 2017 at 01:22:37PM -0800, Joe Perches wrote: > > > > Outside of the documentation, what could be useful is for > > > someone to add a tool

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-08 Thread Tobin C. Harding
[Adding Laura] On Fri, Dec 08, 2017 at 06:18:45PM -0800, Joe Perches wrote: > On Sat, 2017-12-09 at 12:27 +1100, Tobin C. Harding wrote: > > On Fri, Dec 08, 2017 at 01:22:37PM -0800, Joe Perches wrote: > > > > Outside of the documentation, what could be useful is for > > > someone to add a tool

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-08 Thread Joe Perches
On Sat, 2017-12-09 at 12:27 +1100, Tobin C. Harding wrote: > On Fri, Dec 08, 2017 at 01:22:37PM -0800, Joe Perches wrote: > > Outside of the documentation, what could be useful is for > > someone to add a tool to verify %p extension to > > the typeof address actually passed as an argument. > >

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-08 Thread Joe Perches
On Sat, 2017-12-09 at 12:27 +1100, Tobin C. Harding wrote: > On Fri, Dec 08, 2017 at 01:22:37PM -0800, Joe Perches wrote: > > Outside of the documentation, what could be useful is for > > someone to add a tool to verify %p extension to > > the typeof address actually passed as an argument. > >

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-08 Thread Tobin C. Harding
On Fri, Dec 08, 2017 at 01:22:37PM -0800, Joe Perches wrote: > On Fri, 2017-12-08 at 13:06 -0800, Kees Cook wrote: > > Well ... my sense is that lib/vsprintf.c should remain the canonical > > documentation. > > I agree. > > > Anyone working on the code has the docs all together in > > one file.

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-08 Thread Tobin C. Harding
On Fri, Dec 08, 2017 at 01:22:37PM -0800, Joe Perches wrote: > On Fri, 2017-12-08 at 13:06 -0800, Kees Cook wrote: > > Well ... my sense is that lib/vsprintf.c should remain the canonical > > documentation. > > I agree. > > > Anyone working on the code has the docs all together in > > one file.

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-08 Thread Joe Perches
On Fri, 2017-12-08 at 13:06 -0800, Kees Cook wrote: > Well ... my sense is that lib/vsprintf.c should remain the canonical > documentation. I agree. > Anyone working on the code has the docs all together in > one file. If it helps the .rst file to reformat the comments into > kernel-doc, that's

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-08 Thread Joe Perches
On Fri, 2017-12-08 at 13:06 -0800, Kees Cook wrote: > Well ... my sense is that lib/vsprintf.c should remain the canonical > documentation. I agree. > Anyone working on the code has the docs all together in > one file. If it helps the .rst file to reformat the comments into > kernel-doc, that's

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-08 Thread Kees Cook
On Thu, Dec 7, 2017 at 4:46 PM, Tobin C. Harding wrote: > On Thu, Dec 07, 2017 at 04:19:56PM -0800, Kees Cook wrote: >> On Thu, Dec 7, 2017 at 3:44 PM, Tobin C. Harding wrote: >> > Cheers Kees. FTR, changes to implement are: >> > >> > - Fix the capitalization of

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-08 Thread Kees Cook
On Thu, Dec 7, 2017 at 4:46 PM, Tobin C. Harding wrote: > On Thu, Dec 07, 2017 at 04:19:56PM -0800, Kees Cook wrote: >> On Thu, Dec 7, 2017 at 3:44 PM, Tobin C. Harding wrote: >> > Cheers Kees. FTR, changes to implement are: >> > >> > - Fix the capitalization of 'kernel'. >> >> I don't really

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-07 Thread Tobin C. Harding
On Thu, Dec 07, 2017 at 04:19:56PM -0800, Kees Cook wrote: > On Thu, Dec 7, 2017 at 3:44 PM, Tobin C. Harding wrote: > > Cheers Kees. FTR, changes to implement are: > > > > - Fix the capitalization of 'kernel'. > > I don't really have an opinion about which way is right. I

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-07 Thread Tobin C. Harding
On Thu, Dec 07, 2017 at 04:19:56PM -0800, Kees Cook wrote: > On Thu, Dec 7, 2017 at 3:44 PM, Tobin C. Harding wrote: > > Cheers Kees. FTR, changes to implement are: > > > > - Fix the capitalization of 'kernel'. > > I don't really have an opinion about which way is right. I personally > don't

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-07 Thread Kees Cook
On Thu, Dec 7, 2017 at 3:44 PM, Tobin C. Harding wrote: > Cheers Kees. FTR, changes to implement are: > > - Fix the capitalization of 'kernel'. I don't really have an opinion about which way is right. I personally don't capitalize it unless I speak about it as a single thing "The

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-07 Thread Kees Cook
On Thu, Dec 7, 2017 at 3:44 PM, Tobin C. Harding wrote: > Cheers Kees. FTR, changes to implement are: > > - Fix the capitalization of 'kernel'. I don't really have an opinion about which way is right. I personally don't capitalize it unless I speak about it as a single thing "The Linux Kernel".

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-07 Thread Tobin C. Harding
On Thu, Dec 07, 2017 at 04:01:46PM -0700, Jonathan Corbet wrote: > On Thu, 7 Dec 2017 14:50:42 -0800 > Kees Cook wrote: > > > > +These guides contain general information useful when writing kernel code. > > > + > > > +.. toctree:: > > > + :maxdepth: 1 > > > + > > > +

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-07 Thread Tobin C. Harding
On Thu, Dec 07, 2017 at 04:01:46PM -0700, Jonathan Corbet wrote: > On Thu, 7 Dec 2017 14:50:42 -0800 > Kees Cook wrote: > > > > +These guides contain general information useful when writing kernel code. > > > + > > > +.. toctree:: > > > + :maxdepth: 1 > > > + > > > + printk-formats > > >

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-07 Thread Tobin C. Harding
On Thu, Dec 07, 2017 at 02:50:42PM -0800, Kees Cook wrote: > On Tue, Dec 5, 2017 at 5:45 PM, Tobin C. Harding wrote: > > Documentation/printk-formats.txt is a candidate for conversion to > > ReStructuredText format. Some effort has already been made to do this > > conversion even

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-07 Thread Tobin C. Harding
On Thu, Dec 07, 2017 at 02:50:42PM -0800, Kees Cook wrote: > On Tue, Dec 5, 2017 at 5:45 PM, Tobin C. Harding wrote: > > Documentation/printk-formats.txt is a candidate for conversion to > > ReStructuredText format. Some effort has already been made to do this > > conversion even thought the

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-07 Thread Jonathan Corbet
On Thu, 7 Dec 2017 14:50:42 -0800 Kees Cook wrote: > > +These guides contain general information useful when writing kernel code. > > + > > +.. toctree:: > > + :maxdepth: 1 > > + > > + printk-formats > > I actually think this belongs in the kernel core API

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-07 Thread Jonathan Corbet
On Thu, 7 Dec 2017 14:50:42 -0800 Kees Cook wrote: > > +These guides contain general information useful when writing kernel code. > > + > > +.. toctree:: > > + :maxdepth: 1 > > + > > + printk-formats > > I actually think this belongs in the kernel core API documentation > list

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-07 Thread Kees Cook
On Tue, Dec 5, 2017 at 5:45 PM, Tobin C. Harding wrote: > Documentation/printk-formats.txt is a candidate for conversion to > ReStructuredText format. Some effort has already been made to do this > conversion even thought the suffix is currently .txt > > Changes required to

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-07 Thread Kees Cook
On Tue, Dec 5, 2017 at 5:45 PM, Tobin C. Harding wrote: > Documentation/printk-formats.txt is a candidate for conversion to > ReStructuredText format. Some effort has already been made to do this > conversion even thought the suffix is currently .txt > > Changes required to complete conversion >

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-06 Thread Tobin C. Harding
On Wed, Dec 06, 2017 at 04:39:58PM -0800, Randy Dunlap wrote: > On 12/06/2017 01:16 PM, Tobin C. Harding wrote: > > On Wed, Dec 06, 2017 at 10:18:49AM -0800, Randy Dunlap wrote: > > > > Thanks for your comments Randy. > > > > >>> Documentation/index.rst| 10 + > >>>

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-06 Thread Tobin C. Harding
On Wed, Dec 06, 2017 at 04:39:58PM -0800, Randy Dunlap wrote: > On 12/06/2017 01:16 PM, Tobin C. Harding wrote: > > On Wed, Dec 06, 2017 at 10:18:49AM -0800, Randy Dunlap wrote: > > > > Thanks for your comments Randy. > > > > >>> Documentation/index.rst| 10 + > >>>

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-06 Thread Randy Dunlap
On 12/06/2017 01:16 PM, Tobin C. Harding wrote: > On Wed, Dec 06, 2017 at 10:18:49AM -0800, Randy Dunlap wrote: > > Thanks for your comments Randy. > >>> Documentation/index.rst| 10 + >>> .../{printk-formats.txt => printk-formats.rst} | 295 >>>

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-06 Thread Randy Dunlap
On 12/06/2017 01:16 PM, Tobin C. Harding wrote: > On Wed, Dec 06, 2017 at 10:18:49AM -0800, Randy Dunlap wrote: > > Thanks for your comments Randy. > >>> Documentation/index.rst| 10 + >>> .../{printk-formats.txt => printk-formats.rst} | 295 >>>

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-06 Thread Tobin C. Harding
On Wed, Dec 06, 2017 at 10:18:49AM -0800, Randy Dunlap wrote: > On 12/05/2017 05:45 PM, Tobin C. Harding wrote: > > Documentation/printk-formats.txt is a candidate for conversion to > > ReStructuredText format. Some effort has already been made to do this > > conversion even thought the suffix is

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-06 Thread Tobin C. Harding
On Wed, Dec 06, 2017 at 10:18:49AM -0800, Randy Dunlap wrote: > On 12/05/2017 05:45 PM, Tobin C. Harding wrote: > > Documentation/printk-formats.txt is a candidate for conversion to > > ReStructuredText format. Some effort has already been made to do this > > conversion even thought the suffix is

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-06 Thread Tobin C. Harding
On Wed, Dec 06, 2017 at 11:23:25AM -0700, Jonathan Corbet wrote: > On Wed, 6 Dec 2017 12:45:29 +1100 > "Tobin C. Harding" wrote: > > > Documentation/printk-formats.txt is a candidate for conversion to > > ReStructuredText format. Some effort has already been made to do this > >

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-06 Thread Tobin C. Harding
On Wed, Dec 06, 2017 at 11:23:25AM -0700, Jonathan Corbet wrote: > On Wed, 6 Dec 2017 12:45:29 +1100 > "Tobin C. Harding" wrote: > > > Documentation/printk-formats.txt is a candidate for conversion to > > ReStructuredText format. Some effort has already been made to do this > > conversion even

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-06 Thread Tobin C. Harding
On Wed, Dec 06, 2017 at 10:18:49AM -0800, Randy Dunlap wrote: Thanks for your comments Randy. > On 12/05/2017 05:45 PM, Tobin C. Harding wrote: > > Documentation/printk-formats.txt is a candidate for conversion to > > ReStructuredText format. Some effort has already been made to do this > >

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-06 Thread Tobin C. Harding
On Wed, Dec 06, 2017 at 10:18:49AM -0800, Randy Dunlap wrote: Thanks for your comments Randy. > On 12/05/2017 05:45 PM, Tobin C. Harding wrote: > > Documentation/printk-formats.txt is a candidate for conversion to > > ReStructuredText format. Some effort has already been made to do this > >

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-06 Thread Jonathan Corbet
On Wed, 6 Dec 2017 12:45:29 +1100 "Tobin C. Harding" wrote: > Documentation/printk-formats.txt is a candidate for conversion to > ReStructuredText format. Some effort has already been made to do this > conversion even thought the suffix is currently .txt > > Changes required to

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-06 Thread Jonathan Corbet
On Wed, 6 Dec 2017 12:45:29 +1100 "Tobin C. Harding" wrote: > Documentation/printk-formats.txt is a candidate for conversion to > ReStructuredText format. Some effort has already been made to do this > conversion even thought the suffix is currently .txt > > Changes required to complete

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-06 Thread Randy Dunlap
On 12/05/2017 05:45 PM, Tobin C. Harding wrote: > Documentation/printk-formats.txt is a candidate for conversion to > ReStructuredText format. Some effort has already been made to do this > conversion even thought the suffix is currently .txt > > Changes required to complete conversion > > - Add

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-06 Thread Randy Dunlap
On 12/05/2017 05:45 PM, Tobin C. Harding wrote: > Documentation/printk-formats.txt is a candidate for conversion to > ReStructuredText format. Some effort has already been made to do this > conversion even thought the suffix is currently .txt > > Changes required to complete conversion > > - Add

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-06 Thread Randy Dunlap
On 12/05/2017 11:35 PM, Joe Perches wrote: > On Wed, 2017-12-06 at 08:11 +0100, Markus Heiser wrote: >>> Am 06.12.2017 um 02:45 schrieb Tobin C. Harding : >>> Documentation/printk-formats.txt is a candidate for conversion to >>> ReStructuredText format. Some effort has already been

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-06 Thread Randy Dunlap
On 12/05/2017 11:35 PM, Joe Perches wrote: > On Wed, 2017-12-06 at 08:11 +0100, Markus Heiser wrote: >>> Am 06.12.2017 um 02:45 schrieb Tobin C. Harding : >>> Documentation/printk-formats.txt is a candidate for conversion to >>> ReStructuredText format. Some effort has already been made to do this

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-05 Thread Joe Perches
On Wed, 2017-12-06 at 08:11 +0100, Markus Heiser wrote: > > Am 06.12.2017 um 02:45 schrieb Tobin C. Harding : > > Documentation/printk-formats.txt is a candidate for conversion to > > ReStructuredText format. Some effort has already been made to do this > > conversion even thought

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-05 Thread Joe Perches
On Wed, 2017-12-06 at 08:11 +0100, Markus Heiser wrote: > > Am 06.12.2017 um 02:45 schrieb Tobin C. Harding : > > Documentation/printk-formats.txt is a candidate for conversion to > > ReStructuredText format. Some effort has already been made to do this > > conversion even thought the suffix is

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-05 Thread Markus Heiser
> Am 06.12.2017 um 02:45 schrieb Tobin C. Harding : > > Documentation/printk-formats.txt is a candidate for conversion to > ReStructuredText format. Some effort has already been made to do this > conversion even thought the suffix is currently .txt > > Changes required to

Re: [PATCH] doc: convert printk-formats.txt to rst

2017-12-05 Thread Markus Heiser
> Am 06.12.2017 um 02:45 schrieb Tobin C. Harding : > > Documentation/printk-formats.txt is a candidate for conversion to > ReStructuredText format. Some effort has already been made to do this > conversion even thought the suffix is currently .txt > > Changes required to complete conversion >

[PATCH] doc: convert printk-formats.txt to rst

2017-12-05 Thread Tobin C. Harding
Documentation/printk-formats.txt is a candidate for conversion to ReStructuredText format. Some effort has already been made to do this conversion even thought the suffix is currently .txt Changes required to complete conversion - Add double backticks where needed. - Add entry to

[PATCH] doc: convert printk-formats.txt to rst

2017-12-05 Thread Tobin C. Harding
Documentation/printk-formats.txt is a candidate for conversion to ReStructuredText format. Some effort has already been made to do this conversion even thought the suffix is currently .txt Changes required to complete conversion - Add double backticks where needed. - Add entry to