Re: [PATCH] drivers/crypto/nx: Add CRC and validation support for nx842

On Wed, Sep 23, 2015 at 5:54 AM, Herbert Xu wrote: > On Tue, Sep 22, 2015 at 11:08:22AM -0400, Dan Streetman wrote: >> >> you think we should just strip out the 842-nx alignment/sizing code >> and change it to fallback to the sw driver? > > Right, if the only intended user can provide aligned

Re: [PATCH] drivers/crypto/nx: Add CRC and validation support for nx842

On Wed, Sep 23, 2015 at 5:54 AM, Herbert Xu wrote: > On Tue, Sep 22, 2015 at 11:08:22AM -0400, Dan Streetman wrote: >> >> you think we should just strip out the 842-nx alignment/sizing code >> and change it to fallback to the sw driver? > > Right, if the only intended

Re: [PATCH] drivers/crypto/nx: Add CRC and validation support for nx842

On Tue, Sep 22, 2015 at 11:08:22AM -0400, Dan Streetman wrote: > > you think we should just strip out the 842-nx alignment/sizing code > and change it to fallback to the sw driver? Right, if the only intended user can provide aligned input then by all means make the unaligned case use the

Re: [PATCH] drivers/crypto/nx: Add CRC and validation support for nx842

On Tue, Sep 22, 2015 at 11:08:22AM -0400, Dan Streetman wrote: > > you think we should just strip out the 842-nx alignment/sizing code > and change it to fallback to the sw driver? Right, if the only intended user can provide aligned input then by all means make the unaligned case use the

Re: [PATCH] drivers/crypto/nx: Add CRC and validation support for nx842

On Tue, Sep 22, 2015 at 10:42 AM, Herbert Xu wrote: > On Tue, Sep 22, 2015 at 10:39:53AM -0400, Dan Streetman wrote: >> >> hmm, that's true, and that would simplify the code a lot! No need for >> the header anymore. But, since the sw driver is sooo much slower, it >> would be important to be

Re: [PATCH] drivers/crypto/nx: Add CRC and validation support for nx842

On Tue, Sep 22, 2015 at 10:39:53AM -0400, Dan Streetman wrote: > > hmm, that's true, and that would simplify the code a lot! No need for > the header anymore. But, since the sw driver is sooo much slower, it > would be important to be able to communicate the alignment and size > limits to the

Re: [PATCH] drivers/crypto/nx: Add CRC and validation support for nx842

On Tue, Sep 22, 2015 at 8:21 AM, Herbert Xu wrote: > On Mon, Sep 21, 2015 at 11:21:14AM -0400, Dan Streetman wrote: >> >> As far as the hw and sw drivers producing the exact same output, I >> don't think that's possible with the current hw and sw drivers, >> because the hw driver may have to add

Re: [PATCH] drivers/crypto/nx: Add CRC and validation support for nx842

On Mon, Sep 21, 2015 at 11:21:14AM -0400, Dan Streetman wrote: > > As far as the hw and sw drivers producing the exact same output, I > don't think that's possible with the current hw and sw drivers, > because the hw driver may have to add a header to the actual byte > stream that the hw creates,

Re: [PATCH] drivers/crypto/nx: Add CRC and validation support for nx842

On Tue, Sep 22, 2015 at 10:42 AM, Herbert Xu wrote: > On Tue, Sep 22, 2015 at 10:39:53AM -0400, Dan Streetman wrote: >> >> hmm, that's true, and that would simplify the code a lot! No need for >> the header anymore. But, since the sw driver is sooo much slower, it

Re: [PATCH] drivers/crypto/nx: Add CRC and validation support for nx842

On Tue, Sep 22, 2015 at 10:39:53AM -0400, Dan Streetman wrote: > > hmm, that's true, and that would simplify the code a lot! No need for > the header anymore. But, since the sw driver is sooo much slower, it > would be important to be able to communicate the alignment and size > limits to the

Re: [PATCH] drivers/crypto/nx: Add CRC and validation support for nx842

On Mon, Sep 21, 2015 at 11:21:14AM -0400, Dan Streetman wrote: > > As far as the hw and sw drivers producing the exact same output, I > don't think that's possible with the current hw and sw drivers, > because the hw driver may have to add a header to the actual byte > stream that the hw creates,

Re: [PATCH] drivers/crypto/nx: Add CRC and validation support for nx842

On Tue, Sep 22, 2015 at 8:21 AM, Herbert Xu wrote: > On Mon, Sep 21, 2015 at 11:21:14AM -0400, Dan Streetman wrote: >> >> As far as the hw and sw drivers producing the exact same output, I >> don't think that's possible with the current hw and sw drivers, >> because

Re: [PATCH] drivers/crypto/nx: Add CRC and validation support for nx842

On Mon, Sep 21, 2015 at 10:26 AM, Herbert Xu wrote: > On Sat, Sep 19, 2015 at 05:02:42PM -0700, Haren Myneni wrote: >> Hi, >> >> This patch allows nx842 coprocessor to add CRC for compression and >> check the computed CRC value for uncompression. Please let me know >> if you have any comments. >>

Re: [PATCH] drivers/crypto/nx: Add CRC and validation support for nx842

On Sat, Sep 19, 2015 at 05:02:42PM -0700, Haren Myneni wrote: > Hi, > > This patch allows nx842 coprocessor to add CRC for compression and > check the computed CRC value for uncompression. Please let me know > if you have any comments. > > Thanks > Haren > > commit

Re: [PATCH] drivers/crypto/nx: Add CRC and validation support for nx842

On Mon, Sep 21, 2015 at 10:26 AM, Herbert Xu wrote: > On Sat, Sep 19, 2015 at 05:02:42PM -0700, Haren Myneni wrote: >> Hi, >> >> This patch allows nx842 coprocessor to add CRC for compression and >> check the computed CRC value for uncompression. Please let me know >>

Re: [PATCH] drivers/crypto/nx: Add CRC and validation support for nx842

On Sat, Sep 19, 2015 at 05:02:42PM -0700, Haren Myneni wrote: > Hi, > > This patch allows nx842 coprocessor to add CRC for compression and > check the computed CRC value for uncompression. Please let me know > if you have any comments. > > Thanks > Haren > > commit

[PATCH] drivers/crypto/nx: Add CRC and validation support for nx842

Hi, This patch allows nx842 coprocessor to add CRC for compression and check the computed CRC value for uncompression. Please let me know if you have any comments. Thanks Haren commit d0b34d2e3ed41e7ec2afdbd654f0dd7716e4d4c0 Author: Haren Myneni Date: Sat Sep 12 01:20:51 2015 -0700

[PATCH] drivers/crypto/nx: Add CRC and validation support for nx842

Hi, This patch allows nx842 coprocessor to add CRC for compression and check the computed CRC value for uncompression. Please let me know if you have any comments. Thanks Haren commit d0b34d2e3ed41e7ec2afdbd654f0dd7716e4d4c0 Author: Haren Myneni Date: Sat Sep 12 01:20:51