Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon

2013-04-07 Thread Chen Gang
On 2013年04月07日 19:24, Paul Menzel wrote: > do you know if this cause any problems? Did you find this reading the > code or by using some tools? sorry, I do not know if this can cause any problems. for this issue, I did not find it by reading code. I find it by using compiler warnings with

Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon

2013-04-07 Thread Paul Menzel
Dear Chen, Am Mittwoch, den 27.03.2013, 15:23 +0800 schrieb Chen Gang: > need remove semicolon, or always return true. do you know if this cause any problems? Did you find this reading the code or by using some tools? > Signed-off-by: Chen Gang > --- >

Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon

2013-04-07 Thread Paul Menzel
Dear Chen, Am Mittwoch, den 27.03.2013, 15:23 +0800 schrieb Chen Gang: need remove semicolon, or always return true. do you know if this cause any problems? Did you find this reading the code or by using some tools? Signed-off-by: Chen Gang gang.c...@asianux.com ---

Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon

2013-04-07 Thread Chen Gang
On 2013年04月07日 19:24, Paul Menzel wrote: do you know if this cause any problems? Did you find this reading the code or by using some tools? sorry, I do not know if this can cause any problems. for this issue, I did not find it by reading code. I find it by using compiler warnings with

Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon

2013-04-06 Thread Chen Gang
thank you very much for your reply, firstly. On 2013年04月07日 12:09, Joe Perches wrote: > On Sun, 2013-04-07 at 11:57 +0800, Chen Gang wrote: >> > On 2013年04月07日 11:49, Greg KH wrote: >>> > > On Sun, Apr 07, 2013 at 09:03:55AM +0800, Chen Gang wrote: > >> Hello Greg KH: > >> when

Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon

2013-04-06 Thread Joe Perches
On Sun, 2013-04-07 at 11:57 +0800, Chen Gang wrote: > On 2013年04月07日 11:49, Greg KH wrote: > > On Sun, Apr 07, 2013 at 09:03:55AM +0800, Chen Gang wrote: > >> Hello Greg KH: > >> when you have time, can you help to check this patch whether OK ? > > No. > Why ? does it also need a test ??

Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon

2013-04-06 Thread Chen Gang
On 2013年04月07日 11:49, Greg KH wrote: > On Sun, Apr 07, 2013 at 09:03:55AM +0800, Chen Gang wrote: >> Hello Greg KH: >> >> when you have time, can you help to check this patch whether OK ? > > No. > > Why ? does it also need a test ?? -- Chen Gang Asianux Corporation -- To unsubscribe

Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon

2013-04-06 Thread Greg KH
On Sun, Apr 07, 2013 at 09:03:55AM +0800, Chen Gang wrote: > Hello Greg KH: > > when you have time, can you help to check this patch whether OK ? No. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon

2013-04-06 Thread Chen Gang
Hello Greg KH: when you have time, can you help to check this patch whether OK ? thanks. gchen. On 2013年04月03日 16:01, Chen Gang wrote: > Hello maintainers: > > when you have time, please help to check this patch whether is OK. > > thanks. > > gchen. > > > On 2013年03月27日 15:23,

Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon

2013-04-06 Thread Chen Gang
Hello Greg KH: when you have time, can you help to check this patch whether OK ? thanks. gchen. On 2013年04月03日 16:01, Chen Gang wrote: Hello maintainers: when you have time, please help to check this patch whether is OK. thanks. gchen. On 2013年03月27日 15:23, Chen Gang

Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon

2013-04-06 Thread Greg KH
On Sun, Apr 07, 2013 at 09:03:55AM +0800, Chen Gang wrote: Hello Greg KH: when you have time, can you help to check this patch whether OK ? No. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon

2013-04-06 Thread Chen Gang
On 2013年04月07日 11:49, Greg KH wrote: On Sun, Apr 07, 2013 at 09:03:55AM +0800, Chen Gang wrote: Hello Greg KH: when you have time, can you help to check this patch whether OK ? No. Why ? does it also need a test ?? -- Chen Gang Asianux Corporation -- To unsubscribe from this

Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon

2013-04-06 Thread Joe Perches
On Sun, 2013-04-07 at 11:57 +0800, Chen Gang wrote: On 2013年04月07日 11:49, Greg KH wrote: On Sun, Apr 07, 2013 at 09:03:55AM +0800, Chen Gang wrote: Hello Greg KH: when you have time, can you help to check this patch whether OK ? No. Why ? does it also need a test ?? Greg's not the

Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon

2013-04-06 Thread Chen Gang
thank you very much for your reply, firstly. On 2013年04月07日 12:09, Joe Perches wrote: On Sun, 2013-04-07 at 11:57 +0800, Chen Gang wrote: On 2013年04月07日 11:49, Greg KH wrote: On Sun, Apr 07, 2013 at 09:03:55AM +0800, Chen Gang wrote: Hello Greg KH: when you have time, can you

Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon

2013-04-03 Thread Chen Gang
Hello maintainers: when you have time, please help to check this patch whether is OK. thanks. gchen. On 2013年03月27日 15:23, Chen Gang wrote: > > need remove semicolon, or always return true. > > Signed-off-by: Chen Gang > --- > drivers/gpu/drm/nouveau/nv50_display.c |2 +- > 1

Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon

2013-04-03 Thread Chen Gang
Hello maintainers: when you have time, please help to check this patch whether is OK. thanks. gchen. On 2013年03月27日 15:23, Chen Gang wrote: need remove semicolon, or always return true. Signed-off-by: Chen Gang gang.c...@asianux.com --- drivers/gpu/drm/nouveau/nv50_display.c |

[PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon

2013-03-27 Thread Chen Gang
need remove semicolon, or always return true. Signed-off-by: Chen Gang --- drivers/gpu/drm/nouveau/nv50_display.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c index 7f0e6c3..1ddc03e

[PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon

2013-03-27 Thread Chen Gang
need remove semicolon, or always return true. Signed-off-by: Chen Gang gang.c...@asianux.com --- drivers/gpu/drm/nouveau/nv50_display.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c