Re: [PATCH] drivers/net/usb/r8152 fix broken rx checksums

2016-10-30 Thread Paul Bolle
On Sun, 2016-10-30 at 17:22 -0400, David Miller wrote: >         3) "Fix broken RX checksums."  Commit header lines and commit >    messages are proper English, therefore sentences should >    begin with a capitalized letter and end with a period. Commit messages should be proper

Re: [PATCH] drivers/net/usb/r8152 fix broken rx checksums

2016-10-30 Thread Paul Bolle
On Sun, 2016-10-30 at 17:22 -0400, David Miller wrote: >         3) "Fix broken RX checksums."  Commit header lines and commit >    messages are proper English, therefore sentences should >    begin with a capitalized letter and end with a period. Commit messages should be proper

Re: [PATCH] drivers/net/usb/r8152 fix broken rx checksums

2016-10-30 Thread David Miller
From: Mark Lord Date: Wed, 26 Oct 2016 18:36:57 -0400 > Patch attached (to deal with buggy mailer) and also below for review. Please make your mailer work properly so that you can submit patches properly which work inline, just like every other developer does for the kernel.

Re: [PATCH] drivers/net/usb/r8152 fix broken rx checksums

2016-10-30 Thread David Miller
From: Mark Lord Date: Wed, 26 Oct 2016 18:36:57 -0400 > Patch attached (to deal with buggy mailer) and also below for review. Please make your mailer work properly so that you can submit patches properly which work inline, just like every other developer does for the kernel. Also please format

Re: [PATCH] drivers/net/usb/r8152 fix broken rx checksums

2016-10-26 Thread Mark Lord
On 16-10-26 06:36 PM, Mark Lord wrote: The r8152 driver has been broken since (approx) 3.6.16, Correction: broken since 3.16.xx. when support was added for hardware rx checksum on newer chip versions. Symptoms include random segfaults and silent data corruption over NFS. This does not work

Re: [PATCH] drivers/net/usb/r8152 fix broken rx checksums

2016-10-26 Thread Mark Lord
On 16-10-26 06:36 PM, Mark Lord wrote: The r8152 driver has been broken since (approx) 3.6.16, Correction: broken since 3.16.xx. when support was added for hardware rx checksum on newer chip versions. Symptoms include random segfaults and silent data corruption over NFS. This does not work

[PATCH] drivers/net/usb/r8152 fix broken rx checksums

2016-10-26 Thread Mark Lord
The r8152 driver has been broken since (approx) 3.6.16, when support was added for hardware rx checksum on newer chip versions. Symptoms include random segfaults and silent data corruption over NFS. This does not work on the VER_02 dongle I have here when used with a slow embedded system CPU.

[PATCH] drivers/net/usb/r8152 fix broken rx checksums

2016-10-26 Thread Mark Lord
The r8152 driver has been broken since (approx) 3.6.16, when support was added for hardware rx checksum on newer chip versions. Symptoms include random segfaults and silent data corruption over NFS. This does not work on the VER_02 dongle I have here when used with a slow embedded system CPU.