Re: [PATCH] drivers/pinctrl: grab default handles from device core

2012-12-12 Thread Rafael J. Wysocki
On Wednesday, December 12, 2012 08:56:41 PM Linus Walleij wrote: > On Tue, Dec 11, 2012 at 7:13 PM, Greg Kroah-Hartman > wrote: > > On Tue, Dec 11, 2012 at 02:40:46PM +0100, Linus Walleij wrote: > >> diff --git a/include/linux/device.h b/include/linux/device.h > > >> +#ifdef CONFIG_PINCTRL > >>

Re: [PATCH] drivers/pinctrl: grab default handles from device core

2012-12-12 Thread Linus Walleij
On Wed, Dec 12, 2012 at 12:58 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: >> > +#ifdef CONFIG_PINCTRL >> > + struct dev_pin_info pins; >> > +#endif > can do do not put ifdef in the struct as if will force us to put ifdef in the > c code too instead of just use a inline function Oh, I'm

Re: [PATCH] drivers/pinctrl: grab default handles from device core

2012-12-12 Thread Linus Walleij
On Tue, Dec 11, 2012 at 7:13 PM, Greg Kroah-Hartman wrote: > On Tue, Dec 11, 2012 at 02:40:46PM +0100, Linus Walleij wrote: >> diff --git a/include/linux/device.h b/include/linux/device.h >> +#ifdef CONFIG_PINCTRL >> + struct dev_pin_info pins; >> +#endif > > Can't you just make this a *

Re: [PATCH] drivers/pinctrl: grab default handles from device core

2012-12-12 Thread Jean-Christophe PLAGNIOL-VILLARD
On 10:13 Tue 11 Dec , Greg Kroah-Hartman wrote: > On Tue, Dec 11, 2012 at 02:40:46PM +0100, Linus Walleij wrote: > > diff --git a/include/linux/device.h b/include/linux/device.h > > index 86ef6ab..dc399ab 100644 > > --- a/include/linux/device.h > > +++ b/include/linux/device.h > > @@ -21,6

Re: [PATCH] drivers/pinctrl: grab default handles from device core

2012-12-12 Thread Jean-Christophe PLAGNIOL-VILLARD
On 10:13 Tue 11 Dec , Greg Kroah-Hartman wrote: On Tue, Dec 11, 2012 at 02:40:46PM +0100, Linus Walleij wrote: diff --git a/include/linux/device.h b/include/linux/device.h index 86ef6ab..dc399ab 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -21,6 +21,7 @@

Re: [PATCH] drivers/pinctrl: grab default handles from device core

2012-12-12 Thread Linus Walleij
On Tue, Dec 11, 2012 at 7:13 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Tue, Dec 11, 2012 at 02:40:46PM +0100, Linus Walleij wrote: diff --git a/include/linux/device.h b/include/linux/device.h +#ifdef CONFIG_PINCTRL + struct dev_pin_info pins; +#endif Can't you

Re: [PATCH] drivers/pinctrl: grab default handles from device core

2012-12-12 Thread Linus Walleij
On Wed, Dec 12, 2012 at 12:58 PM, Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com wrote: +#ifdef CONFIG_PINCTRL + struct dev_pin_info pins; +#endif can do do not put ifdef in the struct as if will force us to put ifdef in the c code too instead of just use a inline function

Re: [PATCH] drivers/pinctrl: grab default handles from device core

2012-12-12 Thread Rafael J. Wysocki
On Wednesday, December 12, 2012 08:56:41 PM Linus Walleij wrote: On Tue, Dec 11, 2012 at 7:13 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Tue, Dec 11, 2012 at 02:40:46PM +0100, Linus Walleij wrote: diff --git a/include/linux/device.h b/include/linux/device.h +#ifdef

Re: [PATCH] drivers/pinctrl: grab default handles from device core

2012-12-11 Thread Greg Kroah-Hartman
On Tue, Dec 11, 2012 at 02:40:46PM +0100, Linus Walleij wrote: > diff --git a/include/linux/device.h b/include/linux/device.h > index 86ef6ab..dc399ab 100644 > --- a/include/linux/device.h > +++ b/include/linux/device.h > @@ -21,6 +21,7 @@ > #include > #include > #include > +#include >

[PATCH] drivers/pinctrl: grab default handles from device core

2012-12-11 Thread Linus Walleij
From: Linus Walleij This makes the device core auto-grab the pinctrl handle and set the "default" (PINCTRL_STATE_DEFAULT) state for every device that is present in the device model right before probe. This will account for the lion's share of embedded silicon devcies. A modification of the

[PATCH] drivers/pinctrl: grab default handles from device core

2012-12-11 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org This makes the device core auto-grab the pinctrl handle and set the default (PINCTRL_STATE_DEFAULT) state for every device that is present in the device model right before probe. This will account for the lion's share of embedded silicon devcies. A

Re: [PATCH] drivers/pinctrl: grab default handles from device core

2012-12-11 Thread Greg Kroah-Hartman
On Tue, Dec 11, 2012 at 02:40:46PM +0100, Linus Walleij wrote: diff --git a/include/linux/device.h b/include/linux/device.h index 86ef6ab..dc399ab 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -21,6 +21,7 @@ #include linux/compiler.h #include linux/types.h #include