Re: [PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-10-21 Thread Dmitry Torokhov
On Tue, Oct 16, 2012 at 08:35:56PM -0700, Arve Hjønnevåg wrote: > On Fri, Oct 5, 2012 at 12:48 PM, Mathieu Poirier > wrote: > > On 12-10-05 12:16 PM, Dmitry Torokhov wrote: > >> On Fri, Oct 05, 2012 at 11:59:29AM -0600, mathieu.poir...@linaro.org wrote: > >>> From: "Mathieu J. Poirier" > >>> >

Re: [PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-10-21 Thread Dmitry Torokhov
On Tue, Oct 16, 2012 at 08:35:56PM -0700, Arve Hjønnevåg wrote: On Fri, Oct 5, 2012 at 12:48 PM, Mathieu Poirier mathieu.poir...@linaro.org wrote: On 12-10-05 12:16 PM, Dmitry Torokhov wrote: On Fri, Oct 05, 2012 at 11:59:29AM -0600, mathieu.poir...@linaro.org wrote: From: Mathieu J.

Re: [PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-10-20 Thread Mathieu Poirier
On 12-10-16 09:35 PM, Arve Hjønnevåg wrote: > On Fri, Oct 5, 2012 at 12:48 PM, Mathieu Poirier > wrote: >> On 12-10-05 12:16 PM, Dmitry Torokhov wrote: >>> On Fri, Oct 05, 2012 at 11:59:29AM -0600, mathieu.poir...@linaro.org wrote: From: "Mathieu J. Poirier" Andrew,

Re: [PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-10-20 Thread Mathieu Poirier
On 12-10-16 09:35 PM, Arve Hjønnevåg wrote: On Fri, Oct 5, 2012 at 12:48 PM, Mathieu Poirier mathieu.poir...@linaro.org wrote: On 12-10-05 12:16 PM, Dmitry Torokhov wrote: On Fri, Oct 05, 2012 at 11:59:29AM -0600, mathieu.poir...@linaro.org wrote: From: Mathieu J. Poirier

Re: [PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-10-16 Thread Arve Hjønnevåg
On Fri, Oct 5, 2012 at 12:48 PM, Mathieu Poirier wrote: > On 12-10-05 12:16 PM, Dmitry Torokhov wrote: >> On Fri, Oct 05, 2012 at 11:59:29AM -0600, mathieu.poir...@linaro.org wrote: >>> From: "Mathieu J. Poirier" >>> >>> Andrew, >>> >>> After requesting a number of changes that, to my

Re: [PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-10-16 Thread Arve Hjønnevåg
On Fri, Oct 5, 2012 at 12:48 PM, Mathieu Poirier mathieu.poir...@linaro.org wrote: On 12-10-05 12:16 PM, Dmitry Torokhov wrote: On Fri, Oct 05, 2012 at 11:59:29AM -0600, mathieu.poir...@linaro.org wrote: From: Mathieu J. Poirier mathieu.poir...@linaro.org Andrew, After requesting a number

Re: [PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-10-05 Thread Mathieu Poirier
On 12-10-05 12:16 PM, Dmitry Torokhov wrote: > On Fri, Oct 05, 2012 at 11:59:29AM -0600, mathieu.poir...@linaro.org wrote: >> From: "Mathieu J. Poirier" >> >> Andrew, >> >> After requesting a number of changes that, to my understanding >> have been implemented, I have not been able to get the

Re: [PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-10-05 Thread Dmitry Torokhov
On Fri, Oct 05, 2012 at 07:53:03PM +0100, Alan Cox wrote: > > I have the same objection as before: using platform device solely for > > the purpose of passing some data from board code to the driver. Surely > > there are other ways of passing this bit of data... What about, for > > example, making

Re: [PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-10-05 Thread Alan Cox
> I have the same objection as before: using platform device solely for > the purpose of passing some data from board code to the driver. Surely > there are other ways of passing this bit of data... What about, for > example, making it an empty weak symbol so that board code could > override it

Re: [PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-10-05 Thread Dmitry Torokhov
On Fri, Oct 05, 2012 at 11:59:29AM -0600, mathieu.poir...@linaro.org wrote: > From: "Mathieu J. Poirier" > > Andrew, > > After requesting a number of changes that, to my understanding > have been implemented, I have not been able to get the attention > of the subsystem maintainer on this patch.

[PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-10-05 Thread mathieu . poirier
From: "Mathieu J. Poirier" Andrew, After requesting a number of changes that, to my understanding have been implemented, I have not been able to get the attention of the subsystem maintainer on this patch. If there are still issues, I'm open to making changes but I want to make sure it doesn't

[PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-10-05 Thread mathieu . poirier
From: Mathieu J. Poirier mathieu.poir...@linaro.org Andrew, After requesting a number of changes that, to my understanding have been implemented, I have not been able to get the attention of the subsystem maintainer on this patch. If there are still issues, I'm open to making changes but I want

Re: [PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-10-05 Thread Dmitry Torokhov
On Fri, Oct 05, 2012 at 11:59:29AM -0600, mathieu.poir...@linaro.org wrote: From: Mathieu J. Poirier mathieu.poir...@linaro.org Andrew, After requesting a number of changes that, to my understanding have been implemented, I have not been able to get the attention of the subsystem

Re: [PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-10-05 Thread Alan Cox
I have the same objection as before: using platform device solely for the purpose of passing some data from board code to the driver. Surely there are other ways of passing this bit of data... What about, for example, making it an empty weak symbol so that board code could override it with

Re: [PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-10-05 Thread Dmitry Torokhov
On Fri, Oct 05, 2012 at 07:53:03PM +0100, Alan Cox wrote: I have the same objection as before: using platform device solely for the purpose of passing some data from board code to the driver. Surely there are other ways of passing this bit of data... What about, for example, making it an

Re: [PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-10-05 Thread Mathieu Poirier
On 12-10-05 12:16 PM, Dmitry Torokhov wrote: On Fri, Oct 05, 2012 at 11:59:29AM -0600, mathieu.poir...@linaro.org wrote: From: Mathieu J. Poirier mathieu.poir...@linaro.org Andrew, After requesting a number of changes that, to my understanding have been implemented, I have not been able to

Re: [PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-08-28 Thread Alan Cox
> Please document what button/key combinations those are. It's taken from the platform data. Most phone devices don't have a real keyboard let alone an sysrq key so it's device specific button combos in general that trigger things like power off. > > > The first time the key-combo is detected a

Re: [PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-08-28 Thread Alan Cox
Please document what button/key combinations those are. It's taken from the platform data. Most phone devices don't have a real keyboard let alone an sysrq key so it's device specific button combos in general that trigger things like power off. The first time the key-combo is detected a

Re: [PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-08-27 Thread Randy Dunlap
On 08/27/2012 02:43 PM, mathieu.poir...@linaro.org wrote: > From: "Mathieu J. Poirier" > > This patch adds keyreset functionality to the sysrq driver. It > allows certain button/key combinations to be used in order to > trigger device resets. > Please document what button/key combinations

[PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-08-27 Thread mathieu . poirier
From: "Mathieu J. Poirier" This patch adds keyreset functionality to the sysrq driver. It allows certain button/key combinations to be used in order to trigger device resets. The first time the key-combo is detected a work function that syncs the filesystems is scheduled and the kernel

[PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-08-27 Thread mathieu . poirier
From: Mathieu J. Poirier mathieu.poir...@linaro.org This patch adds keyreset functionality to the sysrq driver. It allows certain button/key combinations to be used in order to trigger device resets. The first time the key-combo is detected a work function that syncs the filesystems is scheduled

Re: [PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-08-27 Thread Randy Dunlap
On 08/27/2012 02:43 PM, mathieu.poir...@linaro.org wrote: From: Mathieu J. Poirier mathieu.poir...@linaro.org This patch adds keyreset functionality to the sysrq driver. It allows certain button/key combinations to be used in order to trigger device resets. Please document what