Re: [PATCH] drivers/vfio: Fix an 8-byte alignment issue

2018-10-18 Thread Joe Perches
On Wed, 2018-10-17 at 13:18 -0500, Wenwen Wang wrote: > This patch adds a 4-byte reserved field in the structure > vfio_eeh_pe_op to make sure that the u64 fields in the structure > vfio_eeh_pe_err are 8-byte aligned. > > Signed-off-by: Wenwen Wang > --- > include/uapi/linux/vfio.h | 1 + > 1

Re: [PATCH] drivers/vfio: Fix an 8-byte alignment issue

2018-10-18 Thread Joe Perches
On Wed, 2018-10-17 at 13:18 -0500, Wenwen Wang wrote: > This patch adds a 4-byte reserved field in the structure > vfio_eeh_pe_op to make sure that the u64 fields in the structure > vfio_eeh_pe_err are 8-byte aligned. > > Signed-off-by: Wenwen Wang > --- > include/uapi/linux/vfio.h | 1 + > 1

Re: [PATCH] drivers/vfio: Fix an 8-byte alignment issue

2018-10-17 Thread Alex Williamson
On Wed, 17 Oct 2018 17:15:33 -0400 Konrad Rzeszutek Wilk wrote: > On Wed, Oct 17, 2018 at 01:18:19PM -0500, Wenwen Wang wrote: > > This patch adds a 4-byte reserved field in the structure > > vfio_eeh_pe_op to make sure that the u64 fields in the structure > > vfio_eeh_pe_err are 8-byte aligned.

Re: [PATCH] drivers/vfio: Fix an 8-byte alignment issue

2018-10-17 Thread Alex Williamson
On Wed, 17 Oct 2018 17:15:33 -0400 Konrad Rzeszutek Wilk wrote: > On Wed, Oct 17, 2018 at 01:18:19PM -0500, Wenwen Wang wrote: > > This patch adds a 4-byte reserved field in the structure > > vfio_eeh_pe_op to make sure that the u64 fields in the structure > > vfio_eeh_pe_err are 8-byte aligned.

Re: [PATCH] drivers/vfio: Fix an 8-byte alignment issue

2018-10-17 Thread Konrad Rzeszutek Wilk
On Wed, Oct 17, 2018 at 01:18:19PM -0500, Wenwen Wang wrote: > This patch adds a 4-byte reserved field in the structure > vfio_eeh_pe_op to make sure that the u64 fields in the structure > vfio_eeh_pe_err are 8-byte aligned. Won't this break 32-bit kernels? That is the size of the structure will

Re: [PATCH] drivers/vfio: Fix an 8-byte alignment issue

2018-10-17 Thread Konrad Rzeszutek Wilk
On Wed, Oct 17, 2018 at 01:18:19PM -0500, Wenwen Wang wrote: > This patch adds a 4-byte reserved field in the structure > vfio_eeh_pe_op to make sure that the u64 fields in the structure > vfio_eeh_pe_err are 8-byte aligned. Won't this break 32-bit kernels? That is the size of the structure will

[PATCH] drivers/vfio: Fix an 8-byte alignment issue

2018-10-17 Thread Wenwen Wang
This patch adds a 4-byte reserved field in the structure vfio_eeh_pe_op to make sure that the u64 fields in the structure vfio_eeh_pe_err are 8-byte aligned. Signed-off-by: Wenwen Wang --- include/uapi/linux/vfio.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/vfio.h

[PATCH] drivers/vfio: Fix an 8-byte alignment issue

2018-10-17 Thread Wenwen Wang
This patch adds a 4-byte reserved field in the structure vfio_eeh_pe_op to make sure that the u64 fields in the structure vfio_eeh_pe_err are 8-byte aligned. Signed-off-by: Wenwen Wang --- include/uapi/linux/vfio.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/vfio.h