Re: [PATCH] drivers/video/pmagb-b-fb.c: Improve diagnostics

2007-09-18 Thread Maciej W. Rozycki
Add error messages to the probe call. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- While they may rarely trigger, they may be useful when something weird is going on. Also this is good style. On Mon, 17 Sep 2007, Mariusz Kozlowski wrote: > You added them but probably forgot to

Re: [PATCH] drivers/video/pmagb-b-fb.c: Improve diagnostics

2007-09-18 Thread Maciej W. Rozycki
Add error messages to the probe call. Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED] --- While they may rarely trigger, they may be useful when something weird is going on. Also this is good style. On Mon, 17 Sep 2007, Mariusz Kozlowski wrote: You added them but probably forgot to

Re: [PATCH] drivers/video/pmagb-b-fb.c: Improve diagnostics

2007-09-17 Thread Mariusz Kozlowski
Hello, > Add error messages to the probe call. You added them but probably forgot to return them ;) > While they may rarely trigger, they may be useful when something weird is > going on. Also this is good style. [snip] > patch-mips-2.6.18-20060920-pmagb-b-err-1 > diff -up --recursive

[PATCH] drivers/video/pmagb-b-fb.c: Improve diagnostics

2007-09-17 Thread Maciej W. Rozycki
Add error messages to the probe call. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- While they may rarely trigger, they may be useful when something weird is going on. Also this is good style. Checked with checkpatch.pl and at the runtime. Please apply; don't be worried about

[PATCH] drivers/video/pmagb-b-fb.c: Improve diagnostics

2007-09-17 Thread Maciej W. Rozycki
Add error messages to the probe call. Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED] --- While they may rarely trigger, they may be useful when something weird is going on. Also this is good style. Checked with checkpatch.pl and at the runtime. Please apply; don't be worried about the

Re: [PATCH] drivers/video/pmagb-b-fb.c: Improve diagnostics

2007-09-17 Thread Mariusz Kozlowski
Hello, Add error messages to the probe call. You added them but probably forgot to return them ;) While they may rarely trigger, they may be useful when something weird is going on. Also this is good style. [snip] patch-mips-2.6.18-20060920-pmagb-b-err-1 diff -up --recursive