Re: [PATCH] drivers: firmware: edd: fixed coding style errors

2013-12-23 Thread Joe Perches
On Mon, 2013-12-23 at 18:53 -0600, Derek Perrin wrote: > On Sunday, December 22, 2013 02:13:39 PM Joe Perches wrote: > > On Sun, 2013-12-22 at 15:17 -0600, Derek Perrin wrote: [] > > One trivial bit too, > > > diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c [] > > > - ssize_t(*show)

Re: [PATCH] drivers: firmware: edd: fixed coding style errors

2013-12-23 Thread Derek Perrin
On Sunday, December 22, 2013 02:13:39 PM Joe Perches wrote: > On Sun, 2013-12-22 at 15:17 -0600, Derek Perrin wrote: > > Fixed coding style errors. Spaces, tab and parenthesis errors. > > There's a real error in this patch. > > When you do whitespace only changes, please > verify that the old

Re: [PATCH] drivers: firmware: edd: fixed coding style errors

2013-12-23 Thread Derek Perrin
On Sunday, December 22, 2013 02:13:39 PM Joe Perches wrote: On Sun, 2013-12-22 at 15:17 -0600, Derek Perrin wrote: Fixed coding style errors. Spaces, tab and parenthesis errors. There's a real error in this patch. When you do whitespace only changes, please verify that the old and new

Re: [PATCH] drivers: firmware: edd: fixed coding style errors

2013-12-23 Thread Joe Perches
On Mon, 2013-12-23 at 18:53 -0600, Derek Perrin wrote: On Sunday, December 22, 2013 02:13:39 PM Joe Perches wrote: On Sun, 2013-12-22 at 15:17 -0600, Derek Perrin wrote: [] One trivial bit too, diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c [] - ssize_t(*show) (struct

Re: [PATCH] drivers: firmware: edd: fixed coding style errors

2013-12-22 Thread Joe Perches
On Sun, 2013-12-22 at 15:17 -0600, Derek Perrin wrote: > Fixed coding style errors. Spaces, tab and parenthesis errors. There's a real error in this patch. When you do whitespace only changes, please verify that the old and new object files produced are unchanged. One trivial bit too, > diff

[PATCH] drivers: firmware: edd: fixed coding style errors

2013-12-22 Thread Derek Perrin
Fixed coding style errors. Spaces, tab and parenthesis errors. Signed-off-by: Derek Perrin --- drivers/firmware/edd.c | 62 +- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c index

[PATCH] drivers: firmware: edd: fixed coding style errors

2013-12-22 Thread Derek Perrin
Fixed coding style errors. Spaces, tab and parenthesis errors. Signed-off-by: Derek Perrin d.ro...@gmail.com --- drivers/firmware/edd.c | 62 +- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/drivers/firmware/edd.c

Re: [PATCH] drivers: firmware: edd: fixed coding style errors

2013-12-22 Thread Joe Perches
On Sun, 2013-12-22 at 15:17 -0600, Derek Perrin wrote: Fixed coding style errors. Spaces, tab and parenthesis errors. There's a real error in this patch. When you do whitespace only changes, please verify that the old and new object files produced are unchanged. One trivial bit too, diff