Re: [PATCH] drivers: of: check input parameter name for __of_find_property

2015-09-16 Thread Peng Fan
On Tue, Sep 15, 2015 at 09:27:59PM -0500, Rob Herring wrote: > On 09/15/2015 07:16 PM, Peng Fan wrote: > > Hi Rob, > > > > On Tue, Sep 15, 2015 at 10:56:28AM -0500, Rob Herring wrote: > >> On 09/11/2015 08:44 AM, Peng Fan wrote: > >>> Check input parameter 'name' for __of_find_property. If name

Re: [PATCH] drivers: of: check input parameter name for __of_find_property

2015-09-16 Thread Peng Fan
On Tue, Sep 15, 2015 at 09:27:59PM -0500, Rob Herring wrote: > On 09/15/2015 07:16 PM, Peng Fan wrote: > > Hi Rob, > > > > On Tue, Sep 15, 2015 at 10:56:28AM -0500, Rob Herring wrote: > >> On 09/11/2015 08:44 AM, Peng Fan wrote: > >>> Check input parameter 'name' for __of_find_property. If name

Re: [PATCH] drivers: of: check input parameter name for __of_find_property

2015-09-15 Thread Rob Herring
On 09/15/2015 07:16 PM, Peng Fan wrote: > Hi Rob, > > On Tue, Sep 15, 2015 at 10:56:28AM -0500, Rob Herring wrote: >> On 09/11/2015 08:44 AM, Peng Fan wrote: >>> Check input parameter 'name' for __of_find_property. If name is NULL, >>> of_prop_cmp->strcasecmp may trigger panic. >> >> Arguably

Re: [PATCH] drivers: of: check input parameter name for __of_find_property

2015-09-15 Thread Peng Fan
Hi Rob, On Tue, Sep 15, 2015 at 10:56:28AM -0500, Rob Herring wrote: > On 09/11/2015 08:44 AM, Peng Fan wrote: > > Check input parameter 'name' for __of_find_property. If name is NULL, > > of_prop_cmp->strcasecmp may trigger panic. > > Arguably that could be a feature. Do you have a usecase

Re: [PATCH] drivers: of: check input parameter name for __of_find_property

2015-09-15 Thread Rob Herring
On 09/11/2015 08:44 AM, Peng Fan wrote: > Check input parameter 'name' for __of_find_property. If name is NULL, > of_prop_cmp->strcasecmp may trigger panic. Arguably that could be a feature. Do you have a usecase where name being NULL is valid and panicking is a problem? Rob > > Signed-off-by:

Re: [PATCH] drivers: of: check input parameter name for __of_find_property

2015-09-15 Thread Peng Fan
Hi Rob, On Tue, Sep 15, 2015 at 10:56:28AM -0500, Rob Herring wrote: > On 09/11/2015 08:44 AM, Peng Fan wrote: > > Check input parameter 'name' for __of_find_property. If name is NULL, > > of_prop_cmp->strcasecmp may trigger panic. > > Arguably that could be a feature. Do you have a usecase

Re: [PATCH] drivers: of: check input parameter name for __of_find_property

2015-09-15 Thread Rob Herring
On 09/15/2015 07:16 PM, Peng Fan wrote: > Hi Rob, > > On Tue, Sep 15, 2015 at 10:56:28AM -0500, Rob Herring wrote: >> On 09/11/2015 08:44 AM, Peng Fan wrote: >>> Check input parameter 'name' for __of_find_property. If name is NULL, >>> of_prop_cmp->strcasecmp may trigger panic. >> >> Arguably

Re: [PATCH] drivers: of: check input parameter name for __of_find_property

2015-09-15 Thread Rob Herring
On 09/11/2015 08:44 AM, Peng Fan wrote: > Check input parameter 'name' for __of_find_property. If name is NULL, > of_prop_cmp->strcasecmp may trigger panic. Arguably that could be a feature. Do you have a usecase where name being NULL is valid and panicking is a problem? Rob > > Signed-off-by:

[PATCH] drivers: of: check input parameter name for __of_find_property

2015-09-11 Thread Peng Fan
Check input parameter 'name' for __of_find_property. If name is NULL, of_prop_cmp->strcasecmp may trigger panic. Signed-off-by: Peng Fan Cc: Rob Herring Cc: Frank Rowand Cc: Grant Likely --- drivers/of/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] drivers: of: check input parameter name for __of_find_property

2015-09-11 Thread Peng Fan
Check input parameter 'name' for __of_find_property. If name is NULL, of_prop_cmp->strcasecmp may trigger panic. Signed-off-by: Peng Fan Cc: Rob Herring Cc: Frank Rowand Cc: Grant Likely ---