Re: [PATCH] drivers: staging: ft1000: Improve coding style

2014-05-09 Thread Joe Perches
On Sat, 2014-05-10 at 09:53 +0300, Artem Fetishev wrote: > Improvements include: > - Lines over 80 characters; > - Use pr_info() instead printk(KERN_INFO); > - Removal of typedefs; > - Indentation. > - Fix IOCTL_FT1000_* marcos: >- Add closing brackets; >- remove sizeof (_IOR and _IOW

[PATCH] drivers: staging: ft1000: Improve coding style

2014-05-09 Thread Artem Fetishev
Improvements include: - Lines over 80 characters; - Use pr_info() instead printk(KERN_INFO); - Removal of typedefs; - Indentation. - Fix IOCTL_FT1000_* marcos: - Add closing brackets; - remove sizeof (_IOR and _IOW macro can accept types); - replace _IOW which size of 0 (the last

[PATCH] drivers: staging: ft1000: Improve coding style

2014-05-09 Thread Artem Fetishev
Improvements include: - Lines over 80 characters; - Use pr_info() instead printk(KERN_INFO); - Removal of typedefs; - Indentation. - Fix IOCTL_FT1000_* marcos: - Add closing brackets; - remove sizeof (_IOR and _IOW macro can accept types); - replace _IOW which size of 0 (the last

Re: [PATCH] drivers: staging: ft1000: Improve coding style

2014-05-09 Thread Joe Perches
On Sat, 2014-05-10 at 09:53 +0300, Artem Fetishev wrote: Improvements include: - Lines over 80 characters; - Use pr_info() instead printk(KERN_INFO); - Removal of typedefs; - Indentation. - Fix IOCTL_FT1000_* marcos: - Add closing brackets; - remove sizeof (_IOR and _IOW macro