Re: [PATCH] drivers: staging: rtl8821ae: Fix spaces required around that '?' errors

2014-08-25 Thread Joe Perches
On Mon, 2014-08-25 at 08:51 -0500, Greg Donald wrote: > On Mon, Aug 25, 2014 at 8:15 AM, Joe Perches wrote: > > On Mon, 2014-08-25 at 06:35 -0500, Greg Donald wrote: > >> Fix checkpatch.pl spaces required around that '?' errors > > > > It'd be better to convert all parts of the > > ternary at the

Re: [PATCH] drivers: staging: rtl8821ae: Fix spaces required around that '?' errors

2014-08-25 Thread Greg Donald
On Mon, Aug 25, 2014 at 8:15 AM, Joe Perches wrote: > On Mon, 2014-08-25 at 06:35 -0500, Greg Donald wrote: >> Fix checkpatch.pl spaces required around that '?' errors > > It'd be better to convert all parts of the > ternary at the same time. Wouldn't "at the same time" be in direct conflict

Re: [PATCH] drivers: staging: rtl8821ae: Fix spaces required around that '?' errors

2014-08-25 Thread Joe Perches
On Mon, 2014-08-25 at 06:35 -0500, Greg Donald wrote: > Fix checkpatch.pl spaces required around that '?' errors It'd be better to convert all parts of the ternary at the same time. > diff --git a/drivers/staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.c >

[PATCH] drivers: staging: rtl8821ae: Fix spaces required around that '?' errors

2014-08-25 Thread Greg Donald
Fix checkpatch.pl spaces required around that '?' errors Signed-off-by: Greg Donald --- .../staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.c | 33 +++--- .../staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.h | 2 +- .../staging/rtl8821ae/btcoexist/habtc8723a1ant.c | 12 ++---

[PATCH] drivers: staging: rtl8821ae: Fix spaces required around that '?' errors

2014-08-25 Thread Greg Donald
Fix checkpatch.pl spaces required around that '?' errors Signed-off-by: Greg Donald gdon...@gmail.com --- .../staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.c | 33 +++--- .../staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.h | 2 +- .../staging/rtl8821ae/btcoexist/habtc8723a1ant.c | 12

Re: [PATCH] drivers: staging: rtl8821ae: Fix spaces required around that '?' errors

2014-08-25 Thread Joe Perches
On Mon, 2014-08-25 at 06:35 -0500, Greg Donald wrote: Fix checkpatch.pl spaces required around that '?' errors It'd be better to convert all parts of the ternary at the same time. diff --git a/drivers/staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.c

Re: [PATCH] drivers: staging: rtl8821ae: Fix spaces required around that '?' errors

2014-08-25 Thread Greg Donald
On Mon, Aug 25, 2014 at 8:15 AM, Joe Perches j...@perches.com wrote: On Mon, 2014-08-25 at 06:35 -0500, Greg Donald wrote: Fix checkpatch.pl spaces required around that '?' errors It'd be better to convert all parts of the ternary at the same time. Wouldn't at the same time be in direct

Re: [PATCH] drivers: staging: rtl8821ae: Fix spaces required around that '?' errors

2014-08-25 Thread Joe Perches
On Mon, 2014-08-25 at 08:51 -0500, Greg Donald wrote: On Mon, Aug 25, 2014 at 8:15 AM, Joe Perches j...@perches.com wrote: On Mon, 2014-08-25 at 06:35 -0500, Greg Donald wrote: Fix checkpatch.pl spaces required around that '?' errors It'd be better to convert all parts of the ternary at

[PATCH] drivers: staging: rtl8821ae: Fix spaces required around that '<' errors

2014-08-24 Thread Greg Donald
Fix checkpatch.pl spaces required around that '<' errors Signed-off-by: Greg Donald --- drivers/staging/rtl8821ae/btcoexist/halbtc8723b2ant.c | 2 +- drivers/staging/rtl8821ae/rtl8821ae/phy.c | 18 +- drivers/staging/rtl8821ae/rtl8821ae/rf.c | 2 +- 3

[PATCH] drivers: staging: rtl8821ae: Fix spaces required around that '' errors

2014-08-24 Thread Greg Donald
Fix checkpatch.pl spaces required around that '' errors Signed-off-by: Greg Donald gdon...@gmail.com --- drivers/staging/rtl8821ae/btcoexist/halbtc8723b2ant.c | 2 +- drivers/staging/rtl8821ae/rtl8821ae/phy.c | 18 +- drivers/staging/rtl8821ae/rtl8821ae/rf.c